Linux CIFS filesystem development
 help / color / mirror / Atom feed
From: Ralph Boehme <slow@samba.org>
To: Andrew Gunnerson <accounts.samba@chiller3.com>,
	Steve French <smfrench@gmail.com>
Cc: samba@lists.samba.org, CIFS <linux-cifs@vger.kernel.org>
Subject: Re: [Samba] Random EINVAL when opening files with SMB3 POSIX extensions enabled
Date: Fri, 29 Nov 2024 17:22:11 +0100	[thread overview]
Message-ID: <6c44d87f-de98-4efd-b016-a491e9c57cb5@samba.org> (raw)
In-Reply-To: <53b97278-a054-4bf1-97cb-e2d648c6868a@app.fastmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 1175 bytes --]

On 11/28/24 9:46 PM, Andrew Gunnerson wrote:
> Thanks for the replies!
> 
> On Thu, Nov 28, 2024, at 04:34, Rowland Penny via samba wrote:
>> I do not use the SMB3 Unix extensions, but perhaps you may not be
>> either, have you tried replacing 'server min protocol = SMB2' (which is
>> the default anyway) with 'server min protocol = SMB3' ?
> 
> I took a packet capture and do see the the client making POSIX extension
> requests, like SMB2_FILE_POSIX_INFO.
> 
> On Thu, Nov 28, 2024, at 04:53, Ralph Boehme wrote:
>> can you grab a network trace when it happens?
> 
> Sure thing! I disabled SMB encryption first since it seemed to make the pcaps
> useless.
> 
> 1. pcap when running `cat <file>`, which fails with EINVAL:
> 
>      https://files.pub.chiller3.com/issues/samba/posix_extensions/2024-11-28/posix_enabled_broken.pcap
> 
it's a client problem.

See packet 30: the client issues an POSIX SMB2-CREATE with a pathname 
starting with a "/" which is not allowed. If you check the working cases 
there the pathnames are relative and don't start with "/".

@Steve: do you have any idea what could be causing this in cifs.ko?

-slow




[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

       reply	other threads:[~2024-11-29 16:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <9995d904-6d0b-4086-b49c-944e845f127e@app.fastmail.com>
     [not found] ` <fa1f85a7-b086-485c-bb25-3c3d8c4cc490@samba.org>
     [not found]   ` <53b97278-a054-4bf1-97cb-e2d648c6868a@app.fastmail.com>
2024-11-29 16:22     ` Ralph Boehme [this message]
2024-12-07  4:34       ` [Samba] Random EINVAL when opening files with SMB3 POSIX extensions enabled Jeremy Allison

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6c44d87f-de98-4efd-b016-a491e9c57cb5@samba.org \
    --to=slow@samba.org \
    --cc=accounts.samba@chiller3.com \
    --cc=linux-cifs@vger.kernel.org \
    --cc=samba@lists.samba.org \
    --cc=smfrench@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox