Re: [Samba] Random EINVAL when opening files with SMB3 POSIX extensions enabled

Re: [Samba] Random EINVAL when opening files with SMB3 POSIX extensions enabled

[Ralph Boehme]

[-- Attachment #1.1: Type: text/plain, Size: 1175 bytes --]

On 11/28/24 9:46 PM, Andrew Gunnerson wrote:
> Thanks for the replies!
> 
> On Thu, Nov 28, 2024, at 04:34, Rowland Penny via samba wrote:
>> I do not use the SMB3 Unix extensions, but perhaps you may not be
>> either, have you tried replacing 'server min protocol = SMB2' (which is
>> the default anyway) with 'server min protocol = SMB3' ?
> 
> I took a packet capture and do see the the client making POSIX extension
> requests, like SMB2_FILE_POSIX_INFO.
> 
> On Thu, Nov 28, 2024, at 04:53, Ralph Boehme wrote:
>> can you grab a network trace when it happens?
> 
> Sure thing! I disabled SMB encryption first since it seemed to make the pcaps
> useless.
> 
> 1. pcap when running `cat <file>`, which fails with EINVAL:
> 
>      https://files.pub.chiller3.com/issues/samba/posix_extensions/2024-11-28/posix_enabled_broken.pcap
> 
it's a client problem.

See packet 30: the client issues an POSIX SMB2-CREATE with a pathname 
starting with a "/" which is not allowed. If you check the working cases 
there the pathnames are relative and don't start with "/".

@Steve: do you have any idea what could be causing this in cifs.ko?

-slow




[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

Re: [Samba] Random EINVAL when opening files with SMB3 POSIX extensions enabled

[Jeremy Allison]

On Fri, Nov 29, 2024 at 05:22:11PM +0100, Ralph Boehme via samba wrote:
>On 11/28/24 9:46 PM, Andrew Gunnerson wrote:
>>Thanks for the replies!
>>
>>On Thu, Nov 28, 2024, at 04:34, Rowland Penny via samba wrote:
>>>I do not use the SMB3 Unix extensions, but perhaps you may not be
>>>either, have you tried replacing 'server min protocol = SMB2' (which is
>>>the default anyway) with 'server min protocol = SMB3' ?
>>
>>I took a packet capture and do see the the client making POSIX extension
>>requests, like SMB2_FILE_POSIX_INFO.
>>
>>On Thu, Nov 28, 2024, at 04:53, Ralph Boehme wrote:
>>>can you grab a network trace when it happens?
>>
>>Sure thing! I disabled SMB encryption first since it seemed to make the pcaps
>>useless.
>>
>>1. pcap when running `cat <file>`, which fails with EINVAL:
>>
>>     https://files.pub.chiller3.com/issues/samba/posix_extensions/2024-11-28/posix_enabled_broken.pcap
>>
>it's a client problem.
>
>See packet 30: the client issues an POSIX SMB2-CREATE with a pathname 
>starting with a "/" which is not allowed. If you check the working 
>cases there the pathnames are relative and don't start with "/".
>
>@Steve: do you have any idea what could be causing this in cifs.ko?

DFS mistake ?