From: "Aurélien Aptel" <aaptel-IBi9RG/b67k@public.gmane.org>
To: ronnie sahlberg <ronniesahlberg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: "linux-cifs\@vger.kernel.org"
<linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Steve French <smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] CIFS: decrease log level of smb2 DFS error
Date: Tue, 21 Nov 2017 14:48:26 +0100 [thread overview]
Message-ID: <87zi7fspxx.fsf@suse.com> (raw)
In-Reply-To: <CAN05THRymsFpZcbXsSQj6=OVd94ZWE1L5a1EQF5-bz8qbG=oFA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
ronnie sahlberg <ronniesahlberg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> writes:
> Since in 99.999999% times happens just because "it is a real share",
> we could optionally change it instead to be wrapped in :
>
> if (rc != <whatever STATUS_NOT_FOUND maps to>)
> cifs_dbg(VFS, log the error message
>
> so that we do not log anything if it is just a normal share
> but that we do log something if there is a real error.
Good idea
--
Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3
SUSE Linux GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
prev parent reply other threads:[~2017-11-21 13:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-21 11:14 [PATCH] CIFS: decrease log level of smb2 DFS error Aurelien Aptel
[not found] ` <20171121111429.14496-1-aaptel-IBi9RG/b67k@public.gmane.org>
2017-11-21 11:22 ` ronnie sahlberg
[not found] ` <CAN05THRymsFpZcbXsSQj6=OVd94ZWE1L5a1EQF5-bz8qbG=oFA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-11-21 13:47 ` [PATCH v2] CIFS: don't log STATUS_NOT_FOUND errors for DFS Aurelien Aptel
[not found] ` <20171121134756.25201-1-aaptel-IBi9RG/b67k@public.gmane.org>
2017-11-21 23:51 ` Pavel Shilovskiy
2017-11-21 13:48 ` Aurélien Aptel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zi7fspxx.fsf@suse.com \
--to=aaptel-ibi9rg/b67k@public.gmane.org \
--cc=linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=ronniesahlberg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox