Linux CIFS filesystem development
 help / color / mirror / Atom feed
From: Aurelien Aptel <aaptel-IBi9RG/b67k@public.gmane.org>
To: linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	Aurelien Aptel <aaptel-IBi9RG/b67k@public.gmane.org>
Subject: [PATCH v2] CIFS: don't log STATUS_NOT_FOUND errors for DFS
Date: Tue, 21 Nov 2017 14:47:56 +0100	[thread overview]
Message-ID: <20171121134756.25201-1-aaptel@suse.com> (raw)
In-Reply-To: <CAN05THRymsFpZcbXsSQj6=OVd94ZWE1L5a1EQF5-bz8qbG=oFA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

cifs.ko makes DFS queries regardless of the type of the server and
non-DFS servers are common. This often results in superfluous logging of
non-critical errors.

Signed-off-by: Aurelien Aptel <aaptel-IBi9RG/b67k@public.gmane.org>
---
v2: instead of always logging at FYI level, only log non-ENOENT errors
    at VFS level

 fs/cifs/smb2ops.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/fs/cifs/smb2ops.c b/fs/cifs/smb2ops.c
index 0dafdbae1f8c..3aa9f46c51e3 100644
--- a/fs/cifs/smb2ops.c
+++ b/fs/cifs/smb2ops.c
@@ -1387,7 +1387,8 @@ smb2_get_dfs_refer(const unsigned int xid, struct cifs_ses *ses,
 	} while (rc == -EAGAIN);
 
 	if (rc) {
-		cifs_dbg(VFS, "ioctl error in smb2_get_dfs_refer rc=%d\n", rc);
+		if (rc != -ENOENT)
+			cifs_dbg(VFS, "ioctl error in smb2_get_dfs_refer rc=%d\n", rc);
 		goto out;
 	}
 
-- 
2.12.3

  parent reply	other threads:[~2017-11-21 13:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-21 11:14 [PATCH] CIFS: decrease log level of smb2 DFS error Aurelien Aptel
     [not found] ` <20171121111429.14496-1-aaptel-IBi9RG/b67k@public.gmane.org>
2017-11-21 11:22   ` ronnie sahlberg
     [not found]     ` <CAN05THRymsFpZcbXsSQj6=OVd94ZWE1L5a1EQF5-bz8qbG=oFA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-11-21 13:47       ` Aurelien Aptel [this message]
     [not found]         ` <20171121134756.25201-1-aaptel-IBi9RG/b67k@public.gmane.org>
2017-11-21 23:51           ` [PATCH v2] CIFS: don't log STATUS_NOT_FOUND errors for DFS Pavel Shilovskiy
2017-11-21 13:48       ` [PATCH] CIFS: decrease log level of smb2 DFS error Aurélien Aptel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171121134756.25201-1-aaptel@suse.com \
    --to=aaptel-ibi9rg/b67k@public.gmane.org \
    --cc=linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox