[PATCH] CIFS: decrease log level of smb2 DFS error

[PATCH] CIFS: decrease log level of smb2 DFS error

[Aurelien Aptel]

Signed-off-by: Aurelien Aptel <aaptel-IBi9RG/b67k@public.gmane.org>
---
 fs/cifs/smb2ops.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/cifs/smb2ops.c b/fs/cifs/smb2ops.c
index 0dafdbae1f8c..59d18a7d550d 100644
--- a/fs/cifs/smb2ops.c
+++ b/fs/cifs/smb2ops.c
@@ -1387,7 +1387,7 @@ smb2_get_dfs_refer(const unsigned int xid, struct cifs_ses *ses,
 	} while (rc == -EAGAIN);
 
 	if (rc) {
-		cifs_dbg(VFS, "ioctl error in smb2_get_dfs_refer rc=%d\n", rc);
+		cifs_dbg(FYI, "ioctl error in smb2_get_dfs_refer rc=%d\n", rc);
 		goto out;
 	}
 
-- 
2.12.3

Re: [PATCH] CIFS: decrease log level of smb2 DFS error

[ronnie sahlberg]

Since in 99.999999% times happens just because "it is a real share",
we could optionally change it instead to be wrapped in :

if (rc != <whatever STATUS_NOT_FOUND maps to>)
     cifs_dbg(VFS, log the error message

so that we do not log anything if it is just a normal share
but that we do log something if there is a real error.




On Tue, Nov 21, 2017 at 9:14 PM, Aurelien Aptel <aaptel-IBi9RG/b67k@public.gmane.org> wrote:
> Signed-off-by: Aurelien Aptel <aaptel-IBi9RG/b67k@public.gmane.org>
> ---
>  fs/cifs/smb2ops.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/cifs/smb2ops.c b/fs/cifs/smb2ops.c
> index 0dafdbae1f8c..59d18a7d550d 100644
> --- a/fs/cifs/smb2ops.c
> +++ b/fs/cifs/smb2ops.c
> @@ -1387,7 +1387,7 @@ smb2_get_dfs_refer(const unsigned int xid, struct cifs_ses *ses,
>         } while (rc == -EAGAIN);
>
>         if (rc) {
> -               cifs_dbg(VFS, "ioctl error in smb2_get_dfs_refer rc=%d\n", rc);
> +               cifs_dbg(FYI, "ioctl error in smb2_get_dfs_refer rc=%d\n", rc);
>                 goto out;
>         }
>
> --
> 2.12.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v2] CIFS: don't log STATUS_NOT_FOUND errors for DFS

[Aurelien Aptel]

cifs.ko makes DFS queries regardless of the type of the server and
non-DFS servers are common. This often results in superfluous logging of
non-critical errors.

Signed-off-by: Aurelien Aptel <aaptel-IBi9RG/b67k@public.gmane.org>
---
v2: instead of always logging at FYI level, only log non-ENOENT errors
    at VFS level

 fs/cifs/smb2ops.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/fs/cifs/smb2ops.c b/fs/cifs/smb2ops.c
index 0dafdbae1f8c..3aa9f46c51e3 100644
--- a/fs/cifs/smb2ops.c
+++ b/fs/cifs/smb2ops.c
@@ -1387,7 +1387,8 @@ smb2_get_dfs_refer(const unsigned int xid, struct cifs_ses *ses,
 	} while (rc == -EAGAIN);
 
 	if (rc) {
-		cifs_dbg(VFS, "ioctl error in smb2_get_dfs_refer rc=%d\n", rc);
+		if (rc != -ENOENT)
+			cifs_dbg(VFS, "ioctl error in smb2_get_dfs_refer rc=%d\n", rc);
 		goto out;
 	}
 
-- 
2.12.3

Re: [PATCH] CIFS: decrease log level of smb2 DFS error

[Aurélien Aptel]

ronnie sahlberg <ronniesahlberg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> writes:
> Since in 99.999999% times happens just because "it is a real share",
> we could optionally change it instead to be wrapped in :
>
> if (rc != <whatever STATUS_NOT_FOUND maps to>)
>      cifs_dbg(VFS, log the error message
>
> so that we do not log anything if it is just a normal share
> but that we do log something if there is a real error.

Good idea

-- 
Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
SUSE Linux GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)

RE: [PATCH v2] CIFS: don't log STATUS_NOT_FOUND errors for DFS

[Pavel Shilovskiy]

2017-11-21 5:47 GMT-08:00 Aurelien Aptel <aaptel-IBi9RG/b67k@public.gmane.org>:
> cifs.ko makes DFS queries regardless of the type of the server and
> non-DFS servers are common. This often results in superfluous logging of
> non-critical errors.
>
> Signed-off-by: Aurelien Aptel <aaptel-IBi9RG/b67k@public.gmane.org>
> ---
> v2: instead of always logging at FYI level, only log non-ENOENT errors
>     at VFS level
>
>  fs/cifs/smb2ops.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/fs/cifs/smb2ops.c b/fs/cifs/smb2ops.c
> index 0dafdbae1f8c..3aa9f46c51e3 100644
> --- a/fs/cifs/smb2ops.c
> +++ b/fs/cifs/smb2ops.c
> @@ -1387,7 +1387,8 @@ smb2_get_dfs_refer(const unsigned int xid, struct cifs_ses *ses,
>         } while (rc == -EAGAIN);
>
>         if (rc) {
> -               cifs_dbg(VFS, "ioctl error in smb2_get_dfs_refer rc=%d\n", rc);
> +               if (rc != -ENOENT)
> +                       cifs_dbg(VFS, "ioctl error in smb2_get_dfs_refer rc=%d\n", rc);
>                 goto out;
>         }
>
> --
> 2.12.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Thanks!

Reviewed-by: Pavel Shilovsky <pshilov-0li6OtcxBFHby3iVrkZq2A@public.gmane.org>

--
Best regards,
Pavel Shilovsky