* [PATCH] smb: client: Use common code in cifs_acl_to_fattr()
@ 2025-10-07 18:10 Markus Elfring
0 siblings, 0 replies; only message in thread
From: Markus Elfring @ 2025-10-07 18:10 UTC (permalink / raw)
To: linux-cifs, samba-technical, Bharath SM, Paulo Alcantara,
Ronnie Sahlberg, Shyam Prasad N, Steve French, Tom Talpey
Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Tue, 7 Oct 2025 20:00:18 +0200
Use an additional label so that a bit of common code can be better reused
at the end of this function implementation.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
fs/smb/client/cifsacl.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/smb/client/cifsacl.c b/fs/smb/client/cifsacl.c
index 63b3b1290bed..ca89f22a72c4 100644
--- a/fs/smb/client/cifsacl.c
+++ b/fs/smb/client/cifsacl.c
@@ -1579,8 +1579,8 @@ cifs_acl_to_fattr(struct cifs_sb_info *cifs_sb, struct cifs_fattr *fattr,
else if (ops->get_acl)
pntsd = ops->get_acl(cifs_sb, inode, path, &acllen, info);
else {
- cifs_put_tlink(tlink);
- return -EOPNOTSUPP;
+ rc = -EOPNOTSUPP;
+ goto put_tlink;
}
/* if we can retrieve the ACL, now parse Access Control Entries, ACEs */
if (IS_ERR(pntsd)) {
@@ -1596,7 +1596,7 @@ cifs_acl_to_fattr(struct cifs_sb_info *cifs_sb, struct cifs_fattr *fattr,
if (rc)
cifs_dbg(VFS, "parse sec desc failed rc = %d\n", rc);
}
-
+put_tlink:
cifs_put_tlink(tlink);
return rc;
--
2.51.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2025-10-07 18:10 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-07 18:10 [PATCH] smb: client: Use common code in cifs_acl_to_fattr() Markus Elfring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox