From: David Howells <dhowells@redhat.com>
To: Tom Talpey <tom@talpey.com>
Cc: dhowells@redhat.com, Stefan Metzmacher <metze@samba.org>,
linux-cifs@vger.kernel.org, Steve French <sfrench@samba.org>
Subject: Re: [PATCH 2/2] smb: client: let smbd_post_send_iter() respect the peers max_send_size and transmit all data
Date: Fri, 20 Jun 2025 13:29:46 +0100 [thread overview]
Message-ID: <962036.1750422586@warthog.procyon.org.uk> (raw)
In-Reply-To: <e07c9bab-5750-4a50-8b38-4ce8c1a214d6@talpey.com>
Tom Talpey <tom@talpey.com> wrote:
> > + if (iter && iov_iter_count(iter) > 0) {
> > + /*
> > + * There is more data to send
> > + */
> > + goto wait_credit;
>
> But, shouldn't the caller have done this overflow check, and looped on
> the fragments and credits? It seems wrong to push the credit check down
> to this level.
Fair point. There's retry handling in the netfs layer - though that only
applies to reads and writes that go through that. Can RDMA be used to
transfer data for other large calls? Dir enumeration or ioctl, for instance.
David
next prev parent reply other threads:[~2025-06-20 12:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-18 16:51 [PATCH 0/2] smb: client: fix problems with smbdirect/rdma mounts Stefan Metzmacher
2025-06-18 16:51 ` [PATCH 1/2] smb: client: fix max_sge overflow in smb_extract_folioq_to_rdma() Stefan Metzmacher
2025-06-19 11:41 ` David Howells
2025-06-19 19:07 ` Tom Talpey
2025-06-18 16:51 ` [PATCH 2/2] smb: client: let smbd_post_send_iter() respect the peers max_send_size and transmit all data Stefan Metzmacher
2025-06-19 11:49 ` David Howells
2025-06-19 19:22 ` Tom Talpey
2025-06-20 12:29 ` David Howells [this message]
2025-06-20 13:33 ` Tom Talpey
2025-06-20 14:56 ` David Howells
2025-06-25 7:59 ` David Howells
2025-06-23 15:46 ` Stefan Metzmacher
2025-06-23 17:28 ` Steve French
2025-06-23 19:48 ` Sasha Levin
2025-06-25 8:00 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=962036.1750422586@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=linux-cifs@vger.kernel.org \
--cc=metze@samba.org \
--cc=sfrench@samba.org \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox