Linux CIFS filesystem development
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Tom Talpey <tom@talpey.com>
Cc: dhowells@redhat.com, Stefan Metzmacher <metze@samba.org>,
	linux-cifs@vger.kernel.org, Steve French <sfrench@samba.org>
Subject: Re: [PATCH 2/2] smb: client: let smbd_post_send_iter() respect the peers max_send_size and transmit all data
Date: Fri, 20 Jun 2025 15:56:58 +0100	[thread overview]
Message-ID: <965636.1750431418@warthog.procyon.org.uk> (raw)
In-Reply-To: <1a05a3ed-87ae-453c-a205-f621262e4fea@talpey.com>

Tom Talpey <tom@talpey.com> wrote:

> My comment on the layering was because the code did not used to do
> this, therefore it seems this is a fundamental change, which I'd greatly
> prefer to avoid.

Yeah.  Ideally, we'd have each netfs subrequest corresponding to one RDMA
operation.  I try to size the subreqs appropriately, both in terms of the
maximum size in bytes and the maximum number of segments in
cifs_prepare_read() and cifs_prepare_write().

David


  reply	other threads:[~2025-06-20 14:57 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-18 16:51 [PATCH 0/2] smb: client: fix problems with smbdirect/rdma mounts Stefan Metzmacher
2025-06-18 16:51 ` [PATCH 1/2] smb: client: fix max_sge overflow in smb_extract_folioq_to_rdma() Stefan Metzmacher
2025-06-19 11:41   ` David Howells
2025-06-19 19:07     ` Tom Talpey
2025-06-18 16:51 ` [PATCH 2/2] smb: client: let smbd_post_send_iter() respect the peers max_send_size and transmit all data Stefan Metzmacher
2025-06-19 11:49   ` David Howells
2025-06-19 19:22   ` Tom Talpey
2025-06-20 12:29     ` David Howells
2025-06-20 13:33       ` Tom Talpey
2025-06-20 14:56         ` David Howells [this message]
2025-06-25  7:59       ` David Howells
2025-06-23 15:46     ` Stefan Metzmacher
2025-06-23 17:28       ` Steve French
2025-06-23 19:48         ` Sasha Levin
2025-06-25  8:00   ` David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=965636.1750431418@warthog.procyon.org.uk \
    --to=dhowells@redhat.com \
    --cc=linux-cifs@vger.kernel.org \
    --cc=metze@samba.org \
    --cc=sfrench@samba.org \
    --cc=tom@talpey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox