Linux CIFS filesystem development
 help / color / mirror / Atom feed
* ksmbd: limit repeated connections from clients with the same IP
@ 2025-08-15 15:42 Stefan Metzmacher
  2025-08-16  0:50 ` Namjae Jeon
  0 siblings, 1 reply; 2+ messages in thread
From: Stefan Metzmacher @ 2025-08-15 15:42 UTC (permalink / raw)
  To: Namjae Jeon, Steve French; +Cc: linux-cifs@vger.kernel.org

Hi Namjae,

this commit relies on IPv4 only, which is wrong!
Can you please have a look, thanks!

commit e6bb9193974059ddbb0ce7763fa3882bd60d4dc3
Author: Namjae Jeon <linkinjeon@kernel.org>
Date:   Tue Aug 5 18:13:13 2025 +0900

     ksmbd: limit repeated connections from clients with the same IP

     Repeated connections from clients with the same IP address may exhaust
     the max connections and prevent other normal client connections.
     This patch limit repeated connections from clients with the same IP.

     Reported-by: tianshuo han <hantianshuo233@gmail.com>
     Cc: stable@vger.kernel.org
     Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
     Signed-off-by: Steve French <stfrench@microsoft.com>

I came to it because smatch reported this:

Warning: server/connection.c:53 function parameter 'inet_addr' not described in 'ksmbd_conn_alloc'

Thanks!
metze

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: ksmbd: limit repeated connections from clients with the same IP
  2025-08-15 15:42 ksmbd: limit repeated connections from clients with the same IP Stefan Metzmacher
@ 2025-08-16  0:50 ` Namjae Jeon
  0 siblings, 0 replies; 2+ messages in thread
From: Namjae Jeon @ 2025-08-16  0:50 UTC (permalink / raw)
  To: Stefan Metzmacher; +Cc: Steve French, linux-cifs@vger.kernel.org

On Sat, Aug 16, 2025 at 12:42 AM Stefan Metzmacher <metze@samba.org> wrote:
>
> Hi Namjae,
>
> this commit relies on IPv4 only, which is wrong!
> Can you please have a look, thanks!
Okay. I will do it.
Thanks!
>
> commit e6bb9193974059ddbb0ce7763fa3882bd60d4dc3
> Author: Namjae Jeon <linkinjeon@kernel.org>
> Date:   Tue Aug 5 18:13:13 2025 +0900
>
>      ksmbd: limit repeated connections from clients with the same IP
>
>      Repeated connections from clients with the same IP address may exhaust
>      the max connections and prevent other normal client connections.
>      This patch limit repeated connections from clients with the same IP.
>
>      Reported-by: tianshuo han <hantianshuo233@gmail.com>
>      Cc: stable@vger.kernel.org
>      Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
>      Signed-off-by: Steve French <stfrench@microsoft.com>
>
> I came to it because smatch reported this:
>
> Warning: server/connection.c:53 function parameter 'inet_addr' not described in 'ksmbd_conn_alloc'
>
> Thanks!
> metze

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-08-16  0:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-15 15:42 ksmbd: limit repeated connections from clients with the same IP Stefan Metzmacher
2025-08-16  0:50 ` Namjae Jeon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox