* [PATCH] ksmbd: Use common code in ksmbd_vfs_set_init_posix_acl()
@ 2025-10-04 18:52 Markus Elfring
0 siblings, 0 replies; only message in thread
From: Markus Elfring @ 2025-10-04 18:52 UTC (permalink / raw)
To: linux-cifs, Hyunchul Lee, Namjae Jeon, Sergey Senozhatsky,
Steve French, Tom Talpey
Cc: LKML, kernel-janitors, Stefan Metzmacher
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 4 Oct 2025 20:45:22 +0200
Use an additional label so that another bit of common code can be better
reused at the end of this function implementation.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
fs/smb/server/vfs.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/fs/smb/server/vfs.c b/fs/smb/server/vfs.c
index 891ed2dc2b73..e53aa294b9ef 100644
--- a/fs/smb/server/vfs.c
+++ b/fs/smb/server/vfs.c
@@ -1897,8 +1897,8 @@ int ksmbd_vfs_set_init_posix_acl(struct mnt_idmap *idmap,
acls = posix_acl_alloc(6, KSMBD_DEFAULT_GFP);
if (!acls) {
- free_acl_state(&acl_state);
- return -ENOMEM;
+ rc = -ENOMEM;
+ goto free_acl_state;
}
posix_state_to_acl(&acl_state, acls->a_entries);
@@ -1914,8 +1914,9 @@ int ksmbd_vfs_set_init_posix_acl(struct mnt_idmap *idmap,
rc);
}
- free_acl_state(&acl_state);
posix_acl_release(acls);
+free_acl_state:
+ free_acl_state(&acl_state);
return rc;
}
--
2.51.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2025-10-04 18:53 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-04 18:52 [PATCH] ksmbd: Use common code in ksmbd_vfs_set_init_posix_acl() Markus Elfring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox