* [PATCH] smb: client: Delete duplicate error code assignments in cifs_xattr_set()
@ 2025-10-10 12:28 Markus Elfring
0 siblings, 0 replies; only message in thread
From: Markus Elfring @ 2025-10-10 12:28 UTC (permalink / raw)
To: linux-cifs, samba-technical, Bharath SM, Boris Protopopov,
Paulo Alcantara, Ronnie Sahlberg, Shyam Prasad N, Steve French,
Tom Talpey
Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 10 Oct 2025 14:10:22 +0200
The local variable “rc” is initialised with an error code.
Thus omit two repeated assignment statements according to this value.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
fs/smb/client/xattr.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/fs/smb/client/xattr.c b/fs/smb/client/xattr.c
index b88fa04f5792..a74d12d36176 100644
--- a/fs/smb/client/xattr.c
+++ b/fs/smb/client/xattr.c
@@ -127,7 +127,6 @@ static int cifs_xattr_set(const struct xattr_handler *handler,
returns as xattrs */
if (size > MAX_EA_VALUE_SIZE) {
cifs_dbg(FYI, "size of EA value too large\n");
- rc = -EOPNOTSUPP;
goto out;
}
@@ -206,8 +205,6 @@ static int cifs_xattr_set(const struct xattr_handler *handler,
rc = pTcon->ses->server->ops->set_acl(pacl,
size, inode, full_path, aclflags);
- } else {
- rc = -EOPNOTSUPP;
}
if (rc == 0) /* force revalidate of the inode */
CIFS_I(inode)->time = 0;
--
2.51.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2025-10-10 12:28 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-10 12:28 [PATCH] smb: client: Delete duplicate error code assignments in cifs_xattr_set() Markus Elfring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox