From: Paulo Alcantara <pc@manguebit.com>
To: Namjae Jeon <linkinjeon@kernel.org>, CIFS <linux-cifs@vger.kernel.org>
Cc: Steve French <smfrench@gmail.com>, Tom Talpey <tom@talpey.com>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
atheik <atteh.mailbox@gmail.com>
Subject: Re: ksmbd: fix wrong name of SMB2_CREATE_ALLOCATION_SIZE
Date: Tue, 05 Dec 2023 21:06:28 -0300 [thread overview]
Message-ID: <fb9c59cf8da2881158d54014feaadee5@manguebit.com> (raw)
In-Reply-To: <CAKYAXd_2diW78c1kCehQ3suGyOC6Zj_3fn=A=_GzFAbL8D4nQw@mail.gmail.com>
Namjae Jeon <linkinjeon@kernel.org> writes:
> MS confirm that "AISi" name of SMB2_CREATE_ALLOCATION_SIZE in MS-SMB2
> specification is a typo. cifs/ksmbd have been using this wrong name from
> MS-SMB2. It should be "AlSi". Also It will cause problem when running
> smb2.create.open test in smbtorture against ksmbd.
I see only ksmbd using it.
> Cc: stable@vger.kernel.org
> Fixes: 12197a7fdda9 ("Clarify SMB2/SMB3 create context and add missing ones")
> Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
> ---
> fs/smb/common/smb2pdu.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Looks good,
Reviewed-by: Paulo Alcantara (SUSE) <pc@manguebit.com>
prev parent reply other threads:[~2023-12-06 0:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-05 23:46 ksmbd: fix wrong name of SMB2_CREATE_ALLOCATION_SIZE Namjae Jeon
2023-12-06 0:06 ` Paulo Alcantara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb9c59cf8da2881158d54014feaadee5@manguebit.com \
--to=pc@manguebit.com \
--cc=atteh.mailbox@gmail.com \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=senozhatsky@chromium.org \
--cc=smfrench@gmail.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox