* ksmbd: fix wrong name of SMB2_CREATE_ALLOCATION_SIZE
@ 2023-12-05 23:46 Namjae Jeon
2023-12-06 0:06 ` Paulo Alcantara
0 siblings, 1 reply; 2+ messages in thread
From: Namjae Jeon @ 2023-12-05 23:46 UTC (permalink / raw)
To: CIFS; +Cc: Steve French, Tom Talpey, Sergey Senozhatsky, atheik
MS confirm that "AISi" name of SMB2_CREATE_ALLOCATION_SIZE in MS-SMB2
specification is a typo. cifs/ksmbd have been using this wrong name from
MS-SMB2. It should be "AlSi". Also It will cause problem when running
smb2.create.open test in smbtorture against ksmbd.
Cc: stable@vger.kernel.org
Fixes: 12197a7fdda9 ("Clarify SMB2/SMB3 create context and add missing ones")
Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
---
fs/smb/common/smb2pdu.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/smb/common/smb2pdu.h b/fs/smb/common/smb2pdu.h
index e373018259e5..5a721c952c2f 100644
--- a/fs/smb/common/smb2pdu.h
+++ b/fs/smb/common/smb2pdu.h
@@ -1142,7 +1142,7 @@ struct smb2_server_client_notification {
#define SMB2_CREATE_SD_BUFFER "SecD" /* security descriptor */
#define SMB2_CREATE_DURABLE_HANDLE_REQUEST "DHnQ"
#define SMB2_CREATE_DURABLE_HANDLE_RECONNECT "DHnC"
-#define SMB2_CREATE_ALLOCATION_SIZE "AISi"
+#define SMB2_CREATE_ALLOCATION_SIZE "AlSi"
#define SMB2_CREATE_QUERY_MAXIMAL_ACCESS_REQUEST "MxAc"
#define SMB2_CREATE_TIMEWARP_REQUEST "TWrp"
#define SMB2_CREATE_QUERY_ON_DISK_ID "QFid"
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: ksmbd: fix wrong name of SMB2_CREATE_ALLOCATION_SIZE
2023-12-05 23:46 ksmbd: fix wrong name of SMB2_CREATE_ALLOCATION_SIZE Namjae Jeon
@ 2023-12-06 0:06 ` Paulo Alcantara
0 siblings, 0 replies; 2+ messages in thread
From: Paulo Alcantara @ 2023-12-06 0:06 UTC (permalink / raw)
To: Namjae Jeon, CIFS; +Cc: Steve French, Tom Talpey, Sergey Senozhatsky, atheik
Namjae Jeon <linkinjeon@kernel.org> writes:
> MS confirm that "AISi" name of SMB2_CREATE_ALLOCATION_SIZE in MS-SMB2
> specification is a typo. cifs/ksmbd have been using this wrong name from
> MS-SMB2. It should be "AlSi". Also It will cause problem when running
> smb2.create.open test in smbtorture against ksmbd.
I see only ksmbd using it.
> Cc: stable@vger.kernel.org
> Fixes: 12197a7fdda9 ("Clarify SMB2/SMB3 create context and add missing ones")
> Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
> ---
> fs/smb/common/smb2pdu.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Looks good,
Reviewed-by: Paulo Alcantara (SUSE) <pc@manguebit.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-12-06 0:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-05 23:46 ksmbd: fix wrong name of SMB2_CREATE_ALLOCATION_SIZE Namjae Jeon
2023-12-06 0:06 ` Paulo Alcantara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox