* [PATCH] cifs: remove redundant return in cifs_creation_time_get
@ 2017-06-06 23:33 Colin King
[not found] ` <20170606233345.5980-1-colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Colin King @ 2017-06-06 23:33 UTC (permalink / raw)
To: Steve French, linux-cifs-u79uwXL29TY76Z2rM5mHXA,
samba-technical-w/Ol4Ecudpl8XjKLYN78aQ
Cc: kernel-janitors-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
From: Colin Ian King <colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
There is a redundant return in function cifs_creation_time_get
that appears to be old vestigial code than can be removed. So
remove it.
Detected by CoverityScan, CID#1361924 ("Structurally dead code")
Signed-off-by: Colin Ian King <colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
---
fs/cifs/xattr.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/fs/cifs/xattr.c b/fs/cifs/xattr.c
index 3cb5c9e2d4e7..de50e749ff05 100644
--- a/fs/cifs/xattr.c
+++ b/fs/cifs/xattr.c
@@ -188,8 +188,6 @@ static int cifs_creation_time_get(struct dentry *dentry, struct inode *inode,
pcreatetime = (__u64 *)value;
*pcreatetime = CIFS_I(inode)->createtime;
return sizeof(__u64);
-
- return rc;
}
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread[parent not found: <20170606233345.5980-1-colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>]
* Re: [PATCH] cifs: remove redundant return in cifs_creation_time_get [not found] ` <20170606233345.5980-1-colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org> @ 2017-06-07 13:00 ` Aurélien Aptel 2017-06-21 16:59 ` Steve French 0 siblings, 1 reply; 3+ messages in thread From: Aurélien Aptel @ 2017-06-07 13:00 UTC (permalink / raw) To: Colin King, Steve French, linux-cifs-u79uwXL29TY76Z2rM5mHXA, samba-technical-w/Ol4Ecudpl8XjKLYN78aQ Cc: kernel-janitors-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA Looks good to me. -- Aurélien Aptel / SUSE Labs Samba Team GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3 SUSE Linux GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] cifs: remove redundant return in cifs_creation_time_get 2017-06-07 13:00 ` Aurélien Aptel @ 2017-06-21 16:59 ` Steve French 0 siblings, 0 replies; 3+ messages in thread From: Steve French @ 2017-06-21 16:59 UTC (permalink / raw) To: Aurélien Aptel Cc: Colin King, Steve French, linux-cifs@vger.kernel.org, samba-technical, kernel-janitors, LKML merged into cifs-2.6.git for-next On Wed, Jun 7, 2017 at 8:00 AM, Aurélien Aptel <aaptel@suse.com> wrote: > > Looks good to me. > > -- > Aurélien Aptel / SUSE Labs Samba Team > GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3 > SUSE Linux GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany > GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) > -- > To unsubscribe from this list: send the line "unsubscribe linux-cifs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Thanks, Steve ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-06-21 16:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-06 23:33 [PATCH] cifs: remove redundant return in cifs_creation_time_get Colin King
[not found] ` <20170606233345.5980-1-colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
2017-06-07 13:00 ` Aurélien Aptel
2017-06-21 16:59 ` Steve French
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox