From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Varadarajan Narayanan <quic_varada@quicinc.com>,
Stephen Boyd <sboyd@kernel.org>
Cc: andersson@kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org, djakov@kernel.org,
dmitry.baryshkov@linaro.org, konrad.dybcio@linaro.org,
krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, mturquette@baylibre.com,
quic_anusha@quicinc.com, robh@kernel.org
Subject: Re: [PATCH v5 4/5] clk: qcom: ipq9574: Use icc-clk for enabling NoC related clocks
Date: Fri, 29 Mar 2024 13:10:03 +0100 [thread overview]
Message-ID: <031d0a35-b192-4161-beef-97b89d5d1da6@linaro.org> (raw)
In-Reply-To: <ZgaeGZL7QXh75aSA@hu-varada-blr.qualcomm.com>
On 29/03/2024 11:55, Varadarajan Narayanan wrote:
>>> +
>>> +enum {
>>> + ICC_ANOC_PCIE0,
>>> + ICC_SNOC_PCIE0,
>>> + ICC_ANOC_PCIE1,
>>> + ICC_SNOC_PCIE1,
>>> + ICC_ANOC_PCIE2,
>>> + ICC_SNOC_PCIE2,
>>> + ICC_ANOC_PCIE3,
>>> + ICC_SNOC_PCIE3,
>>> + ICC_SNOC_USB,
>>> + ICC_ANOC_USB_AXI,
>>> + ICC_NSSNOC_NSSCC,
>>> + ICC_NSSNOC_SNOC_0,
>>> + ICC_NSSNOC_SNOC_1,
>>> + ICC_NSSNOC_PCNOC_1,
>>> + ICC_NSSNOC_QOSGEN_REF,
>>> + ICC_NSSNOC_TIMEOUT_REF,
>>> + ICC_NSSNOC_XO_DCD,
>>> + ICC_NSSNOC_ATB,
>>> + ICC_MEM_NOC_NSSNOC,
>>> + ICC_NSSNOC_MEMNOC,
>>> + ICC_NSSNOC_MEM_NOC_1,
>>> +};
>>
>> Are these supposed to be in a dt-binding header?
>
> Since these don't directly relate to the ids in the dt-bindings
> not sure if they will be permitted there. Will move and post a
> new version and get feedback.
You can answer this by yourself by looking at your DTS. Do you use them
as well in the DTS?
It's a pity we see here only parts of DTS, instead of full interconnect
usage.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-03-29 12:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-28 7:59 [PATCH v5 0/5] Add interconnect driver for IPQ9574 SoC Varadarajan Narayanan
2024-03-28 7:59 ` [PATCH v5 1/5] dt-bindings: interconnect: Add Qualcomm IPQ9574 support Varadarajan Narayanan
2024-03-30 10:30 ` Krzysztof Kozlowski
2024-03-28 7:59 ` [PATCH v5 2/5] interconnect: icc-clk: Add devm_icc_clk_register Varadarajan Narayanan
2024-03-28 7:59 ` [PATCH v5 3/5] clk: qcom: common: Add interconnect clocks support Varadarajan Narayanan
2024-03-28 21:54 ` Stephen Boyd
2024-03-29 10:48 ` Varadarajan Narayanan
2024-04-05 21:25 ` Stephen Boyd
2024-03-28 7:59 ` [PATCH v5 4/5] clk: qcom: ipq9574: Use icc-clk for enabling NoC related clocks Varadarajan Narayanan
2024-03-28 21:51 ` Stephen Boyd
2024-03-29 10:55 ` Varadarajan Narayanan
2024-03-29 12:10 ` Krzysztof Kozlowski [this message]
2024-03-30 9:30 ` Varadarajan Narayanan
2024-03-30 10:28 ` Krzysztof Kozlowski
2024-03-30 11:17 ` Varadarajan Narayanan
2024-04-01 14:20 ` kernel test robot
2024-03-28 7:59 ` [PATCH v5 5/5] arm64: dts: qcom: ipq9574: Add icc provider ability to gcc Varadarajan Narayanan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=031d0a35-b192-4161-beef-97b89d5d1da6@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_anusha@quicinc.com \
--cc=quic_varada@quicinc.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox