[PATCH v3 0/3] ARM: at91: USB Device Port fixes

[PATCH v3 0/3] ARM: at91: USB Device Port fixes

[Michael Grzeschik]

This series fixes the UDP (USB Device Port) on the
at91rm9200 and at91sam9g20.

Cc: nicolas.ferre@microchip.com
Cc: alexandre.belloni@bootlin.com
Cc: linux-clk@vger.kernel.org
Cc: kernel@pengutronix.de

Michael Grzeschik (3):
  clk: at91: rm9200: fix usb device clock id
  ARM: dts: at91: rm9200: fix usb device clk id
  ARM: dts: at91: sam9g20ek: enable udc vbus gpio pinctrl

 arch/arm/boot/dts/at91rm9200.dtsi           | 2 +-
 arch/arm/boot/dts/at91sam9g20ek_common.dtsi | 9 +++++++++
 drivers/clk/at91/at91rm9200.c               | 2 +-
 3 files changed, 11 insertions(+), 2 deletions(-)

-- 
2.30.2

[PATCH v3 1/3] clk: at91: rm9200: fix usb device clock id

[Michael Grzeschik]

Referring to the datasheet the index 2 is the MCKUDP. When enabled, it
"Enables the automatic disable of the Master Clock of the USB Device
Port when a suspend condition occurs". We fix the index to the real UDP
id which "Enables the 48 MHz clock of the USB Device Port".

Cc: mturquette@baylibre.com
Cc: sboyd@kernel.org
Cc: nicolas.ferre@microchip.com
Cc: alexandre.belloni@bootlin.com
Cc: ludovic.desroches@microchip.com
Cc: claudiu.beznea@microchip.com
Cc: linux-clk@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: kernel@pengutronix.de
Fixes: 02ff48e4d7f7 ("clk: at91: add at91rm9200 pmc driver")
Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>

---
v1 -> v2: - removed ; from patch description
          - added fixes tag
v2 -> v3: - updated the fixes tag

 drivers/clk/at91/at91rm9200.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/at91/at91rm9200.c b/drivers/clk/at91/at91rm9200.c
index b174f727a8ef8d..16870943a13e54 100644
--- a/drivers/clk/at91/at91rm9200.c
+++ b/drivers/clk/at91/at91rm9200.c
@@ -40,7 +40,7 @@ static const struct clk_pll_characteristics rm9200_pll_characteristics = {
 };
 
 static const struct sck at91rm9200_systemck[] = {
-	{ .n = "udpck", .p = "usbck",    .id = 2 },
+	{ .n = "udpck", .p = "usbck",    .id = 1 },
 	{ .n = "uhpck", .p = "usbck",    .id = 4 },
 	{ .n = "pck0",  .p = "prog0",    .id = 8 },
 	{ .n = "pck1",  .p = "prog1",    .id = 9 },
-- 
2.30.2

Re: [PATCH v3 1/3] clk: at91: rm9200: fix usb device clock id

[Claudiu.Beznea]

On 09.11.2022 14:46, Michael Grzeschik wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> Referring to the datasheet the index 2 is the MCKUDP. When enabled, it
> "Enables the automatic disable of the Master Clock of the USB Device
> Port when a suspend condition occurs". We fix the index to the real UDP
> id which "Enables the 48 MHz clock of the USB Device Port".
> 
> Cc: mturquette@baylibre.com
> Cc: sboyd@kernel.org
> Cc: nicolas.ferre@microchip.com
> Cc: alexandre.belloni@bootlin.com
> Cc: ludovic.desroches@microchip.com
> Cc: claudiu.beznea@microchip.com
> Cc: linux-clk@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: kernel@pengutronix.de
> Fixes: 02ff48e4d7f7 ("clk: at91: add at91rm9200 pmc driver")
> Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>

Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>


> 
> ---
> v1 -> v2: - removed ; from patch description
>           - added fixes tag
> v2 -> v3: - updated the fixes tag
> 
>  drivers/clk/at91/at91rm9200.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/at91/at91rm9200.c b/drivers/clk/at91/at91rm9200.c
> index b174f727a8ef8d..16870943a13e54 100644
> --- a/drivers/clk/at91/at91rm9200.c
> +++ b/drivers/clk/at91/at91rm9200.c
> @@ -40,7 +40,7 @@ static const struct clk_pll_characteristics rm9200_pll_characteristics = {
>  };
> 
>  static const struct sck at91rm9200_systemck[] = {
> -       { .n = "udpck", .p = "usbck",    .id = 2 },
> +       { .n = "udpck", .p = "usbck",    .id = 1 },
>         { .n = "uhpck", .p = "usbck",    .id = 4 },
>         { .n = "pck0",  .p = "prog0",    .id = 8 },
>         { .n = "pck1",  .p = "prog1",    .id = 9 },
> --
> 2.30.2
> 

Re: [PATCH v3 1/3] clk: at91: rm9200: fix usb device clock id

[Claudiu.Beznea]

On 10.11.2022 12:41, Claudiu Beznea - M18063 wrote:
> On 09.11.2022 14:46, Michael Grzeschik wrote:
>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>>
>> Referring to the datasheet the index 2 is the MCKUDP. When enabled, it
>> "Enables the automatic disable of the Master Clock of the USB Device
>> Port when a suspend condition occurs". We fix the index to the real UDP
>> id which "Enables the 48 MHz clock of the USB Device Port".
>>
>> Cc: mturquette@baylibre.com
>> Cc: sboyd@kernel.org
>> Cc: nicolas.ferre@microchip.com
>> Cc: alexandre.belloni@bootlin.com
>> Cc: ludovic.desroches@microchip.com
>> Cc: claudiu.beznea@microchip.com
>> Cc: linux-clk@vger.kernel.org
>> Cc: linux-arm-kernel@lists.infradead.org
>> Cc: kernel@pengutronix.de
>> Fixes: 02ff48e4d7f7 ("clk: at91: add at91rm9200 pmc driver")
>> Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
> 
> Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>

Actually, looking again at this... I think it is best to squash this patch
with path 2/3 from this series. Otherwise applying them independently will
lead to usb driver probe failure. Back porting them (with proper
dependency) to older kernel version may also lead to failures.

> 
> 
>>
>> ---
>> v1 -> v2: - removed ; from patch description
>>           - added fixes tag
>> v2 -> v3: - updated the fixes tag
>>
>>  drivers/clk/at91/at91rm9200.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/clk/at91/at91rm9200.c b/drivers/clk/at91/at91rm9200.c
>> index b174f727a8ef8d..16870943a13e54 100644
>> --- a/drivers/clk/at91/at91rm9200.c
>> +++ b/drivers/clk/at91/at91rm9200.c
>> @@ -40,7 +40,7 @@ static const struct clk_pll_characteristics rm9200_pll_characteristics = {
>>  };
>>
>>  static const struct sck at91rm9200_systemck[] = {
>> -       { .n = "udpck", .p = "usbck",    .id = 2 },
>> +       { .n = "udpck", .p = "usbck",    .id = 1 },
>>         { .n = "uhpck", .p = "usbck",    .id = 4 },
>>         { .n = "pck0",  .p = "prog0",    .id = 8 },
>>         { .n = "pck1",  .p = "prog1",    .id = 9 },
>> --
>> 2.30.2
>>
> 

Re: [PATCH v3 1/3] clk: at91: rm9200: fix usb device clock id

[Michael Grzeschik]

[-- Attachment #1: Type: text/plain, Size: 2864 bytes --]

On Fri, Nov 11, 2022 at 11:00:53AM +0000, Claudiu.Beznea@microchip.com wrote:
>On 10.11.2022 12:41, Claudiu Beznea - M18063 wrote:
>> On 09.11.2022 14:46, Michael Grzeschik wrote:
>>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>>>
>>> Referring to the datasheet the index 2 is the MCKUDP. When enabled, it
>>> "Enables the automatic disable of the Master Clock of the USB Device
>>> Port when a suspend condition occurs". We fix the index to the real UDP
>>> id which "Enables the 48 MHz clock of the USB Device Port".
>>>
>>> Cc: mturquette@baylibre.com
>>> Cc: sboyd@kernel.org
>>> Cc: nicolas.ferre@microchip.com
>>> Cc: alexandre.belloni@bootlin.com
>>> Cc: ludovic.desroches@microchip.com
>>> Cc: claudiu.beznea@microchip.com
>>> Cc: linux-clk@vger.kernel.org
>>> Cc: linux-arm-kernel@lists.infradead.org
>>> Cc: kernel@pengutronix.de
>>> Fixes: 02ff48e4d7f7 ("clk: at91: add at91rm9200 pmc driver")
>>> Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
>>
>> Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>
>
>Actually, looking again at this... I think it is best to squash this patch
>with path 2/3 from this series. Otherwise applying them independently will
>lead to usb driver probe failure. Back porting them (with proper
>dependency) to older kernel version may also lead to failures.


I just send v4.


>>
>>
>>>
>>> ---
>>> v1 -> v2: - removed ; from patch description
>>>           - added fixes tag
>>> v2 -> v3: - updated the fixes tag
>>>
>>>  drivers/clk/at91/at91rm9200.c | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/clk/at91/at91rm9200.c b/drivers/clk/at91/at91rm9200.c
>>> index b174f727a8ef8d..16870943a13e54 100644
>>> --- a/drivers/clk/at91/at91rm9200.c
>>> +++ b/drivers/clk/at91/at91rm9200.c
>>> @@ -40,7 +40,7 @@ static const struct clk_pll_characteristics rm9200_pll_characteristics = {
>>>  };
>>>
>>>  static const struct sck at91rm9200_systemck[] = {
>>> -       { .n = "udpck", .p = "usbck",    .id = 2 },
>>> +       { .n = "udpck", .p = "usbck",    .id = 1 },
>>>         { .n = "uhpck", .p = "usbck",    .id = 4 },
>>>         { .n = "pck0",  .p = "prog0",    .id = 8 },
>>>         { .n = "pck1",  .p = "prog1",    .id = 9 },
>>> --
>>> 2.30.2
>>>
>>
>
>_______________________________________________
>linux-arm-kernel mailing list
>linux-arm-kernel@lists.infradead.org
>http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]