* [PATCH] clk: cdce706: Add missing of_clk_del_provider call in cdce706_remove
@ 2015-05-21 14:26 Axel Lin
2015-05-21 18:14 ` Stephen Boyd
2015-05-21 18:39 ` Max Filippov
0 siblings, 2 replies; 5+ messages in thread
From: Axel Lin @ 2015-05-21 14:26 UTC (permalink / raw)
To: Mike Turquette; +Cc: Stephen Boyd, Max Filippov, linux-clk
Remove a previously registered clock provider when unload the module.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/clk/clk-cdce706.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/clk-cdce706.c b/drivers/clk/clk-cdce706.c
index 8a2dfd0..f01164f 100644
--- a/drivers/clk/clk-cdce706.c
+++ b/drivers/clk/clk-cdce706.c
@@ -666,6 +666,7 @@ static int cdce706_probe(struct i2c_client *client,
static int cdce706_remove(struct i2c_client *client)
{
+ of_clk_del_provider(client->dev.of_node);
return 0;
}
--
2.1.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] clk: cdce706: Add missing of_clk_del_provider call in cdce706_remove
2015-05-21 14:26 [PATCH] clk: cdce706: Add missing of_clk_del_provider call in cdce706_remove Axel Lin
@ 2015-05-21 18:14 ` Stephen Boyd
2015-05-21 18:35 ` Max Filippov
2015-05-21 18:39 ` Max Filippov
1 sibling, 1 reply; 5+ messages in thread
From: Stephen Boyd @ 2015-05-21 18:14 UTC (permalink / raw)
To: Axel Lin; +Cc: Mike Turquette, Max Filippov, linux-clk
On 05/21, Axel Lin wrote:
> Remove a previously registered clock provider when unload the module.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
What about all the clocks that are registered? Don't those need
to be unregistered as well?
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] clk: cdce706: Add missing of_clk_del_provider call in cdce706_remove
2015-05-21 18:14 ` Stephen Boyd
@ 2015-05-21 18:35 ` Max Filippov
2015-05-21 18:53 ` Stephen Boyd
0 siblings, 1 reply; 5+ messages in thread
From: Max Filippov @ 2015-05-21 18:35 UTC (permalink / raw)
To: Stephen Boyd; +Cc: Axel Lin, Mike Turquette, linux-clk
On Thu, May 21, 2015 at 9:14 PM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> On 05/21, Axel Lin wrote:
>> Remove a previously registered clock provider when unload the module.
>>
>> Signed-off-by: Axel Lin <axel.lin@ingics.com>
>> ---
>
> What about all the clocks that are registered? Don't those need
> to be unregistered as well?
They're registered with devm_clk_register, should be managed automatically.
--
Thanks.
-- Max
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] clk: cdce706: Add missing of_clk_del_provider call in cdce706_remove
2015-05-21 18:35 ` Max Filippov
@ 2015-05-21 18:53 ` Stephen Boyd
0 siblings, 0 replies; 5+ messages in thread
From: Stephen Boyd @ 2015-05-21 18:53 UTC (permalink / raw)
To: Max Filippov; +Cc: Axel Lin, Mike Turquette, linux-clk
On 05/21/15 11:35, Max Filippov wrote:
> On Thu, May 21, 2015 at 9:14 PM, Stephen Boyd <sboyd@codeaurora.org> wrote:
>> On 05/21, Axel Lin wrote:
>>> Remove a previously registered clock provider when unload the module.
>>>
>>> Signed-off-by: Axel Lin <axel.lin@ingics.com>
>>> ---
>> What about all the clocks that are registered? Don't those need
>> to be unregistered as well?
> They're registered with devm_clk_register, should be managed automatically.
>
Ah good. Applied.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] clk: cdce706: Add missing of_clk_del_provider call in cdce706_remove
2015-05-21 14:26 [PATCH] clk: cdce706: Add missing of_clk_del_provider call in cdce706_remove Axel Lin
2015-05-21 18:14 ` Stephen Boyd
@ 2015-05-21 18:39 ` Max Filippov
1 sibling, 0 replies; 5+ messages in thread
From: Max Filippov @ 2015-05-21 18:39 UTC (permalink / raw)
To: Axel Lin; +Cc: Mike Turquette, Stephen Boyd, linux-clk
On Thu, May 21, 2015 at 5:26 PM, Axel Lin <axel.lin@ingics.com> wrote:
> Remove a previously registered clock provider when unload the module.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/clk/clk-cdce706.c | 1 +
> 1 file changed, 1 insertion(+)
Good catch, thank you!
Acked-by: Max Filippov <jcmvbkbc@gmail.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-05-21 18:53 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-21 14:26 [PATCH] clk: cdce706: Add missing of_clk_del_provider call in cdce706_remove Axel Lin
2015-05-21 18:14 ` Stephen Boyd
2015-05-21 18:35 ` Max Filippov
2015-05-21 18:53 ` Stephen Boyd
2015-05-21 18:39 ` Max Filippov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox