* [PATCH] clk: qcom: sm6115: Select QCOM_GDSC
@ 2022-09-10 17:02 Dang Huynh
2022-09-12 13:16 ` Caleb Connolly
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Dang Huynh @ 2022-09-10 17:02 UTC (permalink / raw)
To: Dang Huynh
Cc: Bjorn Andersson, Andy Gross, Konrad Dybcio, Michael Turquette,
Stephen Boyd, linux-arm-msm, linux-clk, linux-kernel
While working on the Fxtec Pro1X device, this error shows up with
my own minimal configuration:
gcc-sm6115: probe of 1400000.clock-controller failed with error -38
The clock driver depends on CONFIG_QCOM_GDSC and after enabling
that, the driver probes successfully.
Signed-off-by: Dang Huynh <danct12@riseup.net>
---
drivers/clk/qcom/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
index 1cf1ef70e347..d566fbdebdf9 100644
--- a/drivers/clk/qcom/Kconfig
+++ b/drivers/clk/qcom/Kconfig
@@ -645,6 +645,7 @@ config SM_DISPCC_6350
config SM_GCC_6115
tristate "SM6115 and SM4250 Global Clock Controller"
+ select QCOM_GDSC
help
Support for the global clock controller on SM6115 and SM4250 devices.
Say Y if you want to use peripheral devices such as UART, SPI,
--
2.37.3
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] clk: qcom: sm6115: Select QCOM_GDSC
2022-09-10 17:02 [PATCH] clk: qcom: sm6115: Select QCOM_GDSC Dang Huynh
@ 2022-09-12 13:16 ` Caleb Connolly
2022-09-12 13:32 ` Dmitry Baryshkov
2022-09-12 13:33 ` Dmitry Baryshkov
2022-09-13 22:48 ` Bjorn Andersson
2 siblings, 1 reply; 6+ messages in thread
From: Caleb Connolly @ 2022-09-12 13:16 UTC (permalink / raw)
To: Dang Huynh
Cc: Bjorn Andersson, Andy Gross, Konrad Dybcio, Michael Turquette,
Stephen Boyd, linux-arm-msm, linux-clk, linux-kernel
On 10/09/2022 18:02, Dang Huynh wrote:
> While working on the Fxtec Pro1X device, this error shows up with
> my own minimal configuration:
>
> gcc-sm6115: probe of 1400000.clock-controller failed with error -38
>
> The clock driver depends on CONFIG_QCOM_GDSC and after enabling
> that, the driver probes successfully.
>
> Signed-off-by: Dang Huynh <danct12@riseup.net>
> ---
> drivers/clk/qcom/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
> index 1cf1ef70e347..d566fbdebdf9 100644
> --- a/drivers/clk/qcom/Kconfig
> +++ b/drivers/clk/qcom/Kconfig
> @@ -645,6 +645,7 @@ config SM_DISPCC_6350
>
> config SM_GCC_6115
> tristate "SM6115 and SM4250 Global Clock Controller"
> + select QCOM_GDSC
depends on QCOM_GDSC
> help
> Support for the global clock controller on SM6115 and SM4250 devices.
> Say Y if you want to use peripheral devices such as UART, SPI,
> --
> 2.37.3
>
--
Kind Regards,
Caleb
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] clk: qcom: sm6115: Select QCOM_GDSC
2022-09-12 13:16 ` Caleb Connolly
@ 2022-09-12 13:32 ` Dmitry Baryshkov
2022-09-12 13:42 ` Caleb Connolly
0 siblings, 1 reply; 6+ messages in thread
From: Dmitry Baryshkov @ 2022-09-12 13:32 UTC (permalink / raw)
To: Caleb Connolly
Cc: Dang Huynh, Bjorn Andersson, Andy Gross, Konrad Dybcio,
Michael Turquette, Stephen Boyd, linux-arm-msm, linux-clk,
linux-kernel
On Mon, 12 Sept 2022 at 16:17, Caleb Connolly <caleb@connolly.tech> wrote:
>
>
>
> On 10/09/2022 18:02, Dang Huynh wrote:
> > While working on the Fxtec Pro1X device, this error shows up with
> > my own minimal configuration:
> >
> > gcc-sm6115: probe of 1400000.clock-controller failed with error -38
> >
> > The clock driver depends on CONFIG_QCOM_GDSC and after enabling
> > that, the driver probes successfully.
> >
> > Signed-off-by: Dang Huynh <danct12@riseup.net>
> > ---
> > drivers/clk/qcom/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
> > index 1cf1ef70e347..d566fbdebdf9 100644
> > --- a/drivers/clk/qcom/Kconfig
> > +++ b/drivers/clk/qcom/Kconfig
> > @@ -645,6 +645,7 @@ config SM_DISPCC_6350
> >
> > config SM_GCC_6115
> > tristate "SM6115 and SM4250 Global Clock Controller"
> > + select QCOM_GDSC
>
> depends on QCOM_GDSC
All other Qualcomm clock drivers select the GDSC if required, so I'd
tend to disagree.
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] clk: qcom: sm6115: Select QCOM_GDSC
2022-09-12 13:32 ` Dmitry Baryshkov
@ 2022-09-12 13:42 ` Caleb Connolly
0 siblings, 0 replies; 6+ messages in thread
From: Caleb Connolly @ 2022-09-12 13:42 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Dang Huynh, Bjorn Andersson, Andy Gross, Konrad Dybcio,
Michael Turquette, Stephen Boyd, linux-arm-msm, linux-clk,
linux-kernel
On 12/09/2022 14:32, Dmitry Baryshkov wrote:
> On Mon, 12 Sept 2022 at 16:17, Caleb Connolly <caleb@connolly.tech> wrote:
>>
>>
>>
>> On 10/09/2022 18:02, Dang Huynh wrote:
>>> While working on the Fxtec Pro1X device, this error shows up with
>>> my own minimal configuration:
>>>
>>> gcc-sm6115: probe of 1400000.clock-controller failed with error -38
>>>
>>> The clock driver depends on CONFIG_QCOM_GDSC and after enabling
>>> that, the driver probes successfully.
>>>
>>> Signed-off-by: Dang Huynh <danct12@riseup.net>
>>> ---
>>> drivers/clk/qcom/Kconfig | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
>>> index 1cf1ef70e347..d566fbdebdf9 100644
>>> --- a/drivers/clk/qcom/Kconfig
>>> +++ b/drivers/clk/qcom/Kconfig
>>> @@ -645,6 +645,7 @@ config SM_DISPCC_6350
>>>
>>> config SM_GCC_6115
>>> tristate "SM6115 and SM4250 Global Clock Controller"
>>> + select QCOM_GDSC
>>
>> depends on QCOM_GDSC
>
> All other Qualcomm clock drivers select the GDSC if required, so I'd
> tend to disagree.
Ah, in that case please disregard, sorry for the noise.
>
>
> --
> With best wishes
> Dmitry
--
Kind Regards,
Caleb
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] clk: qcom: sm6115: Select QCOM_GDSC
2022-09-10 17:02 [PATCH] clk: qcom: sm6115: Select QCOM_GDSC Dang Huynh
2022-09-12 13:16 ` Caleb Connolly
@ 2022-09-12 13:33 ` Dmitry Baryshkov
2022-09-13 22:48 ` Bjorn Andersson
2 siblings, 0 replies; 6+ messages in thread
From: Dmitry Baryshkov @ 2022-09-12 13:33 UTC (permalink / raw)
To: Dang Huynh
Cc: Bjorn Andersson, Andy Gross, Konrad Dybcio, Michael Turquette,
Stephen Boyd, linux-arm-msm, linux-clk, linux-kernel
On Sat, 10 Sept 2022 at 20:02, Dang Huynh <danct12@riseup.net> wrote:
>
> While working on the Fxtec Pro1X device, this error shows up with
> my own minimal configuration:
>
> gcc-sm6115: probe of 1400000.clock-controller failed with error -38
>
> The clock driver depends on CONFIG_QCOM_GDSC and after enabling
> that, the driver probes successfully.
>
> Signed-off-by: Dang Huynh <danct12@riseup.net>
Fixes: cbe63bfdc54f ("clk: qcom: Add Global Clock controller (GCC)
driver for SM6115")
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> drivers/clk/qcom/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] clk: qcom: sm6115: Select QCOM_GDSC
2022-09-10 17:02 [PATCH] clk: qcom: sm6115: Select QCOM_GDSC Dang Huynh
2022-09-12 13:16 ` Caleb Connolly
2022-09-12 13:33 ` Dmitry Baryshkov
@ 2022-09-13 22:48 ` Bjorn Andersson
2 siblings, 0 replies; 6+ messages in thread
From: Bjorn Andersson @ 2022-09-13 22:48 UTC (permalink / raw)
To: danct12
Cc: linux-kernel, mturquette, agross, sboyd, konrad.dybcio,
linux-arm-msm, linux-clk
On Sun, 11 Sep 2022 00:02:07 +0700, Dang Huynh wrote:
> While working on the Fxtec Pro1X device, this error shows up with
> my own minimal configuration:
>
> gcc-sm6115: probe of 1400000.clock-controller failed with error -38
>
> The clock driver depends on CONFIG_QCOM_GDSC and after enabling
> that, the driver probes successfully.
>
> [...]
Applied, thanks!
[1/1] clk: qcom: sm6115: Select QCOM_GDSC
commit: 50ee65dc512b9b5c4de354cf3b4dded34f46c571
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-09-13 22:48 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-10 17:02 [PATCH] clk: qcom: sm6115: Select QCOM_GDSC Dang Huynh
2022-09-12 13:16 ` Caleb Connolly
2022-09-12 13:32 ` Dmitry Baryshkov
2022-09-12 13:42 ` Caleb Connolly
2022-09-12 13:33 ` Dmitry Baryshkov
2022-09-13 22:48 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox