* [PATCH v2] clk: qcom: rpmh: add support for SM6350 rpmh IPA clock
@ 2022-12-02 22:12 Alex Elder
2022-12-02 23:59 ` Konrad Dybcio
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Alex Elder @ 2022-12-02 22:12 UTC (permalink / raw)
To: sboyd, mturquette, andersson, konrad.dybcio, agross
Cc: Luca Weiss, dmitry.baryshkov, linux-arm-msm, linux-clk,
linux-kernel
From: Luca Weiss <luca.weiss@fairphone.com>
The IPA core clock is required for SM6350. Define it.
[elder@linaro.org: rebased with Dmitry's changes]
Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
v2: This is now based on qualcomm/for-next.
drivers/clk/qcom/clk-rpmh.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/qcom/clk-rpmh.c b/drivers/clk/qcom/clk-rpmh.c
index 2c2ef4b6d130e..586a810c682ca 100644
--- a/drivers/clk/qcom/clk-rpmh.c
+++ b/drivers/clk/qcom/clk-rpmh.c
@@ -606,6 +606,7 @@ static struct clk_hw *sm6350_rpmh_clocks[] = {
[RPMH_LN_BB_CLK3_A] = &clk_rpmh_ln_bb_clk3_g4_ao.hw,
[RPMH_QLINK_CLK] = &clk_rpmh_qlink_div4.hw,
[RPMH_QLINK_CLK_A] = &clk_rpmh_qlink_div4_ao.hw,
+ [RPMH_IPA_CLK] = &clk_rpmh_ipa.hw,
};
static const struct clk_rpmh_desc clk_rpmh_sm6350 = {
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v2] clk: qcom: rpmh: add support for SM6350 rpmh IPA clock
2022-12-02 22:12 [PATCH v2] clk: qcom: rpmh: add support for SM6350 rpmh IPA clock Alex Elder
@ 2022-12-02 23:59 ` Konrad Dybcio
2022-12-05 22:56 ` Bjorn Andersson
2022-12-07 15:54 ` Bjorn Andersson
2 siblings, 0 replies; 6+ messages in thread
From: Konrad Dybcio @ 2022-12-02 23:59 UTC (permalink / raw)
To: Alex Elder, sboyd, mturquette, andersson, agross
Cc: Luca Weiss, dmitry.baryshkov, linux-arm-msm, linux-clk,
linux-kernel
On 2.12.2022 23:12, Alex Elder wrote:
> From: Luca Weiss <luca.weiss@fairphone.com>
>
> The IPA core clock is required for SM6350. Define it.
>
> [elder@linaro.org: rebased with Dmitry's changes]
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> v2: This is now based on qualcomm/for-next.
>
> drivers/clk/qcom/clk-rpmh.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/qcom/clk-rpmh.c b/drivers/clk/qcom/clk-rpmh.c
> index 2c2ef4b6d130e..586a810c682ca 100644
> --- a/drivers/clk/qcom/clk-rpmh.c
> +++ b/drivers/clk/qcom/clk-rpmh.c
> @@ -606,6 +606,7 @@ static struct clk_hw *sm6350_rpmh_clocks[] = {
> [RPMH_LN_BB_CLK3_A] = &clk_rpmh_ln_bb_clk3_g4_ao.hw,
> [RPMH_QLINK_CLK] = &clk_rpmh_qlink_div4.hw,
> [RPMH_QLINK_CLK_A] = &clk_rpmh_qlink_div4_ao.hw,
> + [RPMH_IPA_CLK] = &clk_rpmh_ipa.hw,
> };
>
> static const struct clk_rpmh_desc clk_rpmh_sm6350 = {
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2] clk: qcom: rpmh: add support for SM6350 rpmh IPA clock
2022-12-02 22:12 [PATCH v2] clk: qcom: rpmh: add support for SM6350 rpmh IPA clock Alex Elder
2022-12-02 23:59 ` Konrad Dybcio
@ 2022-12-05 22:56 ` Bjorn Andersson
2022-12-06 3:05 ` Alex Elder
2022-12-07 15:54 ` Bjorn Andersson
2 siblings, 1 reply; 6+ messages in thread
From: Bjorn Andersson @ 2022-12-05 22:56 UTC (permalink / raw)
To: Alex Elder
Cc: sboyd, mturquette, konrad.dybcio, agross, Luca Weiss,
dmitry.baryshkov, linux-arm-msm, linux-clk, linux-kernel
On Fri, Dec 02, 2022 at 04:12:40PM -0600, Alex Elder wrote:
> From: Luca Weiss <luca.weiss@fairphone.com>
>
> The IPA core clock is required for SM6350. Define it.
>
> [elder@linaro.org: rebased with Dmitry's changes]
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
Thanks for rebasing this Alex. But as you're handling the patch you need
to add your S-o-b; which will make sure your [] makes sense as well.
Regards,
Bjorn
> ---
> v2: This is now based on qualcomm/for-next.
>
> drivers/clk/qcom/clk-rpmh.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/qcom/clk-rpmh.c b/drivers/clk/qcom/clk-rpmh.c
> index 2c2ef4b6d130e..586a810c682ca 100644
> --- a/drivers/clk/qcom/clk-rpmh.c
> +++ b/drivers/clk/qcom/clk-rpmh.c
> @@ -606,6 +606,7 @@ static struct clk_hw *sm6350_rpmh_clocks[] = {
> [RPMH_LN_BB_CLK3_A] = &clk_rpmh_ln_bb_clk3_g4_ao.hw,
> [RPMH_QLINK_CLK] = &clk_rpmh_qlink_div4.hw,
> [RPMH_QLINK_CLK_A] = &clk_rpmh_qlink_div4_ao.hw,
> + [RPMH_IPA_CLK] = &clk_rpmh_ipa.hw,
> };
>
> static const struct clk_rpmh_desc clk_rpmh_sm6350 = {
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2] clk: qcom: rpmh: add support for SM6350 rpmh IPA clock
2022-12-05 22:56 ` Bjorn Andersson
@ 2022-12-06 3:05 ` Alex Elder
2022-12-06 18:30 ` Bjorn Andersson
0 siblings, 1 reply; 6+ messages in thread
From: Alex Elder @ 2022-12-06 3:05 UTC (permalink / raw)
To: Bjorn Andersson, Alex Elder
Cc: sboyd, mturquette, konrad.dybcio, agross, Luca Weiss,
dmitry.baryshkov, linux-arm-msm, linux-clk, linux-kernel
On 12/5/22 4:56 PM, Bjorn Andersson wrote:
> On Fri, Dec 02, 2022 at 04:12:40PM -0600, Alex Elder wrote:
>> From: Luca Weiss <luca.weiss@fairphone.com>
>>
>> The IPA core clock is required for SM6350. Define it.
>>
>> [elder@linaro.org: rebased with Dmitry's changes]
>> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
Sorry about that, I knew I was supposed to sign
off and thought I had.
You told me separately that this was sufficient:
Signed-off-by: Alex Elder <elder@linaro.org>
If you want me to send a new version with the
signoff just let me know. Thanks.
-Alex
>
> Thanks for rebasing this Alex. But as you're handling the patch you need
> to add your S-o-b; which will make sure your [] makes sense as well.
>
> Regards,
> Bjorn
>
>> ---
>> v2: This is now based on qualcomm/for-next.
>>
>> drivers/clk/qcom/clk-rpmh.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/clk/qcom/clk-rpmh.c b/drivers/clk/qcom/clk-rpmh.c
>> index 2c2ef4b6d130e..586a810c682ca 100644
>> --- a/drivers/clk/qcom/clk-rpmh.c
>> +++ b/drivers/clk/qcom/clk-rpmh.c
>> @@ -606,6 +606,7 @@ static struct clk_hw *sm6350_rpmh_clocks[] = {
>> [RPMH_LN_BB_CLK3_A] = &clk_rpmh_ln_bb_clk3_g4_ao.hw,
>> [RPMH_QLINK_CLK] = &clk_rpmh_qlink_div4.hw,
>> [RPMH_QLINK_CLK_A] = &clk_rpmh_qlink_div4_ao.hw,
>> + [RPMH_IPA_CLK] = &clk_rpmh_ipa.hw,
>> };
>>
>> static const struct clk_rpmh_desc clk_rpmh_sm6350 = {
>> --
>> 2.34.1
>>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2] clk: qcom: rpmh: add support for SM6350 rpmh IPA clock
2022-12-06 3:05 ` Alex Elder
@ 2022-12-06 18:30 ` Bjorn Andersson
0 siblings, 0 replies; 6+ messages in thread
From: Bjorn Andersson @ 2022-12-06 18:30 UTC (permalink / raw)
To: Alex Elder
Cc: Alex Elder, sboyd, mturquette, konrad.dybcio, agross, Luca Weiss,
dmitry.baryshkov, linux-arm-msm, linux-clk, linux-kernel
On Mon, Dec 05, 2022 at 09:05:30PM -0600, Alex Elder wrote:
> On 12/5/22 4:56 PM, Bjorn Andersson wrote:
> > On Fri, Dec 02, 2022 at 04:12:40PM -0600, Alex Elder wrote:
> > > From: Luca Weiss <luca.weiss@fairphone.com>
> > >
> > > The IPA core clock is required for SM6350. Define it.
> > >
> > > [elder@linaro.org: rebased with Dmitry's changes]
> > > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
>
> Sorry about that, I knew I was supposed to sign
> off and thought I had.
>
> You told me separately that this was sufficient:
>
> Signed-off-by: Alex Elder <elder@linaro.org>
>
> If you want me to send a new version with the
> signoff just let me know. Thanks.
>
That works fine, thank you.
Bjorn
> -Alex
> >
> > Thanks for rebasing this Alex. But as you're handling the patch you need
> > to add your S-o-b; which will make sure your [] makes sense as well.
> >
> > Regards,
> > Bjorn
> >
> > > ---
> > > v2: This is now based on qualcomm/for-next.
> > >
> > > drivers/clk/qcom/clk-rpmh.c | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/clk/qcom/clk-rpmh.c b/drivers/clk/qcom/clk-rpmh.c
> > > index 2c2ef4b6d130e..586a810c682ca 100644
> > > --- a/drivers/clk/qcom/clk-rpmh.c
> > > +++ b/drivers/clk/qcom/clk-rpmh.c
> > > @@ -606,6 +606,7 @@ static struct clk_hw *sm6350_rpmh_clocks[] = {
> > > [RPMH_LN_BB_CLK3_A] = &clk_rpmh_ln_bb_clk3_g4_ao.hw,
> > > [RPMH_QLINK_CLK] = &clk_rpmh_qlink_div4.hw,
> > > [RPMH_QLINK_CLK_A] = &clk_rpmh_qlink_div4_ao.hw,
> > > + [RPMH_IPA_CLK] = &clk_rpmh_ipa.hw,
> > > };
> > > static const struct clk_rpmh_desc clk_rpmh_sm6350 = {
> > > --
> > > 2.34.1
> > >
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] clk: qcom: rpmh: add support for SM6350 rpmh IPA clock
2022-12-02 22:12 [PATCH v2] clk: qcom: rpmh: add support for SM6350 rpmh IPA clock Alex Elder
2022-12-02 23:59 ` Konrad Dybcio
2022-12-05 22:56 ` Bjorn Andersson
@ 2022-12-07 15:54 ` Bjorn Andersson
2 siblings, 0 replies; 6+ messages in thread
From: Bjorn Andersson @ 2022-12-07 15:54 UTC (permalink / raw)
To: mturquette, konrad.dybcio, elder, agross, sboyd
Cc: linux-kernel, luca.weiss, linux-clk, linux-arm-msm,
dmitry.baryshkov
On Fri, 2 Dec 2022 16:12:40 -0600, Alex Elder wrote:
> From: Luca Weiss <luca.weiss@fairphone.com>
>
> The IPA core clock is required for SM6350. Define it.
>
> [elder@linaro.org: rebased with Dmitry's changes]
>
>
> [...]
Applied, thanks!
[1/1] clk: qcom: rpmh: add support for SM6350 rpmh IPA clock
commit: 2931aa6758da9f871b4bd7ee52a4be2f9d24e6ce
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-12-07 15:54 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-02 22:12 [PATCH v2] clk: qcom: rpmh: add support for SM6350 rpmh IPA clock Alex Elder
2022-12-02 23:59 ` Konrad Dybcio
2022-12-05 22:56 ` Bjorn Andersson
2022-12-06 3:05 ` Alex Elder
2022-12-06 18:30 ` Bjorn Andersson
2022-12-07 15:54 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox