Linux clock framework development
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Devi Priya <quic_devipriy@quicinc.com>
Cc: rafal@milecki.pl, agross@kernel.org,
	linux-kernel@vger.kernel.org, mturquette@baylibre.com,
	richardcochran@gmail.com, p.zabel@pengutronix.de,
	catalin.marinas@arm.com, will@kernel.org, conor+dt@kernel.org,
	nfraprado@collabora.com, quic_saahtoma@quicinc.com,
	sboyd@kernel.org, konrad.dybcio@linaro.org,
	linux-arm-msm@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org,
	devicetree@vger.kernel.org, robh+dt@kernel.org,
	linux-clk@vger.kernel.org, arnd@arndb.de, andersson@kernel.org,
	linux-arm-kernel@lists.infradead.org, peng.fan@nxp.com,
	netdev@vger.kernel.org, geert+renesas@glider.be
Subject: Re: [PATCH V2 4/7] dt-bindings: clock: Add ipq9574 NSSCC clock and reset definitions
Date: Fri, 25 Aug 2023 05:14:46 -0500	[thread overview]
Message-ID: <169295848663.2559800.3580053610150304724.robh@kernel.org> (raw)
In-Reply-To: <20230825091234.32713-5-quic_devipriy@quicinc.com>


On Fri, 25 Aug 2023 14:42:31 +0530, Devi Priya wrote:
> Add NSSCC clock and reset definitions for ipq9574.
> 
> Signed-off-by: Devi Priya <quic_devipriy@quicinc.com>
> ---
>  Changes in V2:
> 	- Referenced gcc.yaml and dropped the duplicate properties from
> 	  the binding
> 	- Updated Uniphy clock names
> 	- Added nssnoc clocks and clock-names
> 
>  .../bindings/clock/qcom,ipq9574-nsscc.yaml    | 107 ++++++++++++
>  .../dt-bindings/clock/qcom,ipq9574-nsscc.h    | 152 ++++++++++++++++++
>  .../dt-bindings/reset/qcom,ipq9574-nsscc.h    | 134 +++++++++++++++
>  3 files changed, 393 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml
>  create mode 100644 include/dt-bindings/clock/qcom,ipq9574-nsscc.h
>  create mode 100644 include/dt-bindings/reset/qcom,ipq9574-nsscc.h
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Error: Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.example.dts:28.26-27 syntax error
FATAL ERROR: Unable to parse input tree
make[2]: *** [scripts/Makefile.lib:419: Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1500: dt_binding_check] Error 2
make: *** [Makefile:234: __sub-make] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230825091234.32713-5-quic_devipriy@quicinc.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  reply	other threads:[~2023-08-25 10:16 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-25  9:12 [PATCH V2 0/7] Add NSS clock controller support for IPQ9574 Devi Priya
2023-08-25  9:12 ` [PATCH V2 1/7] clk: qcom: clk-alpha-pll: Add NSS HUAYRA ALPHA PLL support for ipq9574 Devi Priya
2023-08-25 20:58   ` Stephen Boyd
2023-08-29  3:28     ` Devi Priya
2023-08-25  9:12 ` [PATCH V2 2/7] dt-bindings: clock: gcc-ipq9574: Add definition for GPLL0_OUT_AUX Devi Priya
2023-08-25 12:27   ` Krzysztof Kozlowski
2023-08-25 12:28   ` Krzysztof Kozlowski
2023-08-25  9:12 ` [PATCH V2 3/7] clk: qcom: gcc-ipq9574: Add gpll0_out_aux clock Devi Priya
2023-09-01 16:15   ` Kathiravan T
2023-08-25  9:12 ` [PATCH V2 4/7] dt-bindings: clock: Add ipq9574 NSSCC clock and reset definitions Devi Priya
2023-08-25 10:14   ` Rob Herring [this message]
2023-08-25 12:30   ` Krzysztof Kozlowski
2023-09-13  8:28     ` Krzysztof Kozlowski
2023-08-25  9:12 ` [PATCH V2 5/7] clk: qcom: Add NSS clock Controller driver for IPQ9574 Devi Priya
2023-08-25 11:44   ` Dmitry Baryshkov
2023-09-12 14:08     ` Devi Priya
2023-09-20  6:39       ` Devi Priya
2023-09-20  8:20         ` Dmitry Baryshkov
2023-09-22 12:01           ` Devi Priya
2023-10-05  6:25             ` Devi Priya
2023-10-05  7:19               ` Dmitry Baryshkov
2023-10-05  9:56                 ` Devi Priya
2023-10-06 21:21                   ` Dmitry Baryshkov
2023-10-17 20:48                     ` Devi Priya
2023-08-28 12:35   ` Konrad Dybcio
2023-08-29  3:42     ` Devi Priya
2023-08-25  9:12 ` [PATCH V2 6/7] arm64: dts: qcom: ipq9574: Add support for nsscc node Devi Priya
2023-08-25 11:28   ` Dmitry Baryshkov
2023-09-13  3:32     ` Devi Priya
2023-09-13  8:23     ` Geert Uytterhoeven
2023-09-13  8:26       ` Krzysztof Kozlowski
2023-09-13  8:38         ` Geert Uytterhoeven
2023-09-13  8:43           ` Konrad Dybcio
2023-09-13  8:55           ` Krzysztof Kozlowski
2023-08-25  9:12 ` [PATCH V2 7/7] arm64: defconfig: Build NSS Clock Controller driver for IPQ9574 Devi Priya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=169295848663.2559800.3580053610150304724.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=arnd@arndb.de \
    --cc=catalin.marinas@arm.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=netdev@vger.kernel.org \
    --cc=nfraprado@collabora.com \
    --cc=p.zabel@pengutronix.de \
    --cc=peng.fan@nxp.com \
    --cc=quic_devipriy@quicinc.com \
    --cc=quic_saahtoma@quicinc.com \
    --cc=rafal@milecki.pl \
    --cc=richardcochran@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox