From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Devi Priya <quic_devipriy@quicinc.com>,
andersson@kernel.org, agross@kernel.org, mturquette@baylibre.com,
sboyd@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
catalin.marinas@arm.com, will@kernel.org, p.zabel@pengutronix.de,
richardcochran@gmail.com, arnd@arndb.de, geert+renesas@glider.be,
nfraprado@collabora.com, rafal@milecki.pl, peng.fan@nxp.com,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
quic_saahtoma@quicinc.com
Subject: Re: [PATCH V2 6/7] arm64: dts: qcom: ipq9574: Add support for nsscc node
Date: Wed, 13 Sep 2023 10:43:34 +0200 [thread overview]
Message-ID: <3260f0ca-9e27-4920-8415-7f364dff773d@linaro.org> (raw)
In-Reply-To: <CAMuHMdVxykGwyrKKSHBv9AHy4gAeH7DT7caZarbs-F40zz5Jpw@mail.gmail.com>
On 13.09.2023 10:38, Geert Uytterhoeven wrote:
> Hi Krzysztof,
>
> On Wed, Sep 13, 2023 at 10:26 AM Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>> On 13/09/2023 10:23, Geert Uytterhoeven wrote:
>>>>
>>>>> + clock-names = "nssnoc_nsscc", "nssnoc_snoc", "nssnoc_snoc_1",
>>>>> + "bias_pll_cc_clk", "bias_pll_nss_noc_clk",
>>>>> + "bias_pll_ubi_nc_clk", "gpll0_out_aux", "uniphy0_nss_rx_clk",
>>>>> + "uniphy0_nss_tx_clk", "uniphy1_nss_rx_clk",
>>>>> + "uniphy1_nss_tx_clk", "uniphy2_nss_rx_clk",
>>>>> + "uniphy2_nss_tx_clk", "xo_board_clk";
>>>>
>>>> You are using clock indices. Please drop clock-names.
>>>
>>> What do you mean by "using clock indices"?
>>> Note that the "clock-names" property is required according to the DT bindings.
>>
>> Indeed, thanks for pointing this out. Probably bindings should be changed.
>
> But what's so great about not having "clock-names"?
> There are _14_ input clocks.
clk_parent_data has an "index" member, which lets us bind
clocks[n] to parent[n]. With the DT properties being ABI,
including the order of entries within, that lets us get rid
of clock-names and the matching is marginally faster.
Konrad
next prev parent reply other threads:[~2023-09-13 8:43 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-25 9:12 [PATCH V2 0/7] Add NSS clock controller support for IPQ9574 Devi Priya
2023-08-25 9:12 ` [PATCH V2 1/7] clk: qcom: clk-alpha-pll: Add NSS HUAYRA ALPHA PLL support for ipq9574 Devi Priya
2023-08-25 20:58 ` Stephen Boyd
2023-08-29 3:28 ` Devi Priya
2023-08-25 9:12 ` [PATCH V2 2/7] dt-bindings: clock: gcc-ipq9574: Add definition for GPLL0_OUT_AUX Devi Priya
2023-08-25 12:27 ` Krzysztof Kozlowski
2023-08-25 12:28 ` Krzysztof Kozlowski
2023-08-25 9:12 ` [PATCH V2 3/7] clk: qcom: gcc-ipq9574: Add gpll0_out_aux clock Devi Priya
2023-09-01 16:15 ` Kathiravan T
2023-08-25 9:12 ` [PATCH V2 4/7] dt-bindings: clock: Add ipq9574 NSSCC clock and reset definitions Devi Priya
2023-08-25 10:14 ` Rob Herring
2023-08-25 12:30 ` Krzysztof Kozlowski
2023-09-13 8:28 ` Krzysztof Kozlowski
2023-08-25 9:12 ` [PATCH V2 5/7] clk: qcom: Add NSS clock Controller driver for IPQ9574 Devi Priya
2023-08-25 11:44 ` Dmitry Baryshkov
2023-09-12 14:08 ` Devi Priya
2023-09-20 6:39 ` Devi Priya
2023-09-20 8:20 ` Dmitry Baryshkov
2023-09-22 12:01 ` Devi Priya
2023-10-05 6:25 ` Devi Priya
2023-10-05 7:19 ` Dmitry Baryshkov
2023-10-05 9:56 ` Devi Priya
2023-10-06 21:21 ` Dmitry Baryshkov
2023-10-17 20:48 ` Devi Priya
2023-08-28 12:35 ` Konrad Dybcio
2023-08-29 3:42 ` Devi Priya
2023-08-25 9:12 ` [PATCH V2 6/7] arm64: dts: qcom: ipq9574: Add support for nsscc node Devi Priya
2023-08-25 11:28 ` Dmitry Baryshkov
2023-09-13 3:32 ` Devi Priya
2023-09-13 8:23 ` Geert Uytterhoeven
2023-09-13 8:26 ` Krzysztof Kozlowski
2023-09-13 8:38 ` Geert Uytterhoeven
2023-09-13 8:43 ` Konrad Dybcio [this message]
2023-09-13 8:55 ` Krzysztof Kozlowski
2023-08-25 9:12 ` [PATCH V2 7/7] arm64: defconfig: Build NSS Clock Controller driver for IPQ9574 Devi Priya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3260f0ca-9e27-4920-8415-7f364dff773d@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=netdev@vger.kernel.org \
--cc=nfraprado@collabora.com \
--cc=p.zabel@pengutronix.de \
--cc=peng.fan@nxp.com \
--cc=quic_devipriy@quicinc.com \
--cc=quic_saahtoma@quicinc.com \
--cc=rafal@milecki.pl \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox