From: "Rob Herring (Arm)" <robh@kernel.org>
To: John Madieu <john.madieu.xa@bp.renesas.com>
Cc: linux-clk@vger.kernel.org, biju.das.jz@bp.renesas.com,
john.madieu@gmail.com, linux-renesas-soc@vger.kernel.org,
kwilczynski@kernel.org, lpieralisi@kernel.org, mani@kernel.org,
bhelgaas@google.com, magnus.damm@gmail.com,
devicetree@vger.kernel.org, linux-pci@vger.kernel.org,
geert+renesas@glider.be, claudiu.beznea.uj@bp.renesas.com,
krzk+dt@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v2 06/15] dt-bindings: PCI: renesas,r9a08g045s33-pcie: Document RZ/G3E SoC
Date: Fri, 23 Jan 2026 09:38:31 -0600 [thread overview]
Message-ID: <176918271191.2157131.3302295737226885391.robh@kernel.org> (raw)
In-Reply-To: <20260123140031.94752-7-john.madieu.xa@bp.renesas.com>
On Fri, 23 Jan 2026 15:00:22 +0100, John Madieu wrote:
> Extend the existing device tree bindings for Renesas RZ/G3S PCIe
> controller to include support for the RZ/G3E (renesas,r9a09g047e57-pcie) PCIe
> controller. The RZ/G3E PCIe controller is similar to RZ/G3S but has some key
> differences:
>
> - Uses a different device ID
> - Supports PCIe Gen3 (8.0 GT/s) link speeds
> - Uses a different clock naming (clkpmu vs clkl1pm)
> - Has a different set of interrupts, interrupt ordering, and reset signals
>
> Add device tree bindings for renesas,r9a09g047e57-pcie compatible IPs.
>
> Signed-off-by: John Madieu <john.madieu.xa@bp.renesas.com>
> ---
>
> Changes:
>
> v2: Reuse G3S names
>
> .../bindings/pci/renesas,r9a08g045-pcie.yaml | 127 +++++++++++++-----
> 1 file changed, 96 insertions(+), 31 deletions(-)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/renesas,r9a08g045-pcie.yaml: properties:reset-names: {'minItems': 1, 'maxItems': 7, 'items': [{'const': 'aresetn'}, {'const': 'rst_b'}, {'const': 'rst_gp_b'}, {'const': 'rst_ps_b'}, {'const': 'rst_rsm_b'}, {'const': 'rst_cfg_b'}, {'const': 'rst_load_b'}]} should not be valid under {'required': ['maxItems']}
hint: "maxItems" is not needed with an "items" list
from schema $id: http://devicetree.org/meta-schemas/items.yaml
doc reference errors (make refcheckdocs):
See https://patchwork.kernel.org/project/devicetree/patch/20260123140031.94752-7-john.madieu.xa@bp.renesas.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2026-01-23 15:38 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-23 14:00 [PATCH v2 00/15] PCI: renesas: Add RZ/G3E PCIe controller support John Madieu
2026-01-23 14:00 ` [PATCH v2 01/15] PCI: rzg3s-host: Fix reset handling in probe error path John Madieu
2026-01-23 14:00 ` [PATCH v2 02/15] PCI: renesas: rzg3s: Rework inbound window algorithm for multi-SoC support John Madieu
2026-01-23 14:00 ` [PATCH v2 03/15] clk: renesas: rzv2h-cpg: Add support for init_{off|asserted} clocks/resets John Madieu
2026-01-23 14:42 ` Geert Uytterhoeven
2026-01-23 14:00 ` [PATCH v2 04/15] clk: renesas: r9a09g047: Add PCIe clocks and reset John Madieu
2026-01-23 14:36 ` Geert Uytterhoeven
2026-01-23 14:00 ` [PATCH v2 05/15] dt-bindings: PCI: renesas,r9a08g045s33-pcie: Fix typo in interrupt-names John Madieu
2026-01-23 14:17 ` Geert Uytterhoeven
2026-01-23 14:36 ` John Madieu
2026-01-23 14:00 ` [PATCH v2 06/15] dt-bindings: PCI: renesas,r9a08g045s33-pcie: Document RZ/G3E SoC John Madieu
2026-01-23 14:22 ` Biju Das
2026-01-23 15:16 ` John Madieu
2026-01-23 15:38 ` Rob Herring (Arm) [this message]
2026-01-26 14:31 ` Rob Herring
2026-01-26 16:46 ` John Madieu
2026-01-26 16:55 ` Biju Das
2026-01-23 14:00 ` [PATCH v2 07/15] PCI: rzg3s-host: Make SYSC register offsets SoC-specific John Madieu
2026-01-23 14:00 ` [PATCH v2 08/15] PCI: rzg3s-host: Make configuration reset lines optional John Madieu
2026-01-23 14:00 ` [PATCH v2 09/15] PCI: rzg3s-host: Add SoC-specific configuration and initialization callbacks John Madieu
2026-01-23 14:00 ` [PATCH v2 10/15] PCI: rzg3s-host: Explicitly set class code for RZ/G3E compatibility John Madieu
2026-01-23 14:00 ` [PATCH v2 11/15] PCI: rzg3s-host: Add PCIe Gen3 (8.0 GT/s) link speed support John Madieu
2026-01-23 14:00 ` [PATCH v2 12/15] PCI: rzg3s-host: Add support for RZ/G3E PCIe controller John Madieu
2026-01-23 14:00 ` [PATCH v2 13/15] arm64: dts: renesas: r9a09g047: Add PCIe node John Madieu
2026-01-23 14:00 ` [PATCH v2 14/15] arm64: dts: renesas: r9a09g047e57-smarc-som: Add PCIe reference clock John Madieu
2026-01-23 14:00 ` [PATCH v2 15/15] arm64: dts: renesas: r9a09g047e57-smarc: Enable PCIe John Madieu
2026-01-23 14:20 ` Biju Das
2026-01-23 16:54 ` John Madieu
2026-01-23 17:02 ` Biju Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176918271191.2157131.3302295737226885391.robh@kernel.org \
--to=robh@kernel.org \
--cc=bhelgaas@google.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=claudiu.beznea.uj@bp.renesas.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=john.madieu.xa@bp.renesas.com \
--cc=john.madieu@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=kwilczynski@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mani@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox