From: John Madieu <john.madieu.xa@bp.renesas.com>
To: claudiu.beznea.uj@bp.renesas.com, lpieralisi@kernel.org,
kwilczynski@kernel.org, mani@kernel.org, geert+renesas@glider.be,
krzk+dt@kernel.org
Cc: robh@kernel.org, bhelgaas@google.com, conor+dt@kernel.org,
magnus.damm@gmail.com, biju.das.jz@bp.renesas.com,
linux-pci@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
john.madieu@gmail.com,
John Madieu <john.madieu.xa@bp.renesas.com>
Subject: [PATCH v2 01/15] PCI: rzg3s-host: Fix reset handling in probe error path
Date: Fri, 23 Jan 2026 15:00:17 +0100 [thread overview]
Message-ID: <20260123140031.94752-2-john.madieu.xa@bp.renesas.com> (raw)
In-Reply-To: <20260123140031.94752-1-john.madieu.xa@bp.renesas.com>
Fix incorrect reset_control_bulk_deassert() call in the probe error
path. When unwinding from a failed pci_host_probe(), the configuration
resets should be asserted to restore the hardware to its initial state,
not deasserted again.
Fixes: 7ef502fb35b2 ("PCI: Add Renesas RZ/G3S host controller driver")
Reviewed-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Signed-off-by: John Madieu <john.madieu.xa@bp.renesas.com>
---
Changes:
v2: Collected Rb tag
drivers/pci/controller/pcie-rzg3s-host.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/pci/controller/pcie-rzg3s-host.c b/drivers/pci/controller/pcie-rzg3s-host.c
index 5aa58638903f..58e78fc52913 100644
--- a/drivers/pci/controller/pcie-rzg3s-host.c
+++ b/drivers/pci/controller/pcie-rzg3s-host.c
@@ -1588,8 +1588,7 @@ static int rzg3s_pcie_probe(struct platform_device *pdev)
host_probe_teardown:
rzg3s_pcie_teardown_irqdomain(host);
- reset_control_bulk_deassert(host->data->num_cfg_resets,
- host->cfg_resets);
+ reset_control_bulk_assert(host->data->num_cfg_resets, host->cfg_resets);
rpm_put:
pm_runtime_put_sync(dev);
rpm_disable:
--
2.25.1
next prev parent reply other threads:[~2026-01-23 14:01 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-23 14:00 [PATCH v2 00/15] PCI: renesas: Add RZ/G3E PCIe controller support John Madieu
2026-01-23 14:00 ` John Madieu [this message]
2026-01-23 14:00 ` [PATCH v2 02/15] PCI: renesas: rzg3s: Rework inbound window algorithm for multi-SoC support John Madieu
2026-01-23 14:00 ` [PATCH v2 03/15] clk: renesas: rzv2h-cpg: Add support for init_{off|asserted} clocks/resets John Madieu
2026-01-23 14:42 ` Geert Uytterhoeven
2026-01-23 14:00 ` [PATCH v2 04/15] clk: renesas: r9a09g047: Add PCIe clocks and reset John Madieu
2026-01-23 14:36 ` Geert Uytterhoeven
2026-01-23 14:00 ` [PATCH v2 05/15] dt-bindings: PCI: renesas,r9a08g045s33-pcie: Fix typo in interrupt-names John Madieu
2026-01-23 14:17 ` Geert Uytterhoeven
2026-01-23 14:36 ` John Madieu
2026-01-23 14:00 ` [PATCH v2 06/15] dt-bindings: PCI: renesas,r9a08g045s33-pcie: Document RZ/G3E SoC John Madieu
2026-01-23 14:22 ` Biju Das
2026-01-23 15:16 ` John Madieu
2026-01-23 15:38 ` Rob Herring (Arm)
2026-01-26 14:31 ` Rob Herring
2026-01-26 16:46 ` John Madieu
2026-01-26 16:55 ` Biju Das
2026-01-23 14:00 ` [PATCH v2 07/15] PCI: rzg3s-host: Make SYSC register offsets SoC-specific John Madieu
2026-01-23 14:00 ` [PATCH v2 08/15] PCI: rzg3s-host: Make configuration reset lines optional John Madieu
2026-01-23 14:00 ` [PATCH v2 09/15] PCI: rzg3s-host: Add SoC-specific configuration and initialization callbacks John Madieu
2026-01-23 14:00 ` [PATCH v2 10/15] PCI: rzg3s-host: Explicitly set class code for RZ/G3E compatibility John Madieu
2026-01-23 14:00 ` [PATCH v2 11/15] PCI: rzg3s-host: Add PCIe Gen3 (8.0 GT/s) link speed support John Madieu
2026-01-23 14:00 ` [PATCH v2 12/15] PCI: rzg3s-host: Add support for RZ/G3E PCIe controller John Madieu
2026-01-23 14:00 ` [PATCH v2 13/15] arm64: dts: renesas: r9a09g047: Add PCIe node John Madieu
2026-01-23 14:00 ` [PATCH v2 14/15] arm64: dts: renesas: r9a09g047e57-smarc-som: Add PCIe reference clock John Madieu
2026-01-23 14:00 ` [PATCH v2 15/15] arm64: dts: renesas: r9a09g047e57-smarc: Enable PCIe John Madieu
2026-01-23 14:20 ` Biju Das
2026-01-23 16:54 ` John Madieu
2026-01-23 17:02 ` Biju Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260123140031.94752-2-john.madieu.xa@bp.renesas.com \
--to=john.madieu.xa@bp.renesas.com \
--cc=bhelgaas@google.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=claudiu.beznea.uj@bp.renesas.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=john.madieu@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=kwilczynski@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mani@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox