Re: [PATCH 1/3] [RFC] PM: domains: Introduce .power_pre/post_on/off callbacks

[Marek Vasut <marex@denx.de>]

On 11/9/22 14:19, Laurent Pinchart wrote:

Hi,

[...]

>> @@ -1413,6 +1479,7 @@ static int genpd_restore_noirq(struct device *dev)
>>   static void genpd_complete(struct device *dev)
>>   {
>>   	struct generic_pm_domain *genpd;
>> +	int ret;
> 
> This variable is unused, causing a compilation error.

I suspect only with -Werror, but anyway, already fixed locally, it's a 
rebase on latest next artifact.

[...]

>> diff --git a/include/linux/pm_domain.h b/include/linux/pm_domain.h
>> index ebc3516980907..3cf231a27cb1b 100644
>> --- a/include/linux/pm_domain.h
>> +++ b/include/linux/pm_domain.h
>> @@ -134,8 +134,12 @@ struct generic_pm_domain {
>>   	unsigned int prepared_count;	/* Suspend counter of prepared devices */
>>   	unsigned int performance_state;	/* Aggregated max performance state */
>>   	cpumask_var_t cpus;		/* A cpumask of the attached CPUs */
>> +	int (*power_off_pre)(struct generic_pm_domain *domain);
>>   	int (*power_off)(struct generic_pm_domain *domain);
>> +	int (*power_off_post)(struct generic_pm_domain *domain);
>> +	int (*power_pre_on)(struct generic_pm_domain *domain);
>>   	int (*power_on)(struct generic_pm_domain *domain);
>> +	int (*power_post_on)(struct generic_pm_domain *domain);
>>   	struct raw_notifier_head power_notifiers; /* Power on/off notifiers */
>>   	struct opp_table *opp_table;	/* OPP table of the genpd */
>>   	unsigned int (*opp_to_performance_state)(struct generic_pm_domain *genpd,

I am looking more for a feedback on this extension of the callbacks, and 
on the overall approach. Is this something which looks OK, or would 
there be better way to handle this ?