public inbox for linux-clk@vger.kernel.org
 help / color / mirror / Atom feed
From: Peng Fan <peng.fan@oss.nxp.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Lucas Stach <l.stach@pengutronix.de>, Marek Vasut <marex@denx.de>,
	linux-pm@vger.kernel.org, Adam Ford <aford173@gmail.com>,
	Fabio Estevam <festevam@denx.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jacky Bai <ping.bai@nxp.com>, Kevin Hilman <khilman@kernel.org>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Len Brown <len.brown@intel.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Martin Kepplinger <martink@posteo.de>,
	Pavel Machek <pavel@ucw.cz>, Peng Fan <peng.fan@nxp.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Shawn Guo <shawnguo@kernel.org>,
	Shengjiu Wang <shengjiu.wang@nxp.com>,
	Stephen Boyd <sboyd@kernel.org>,
	linux-clk@vger.kernel.org, linux-imx@nxp.com,
	Stephen Boyd <swboyd@chromium.org>
Subject: Re: [PATCH 1/3] [RFC] PM: domains: Introduce .power_pre/post_on/off callbacks
Date: Wed, 1 Mar 2023 08:52:15 +0800	[thread overview]
Message-ID: <435300e5-cfad-83a4-990f-94891a40ddfc@oss.nxp.com> (raw)
In-Reply-To: <CAPDyKFrzbpF-F2Quxh4QH_HwGc5MbJ=qOcWb-yGQo+WHYNK6PQ@mail.gmail.com>



On 2/16/2023 6:48 PM, Ulf Hansson wrote:
> On Thu, 16 Feb 2023 at 02:47, Peng Fan <peng.fan@oss.nxp.com> wrote:
>>
>> Hi Ulf,
>>
>> On 1/18/2023 8:55 PM, Ulf Hansson wrote:
>> ...
>>>>
>>>> Honestly I not have idea on how to rework the clk part to avoid holding
>>>> the clk-prepare lock when power on the phy and its power domain.
>>>
>>> I understand. Let me try to prepare a hackish patch that we can use to
>>> run some tests.
>>>
>>> Unfortunately, I can't make any promises for when, but I will do my best.
>>>
>>
>> Have you got time to give a look on this part? Or do you have any
>> suggestions that I could help with?
> 
> I have looked closer at this, but haven't yet got the time to actually
> post a patch. Let me see if I can do some re-prioritization of things
> at my side...
> 
> Anyway, my plan is to post a "hackish" patch that we should use solely
> for testing, to make sure that the approach works. Then, I intend to
> continue to work on the complete solution, which seems to be requiring
> some reworks of locking parts in the clock framework. Although, it's
> too early for me, to say exactly how, so I can't really give you any
> pointers in this regard, sorry.

I overlooked your reply, sorry. Thanks for still working on this.
We have a new SoC has similar design that use blk ctrl which
will need to work as clock controller, while it depends on
power domain. So we will run into same deadlock issue. So I hope
the deadlock issue could be resolved.

Thanks,
Peng.
> 
>>
>> Thanks,
>> Peng.
>>
>>>>
>>>> [1]https://github.com/nxp-imx/linux-imx/commit/c85126180a10439a8c7db1800529b4857d91c609
>>>>
> 
> Kind regards
> Uffe

      reply	other threads:[~2023-03-01  0:52 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-08  1:35 [PATCH 1/3] [RFC] PM: domains: Introduce .power_pre/post_on/off callbacks Marek Vasut
2022-11-08  1:35 ` [PATCH 2/3] [RFC] soc: imx: gpcv2: Split clock prepare from clock enable in the domain Marek Vasut
2022-11-11  8:27   ` Peng Fan
2022-11-08  1:35 ` [PATCH 3/3] [RFC] soc: imx: imx8m-blk-ctrl: " Marek Vasut
2022-11-09 13:19 ` [PATCH 1/3] [RFC] PM: domains: Introduce .power_pre/post_on/off callbacks Laurent Pinchart
2022-11-09 13:25   ` Marek Vasut
2022-11-14 19:40 ` Ulf Hansson
2022-11-14 20:32   ` Marek Vasut
2022-11-16 12:41     ` Ulf Hansson
2022-11-16 13:25       ` Lucas Stach
2022-11-16 16:30         ` Ulf Hansson
2023-01-04  8:37           ` Peng Fan
2023-01-18 12:55             ` Ulf Hansson
2023-01-18 13:07               ` Marek Vasut
2023-02-16  1:47               ` Peng Fan
2023-02-16 10:48                 ` Ulf Hansson
2023-03-01  0:52                   ` Peng Fan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=435300e5-cfad-83a4-990f-94891a40ddfc@oss.nxp.com \
    --to=peng.fan@oss.nxp.com \
    --cc=aford173@gmail.com \
    --cc=broonie@kernel.org \
    --cc=festevam@denx.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel@pengutronix.de \
    --cc=khilman@kernel.org \
    --cc=l.stach@pengutronix.de \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=len.brown@intel.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-pm@vger.kernel.org \
    --cc=marex@denx.de \
    --cc=martink@posteo.de \
    --cc=p.zabel@pengutronix.de \
    --cc=pavel@ucw.cz \
    --cc=peng.fan@nxp.com \
    --cc=ping.bai@nxp.com \
    --cc=rafael@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=sboyd@kernel.org \
    --cc=shawnguo@kernel.org \
    --cc=shengjiu.wang@nxp.com \
    --cc=swboyd@chromium.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox