From: Jerome Brunet <jbrunet@baylibre.com>
To: Jan Dakinevich <jan.dakinevich@salutedevices.com>
Cc: Conor Dooley <conor+dt@kernel.org>, <devicetree@vger.kernel.org>,
Kevin Hilman <khilman@baylibre.com>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
<linux-amlogic@lists.infradead.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-clk@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Michael Turquette <mturquette@baylibre.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Rob Herring <robh@kernel.org>, Stephen Boyd <sboyd@kernel.org>
Subject: Re: [RFC PATCH v4 3/5] dt-bindings: clock: axg-audio: document A1 SoC audio clock controller driver
Date: Tue, 22 Oct 2024 11:36:14 +0200 [thread overview]
Message-ID: <1jv7xkjx81.fsf@starbuckisacylon.baylibre.com> (raw)
In-Reply-To: <1jzfmwjxbp.fsf@starbuckisacylon.baylibre.com> (Jerome Brunet's message of "Tue, 22 Oct 2024 11:34:02 +0200")
On Tue 22 Oct 2024 at 11:34, Jerome Brunet <jbrunet@baylibre.com> wrote:
> On Fri 13 Sep 2024 at 15:11, Jan Dakinevich <jan.dakinevich@salutedevices.com> wrote:
>
>> Add device tree bindings for A1 SoC audio clock and reset controllers.
>>
>> Signed-off-by: Jan Dakinevich <jan.dakinevich@salutedevices.com>
>> ---
>> .../clock/amlogic,axg-audio-clkc.yaml | 3 +
>> .../dt-bindings/clock/amlogic,a1-audio-clkc.h | 122 ++++++++++++++++++
>> .../reset/amlogic,meson-a1-audio-reset.h | 29 +++++
>> 3 files changed, 154 insertions(+)
>> create mode 100644 include/dt-bindings/clock/amlogic,a1-audio-clkc.h
>> create mode 100644 include/dt-bindings/reset/amlogic,meson-a1-audio-reset.h
>>
>> diff --git a/Documentation/devicetree/bindings/clock/amlogic,axg-audio-clkc.yaml b/Documentation/devicetree/bindings/clock/amlogic,axg-audio-clkc.yaml
>> index fd7982dd4cea..df9eb8ce28dc 100644
>> --- a/Documentation/devicetree/bindings/clock/amlogic,axg-audio-clkc.yaml
>> +++ b/Documentation/devicetree/bindings/clock/amlogic,axg-audio-clkc.yaml
>> @@ -18,6 +18,8 @@ description:
>> properties:
>> compatible:
>> enum:
>> + - amlogic,a1-audio-clkc
>
> This controller is missing aud_top clock input coming from the vad
> controller, AFAICT.
>
You are passing it thourgh pclk so it is fine
next prev parent reply other threads:[~2024-10-22 9:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-13 12:11 [RFC PATCH v4 0/5] Add A1 Soc audio clock controller driver Jan Dakinevich
2024-09-13 12:11 ` [RFC PATCH v4 1/5] reset: amlogic: add support for A1 SoC in auxiliary reset driver Jan Dakinevich
2024-10-22 8:42 ` Jerome Brunet
2024-09-13 12:11 ` [RFC PATCH v4 2/5] clk: meson: axg: share the set of audio helper macro Jan Dakinevich
2024-09-13 12:11 ` [RFC PATCH v4 3/5] dt-bindings: clock: axg-audio: document A1 SoC audio clock controller driver Jan Dakinevich
2024-09-13 17:23 ` Conor Dooley
2024-10-22 8:45 ` Jerome Brunet
2024-10-24 4:48 ` Jan Dakinevich
2024-10-22 9:34 ` Jerome Brunet
2024-10-22 9:36 ` Jerome Brunet [this message]
2024-09-13 12:11 ` [RFC PATCH v4 4/5] clk: meson: a1: add the " Jan Dakinevich
2024-09-18 11:05 ` Jan Dakinevich
2024-10-22 9:47 ` Jerome Brunet
2024-10-24 5:15 ` Jan Dakinevich
2024-09-13 12:11 ` [RFC PATCH v4 5/5] arm64: dts: meson: a1: add the audio clock controller Jan Dakinevich
2024-10-07 14:59 ` [RFC PATCH v4 0/5] Add A1 Soc audio clock controller driver Jan Dakinevich
2024-10-22 9:51 ` Jerome Brunet
2024-10-24 5:18 ` Jan Dakinevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1jv7xkjx81.fsf@starbuckisacylon.baylibre.com \
--to=jbrunet@baylibre.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jan.dakinevich@salutedevices.com \
--cc=khilman@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=mturquette@baylibre.com \
--cc=neil.armstrong@linaro.org \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox