Re: [RFC PATCH v4 0/5] Add A1 Soc audio clock controller driver

[Jan Dakinevich <jan.dakinevich@salutedevices.com>]

On 10/22/24 12:51, Jerome Brunet wrote:
> On Fri 13 Sep 2024 at 15:11, Jan Dakinevich <jan.dakinevich@salutedevices.com> wrote:
> 
>> This series adds support for audio clock and reset controllers on A1 SoC family.
>>
> 
> Split the reset part out of the series (I'd suggest adding VAD reset
> support while at it). Also remove the DT patch, since it will depends on
> both patchset.
> 
> Drop the RFC tag, at v4 I think that phase is over.
> 

Jerome, thank you for review.

>> Dependency: [4]
>>
>> Changes v3 [3] -> v4
>>  - Use auxiliary reset device implemented in [4]
>>  - Split the driver into files
>>  - Use common with axg-audio yaml schema
>>  - Unify clock-names with axg-audio
>>
>> Changes v2 [2] -> v3
>>  - reset:
>>    * added auxiliary device
>>  - yaml:
>>    * added declaration of optional clocks
>>    * fixed names in example and another cosmetics
>>  - clocks:
>>    * reworked naming
>>    * stop using of "core" clock name
>>    * fixed wrong parenting
>>
>> Changes v1 [1] -> v2:
>>  - Detached from v1's series (patch 2, 3, 4, 25).
>>  - Reuse some of defines from axg-audio;
>>  - Split the controller into two memory regions.
>>
>> Links:
>>  [1] https://lore.kernel.org/lkml/20240314232201.2102178-1-jan.dakinevich@salutedevices.com/
>>  [2] https://lore.kernel.org/lkml/20240328010831.884487-1-jan.dakinevich@salutedevices.com/
>>  [3] https://lore.kernel.org/lkml/20240419125812.983409-1-jan.dakinevich@salutedevices.com/
>>  [4] https://lore.kernel.org/lkml/9a4377fe27d8eb940399e452b68fb5a6d678929f.camel@pengutronix.de/
>>
>> Jan Dakinevich (5):
>>   reset: amlogic: add support for A1 SoC in auxiliary reset driver
>>   clk: meson: axg: share the set of audio helper macro
>>   dt-bindings: clock: axg-audio: document A1 SoC audio clock controller
>>     driver
>>   clk: meson: a1: add the audio clock controller driver
>>   arm64: dts: meson: a1: add the audio clock controller
>>
>>  .../clock/amlogic,axg-audio-clkc.yaml         |   3 +
>>  arch/arm64/boot/dts/amlogic/meson-a1.dtsi     |  48 +++
>>  drivers/clk/meson/Kconfig                     |  14 +
>>  drivers/clk/meson/Makefile                    |   3 +
>>  drivers/clk/meson/a1-audio-clkc.c             | 359 ++++++++++++++++++
>>  drivers/clk/meson/a1-audio-drv.c              | 104 +++++
>>  drivers/clk/meson/a1-audio-vad-clkc.c         |  85 +++++
>>  drivers/clk/meson/a1-audio.h                  | 131 +++++++
>>  drivers/clk/meson/axg-audio.c                 | 138 +------
>>  drivers/clk/meson/meson-audio.h               | 143 +++++++
>>  drivers/reset/amlogic/reset-meson-aux.c       |   9 +
>>  .../dt-bindings/clock/amlogic,a1-audio-clkc.h | 122 ++++++
>>  .../reset/amlogic,meson-a1-audio-reset.h      |  29 ++
>>  13 files changed, 1051 insertions(+), 137 deletions(-)
>>  create mode 100644 drivers/clk/meson/a1-audio-clkc.c
>>  create mode 100644 drivers/clk/meson/a1-audio-drv.c
>>  create mode 100644 drivers/clk/meson/a1-audio-vad-clkc.c
>>  create mode 100644 drivers/clk/meson/a1-audio.h
>>  create mode 100644 drivers/clk/meson/meson-audio.h
>>  create mode 100644 include/dt-bindings/clock/amlogic,a1-audio-clkc.h
>>  create mode 100644 include/dt-bindings/reset/amlogic,meson-a1-audio-reset.h
> 

-- 
Best regards
Jan Dakinevich