* [PATCH] clk: meson: Kconfig: fix dependency for G12A
@ 2020-11-18 19:09 Kevin Hilman
2020-11-19 16:47 ` Jerome Brunet
0 siblings, 1 reply; 3+ messages in thread
From: Kevin Hilman @ 2020-11-18 19:09 UTC (permalink / raw)
To: Jérôme Brunet, Neil Armstrong; +Cc: linux-clk, linux-amlogic
When building only G12A, ensure that VID_PLL_DIV clock driver is
selected, otherwise results in this build error:
ERROR: modpost: "meson_vid_pll_div_ro_ops" [drivers/clk/meson/g12a.ko] undefined!
Signed-off-by: Kevin Hilman <khilman@baylibre.com>
---
drivers/clk/meson/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/meson/Kconfig b/drivers/clk/meson/Kconfig
index 034da203e8e0..9a8a548d839d 100644
--- a/drivers/clk/meson/Kconfig
+++ b/drivers/clk/meson/Kconfig
@@ -110,6 +110,7 @@ config COMMON_CLK_G12A
select COMMON_CLK_MESON_AO_CLKC
select COMMON_CLK_MESON_EE_CLKC
select COMMON_CLK_MESON_CPU_DYNDIV
+ select COMMON_CLK_MESON_VID_PLL_DIV
select MFD_SYSCON
help
Support for the clock controller on Amlogic S905D2, S905X2 and S905Y2
--
2.28.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: meson: Kconfig: fix dependency for G12A
2020-11-18 19:09 [PATCH] clk: meson: Kconfig: fix dependency for G12A Kevin Hilman
@ 2020-11-19 16:47 ` Jerome Brunet
2020-11-19 16:51 ` Jerome Brunet
0 siblings, 1 reply; 3+ messages in thread
From: Jerome Brunet @ 2020-11-19 16:47 UTC (permalink / raw)
To: Kevin Hilman, Neil Armstrong; +Cc: linux-clk, linux-amlogic
On Wed 18 Nov 2020 at 20:09, Kevin Hilman <khilman@baylibre.com> wrote:
> When building only G12A, ensure that VID_PLL_DIV clock driver is
> selected, otherwise results in this build error:
>
> ERROR: modpost: "meson_vid_pll_div_ro_ops" [drivers/clk/meson/g12a.ko] undefined!
>
> Signed-off-by: Kevin Hilman <khilman@baylibre.com>
Fixes: 085a4ea93d54 ("clk: meson: g12a: add peripheral clock controller")
> ---
> drivers/clk/meson/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/meson/Kconfig b/drivers/clk/meson/Kconfig
> index 034da203e8e0..9a8a548d839d 100644
> --- a/drivers/clk/meson/Kconfig
> +++ b/drivers/clk/meson/Kconfig
> @@ -110,6 +110,7 @@ config COMMON_CLK_G12A
> select COMMON_CLK_MESON_AO_CLKC
> select COMMON_CLK_MESON_EE_CLKC
> select COMMON_CLK_MESON_CPU_DYNDIV
> + select COMMON_CLK_MESON_VID_PLL_DIV
> select MFD_SYSCON
> help
> Support for the clock controller on Amlogic S905D2, S905X2 and S905Y2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: meson: Kconfig: fix dependency for G12A
2020-11-19 16:47 ` Jerome Brunet
@ 2020-11-19 16:51 ` Jerome Brunet
0 siblings, 0 replies; 3+ messages in thread
From: Jerome Brunet @ 2020-11-19 16:51 UTC (permalink / raw)
To: Kevin Hilman, Neil Armstrong; +Cc: linux-clk, linux-amlogic
On Thu 19 Nov 2020 at 17:47, Jerome Brunet <jbrunet@baylibre.com> wrote:
> On Wed 18 Nov 2020 at 20:09, Kevin Hilman <khilman@baylibre.com> wrote:
>
>> When building only G12A, ensure that VID_PLL_DIV clock driver is
>> selected, otherwise results in this build error:
>>
>> ERROR: modpost: "meson_vid_pll_div_ro_ops" [drivers/clk/meson/g12a.ko] undefined!
>>
>> Signed-off-by: Kevin Hilman <khilman@baylibre.com>
>
> Fixes: 085a4ea93d54 ("clk: meson: g12a: add peripheral clock controller")
And applied, Thx
>
>> ---
>> drivers/clk/meson/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/clk/meson/Kconfig b/drivers/clk/meson/Kconfig
>> index 034da203e8e0..9a8a548d839d 100644
>> --- a/drivers/clk/meson/Kconfig
>> +++ b/drivers/clk/meson/Kconfig
>> @@ -110,6 +110,7 @@ config COMMON_CLK_G12A
>> select COMMON_CLK_MESON_AO_CLKC
>> select COMMON_CLK_MESON_EE_CLKC
>> select COMMON_CLK_MESON_CPU_DYNDIV
>> + select COMMON_CLK_MESON_VID_PLL_DIV
>> select MFD_SYSCON
>> help
>> Support for the clock controller on Amlogic S905D2, S905X2 and S905Y2
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-19 16:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-18 19:09 [PATCH] clk: meson: Kconfig: fix dependency for G12A Kevin Hilman
2020-11-19 16:47 ` Jerome Brunet
2020-11-19 16:51 ` Jerome Brunet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox