* [PATCH] clk: shmobile: emev2: annotate smu base pointer
@ 2015-07-06 21:04 Wolfram Sang
2015-07-06 21:48 ` Stephen Boyd
0 siblings, 1 reply; 3+ messages in thread
From: Wolfram Sang @ 2015-07-06 21:04 UTC (permalink / raw)
To: Mike Turquette, Stephen Boyd, linux-clk
Cc: linux-sh, Magnus Damm, Simon Horman, Laurent Pinchart,
Geert Uytterhoeven, Wolfram Sang
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
sparse rightfully says:
drivers/clk/shmobile/clk-emev2.c:39:14: warning: symbol 'smu_base' was not declared. Should it be static?
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
drivers/clk/shmobile/clk-emev2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/shmobile/clk-emev2.c b/drivers/clk/shmobile/clk-emev2.c
index 6c7c929c776557..5b60beb7d0ebce 100644
--- a/drivers/clk/shmobile/clk-emev2.c
+++ b/drivers/clk/shmobile/clk-emev2.c
@@ -34,7 +34,7 @@
static DEFINE_SPINLOCK(lock);
/* not pretty, but hey */
-void __iomem *smu_base;
+static void __iomem *smu_base;
static void __init emev2_smu_write(unsigned long value, int offs)
{
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: shmobile: emev2: annotate smu base pointer
2015-07-06 21:04 [PATCH] clk: shmobile: emev2: annotate smu base pointer Wolfram Sang
@ 2015-07-06 21:48 ` Stephen Boyd
2015-07-06 21:52 ` Wolfram Sang
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Boyd @ 2015-07-06 21:48 UTC (permalink / raw)
To: Wolfram Sang
Cc: Mike Turquette, linux-clk, linux-sh, Magnus Damm, Simon Horman,
Laurent Pinchart, Geert Uytterhoeven
On 07/06, Wolfram Sang wrote:
> From: Wolfram Sang <wsa+renesas@sang-engineering.com>
>
> sparse rightfully says:
>
> drivers/clk/shmobile/clk-emev2.c:39:14: warning: symbol 'smu_base' was not declared. Should it be static?
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
Yep, and it was already fixed and merged
$ git tag -l --contains 43f535702bb2c7b96091c0267fc105d44c18348c v4.*
v4.2-rc1
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: shmobile: emev2: annotate smu base pointer
2015-07-06 21:48 ` Stephen Boyd
@ 2015-07-06 21:52 ` Wolfram Sang
0 siblings, 0 replies; 3+ messages in thread
From: Wolfram Sang @ 2015-07-06 21:52 UTC (permalink / raw)
To: Stephen Boyd
Cc: Mike Turquette, linux-clk, linux-sh, Magnus Damm, Simon Horman,
Laurent Pinchart, Geert Uytterhoeven
[-- Attachment #1: Type: text/plain, Size: 98 bytes --]
> Yep, and it was already fixed and merged
Oops, sorry for the noise and thanks for fixing it!
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-07-06 21:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-06 21:04 [PATCH] clk: shmobile: emev2: annotate smu base pointer Wolfram Sang
2015-07-06 21:48 ` Stephen Boyd
2015-07-06 21:52 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox