From: Wolfram Sang <wsa@the-dreams.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-clk <linux-clk@vger.kernel.org>,
linux-renesas-soc@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>
Subject: Re: [PATCH 3/5] clk: shmobile: r8a7795: add R clk
Date: Tue, 29 Mar 2016 17:54:39 +0200 [thread overview]
Message-ID: <20160329155439.GG1398@katana> (raw)
In-Reply-To: <CAMuHMdW1zTwLbgEVZD+VOEy934yUEp90pEv-ju_1+dd5RjLp-A@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 987 bytes --]
> > @@ -114,8 +117,11 @@ static const struct cpg_core_clk r8a7795_core_clks[] __initconst = {
> > DEF_DIV6P1("hdmi", R8A7795_CLK_HDMI, CLK_PLL1_DIV2, 0x250),
> > DEF_DIV6P1("canfd", R8A7795_CLK_CANFD, CLK_PLL1_DIV4, 0x244),
> >
> > - DEF_DIV6_RO("osc", R8A7795_CLK_OSC, CLK_EXTAL, 0x0240, 8),
> > - DEF_DIV6_RO("r_int", R8A7795_CLK_RINT, CLK_EXTAL, 0x0240, 32),
> > + DEF_DIV6_RO("osc", R8A7795_CLK_OSC, CLK_EXTAL, CPG_RCKCR, 8),
> > + DEF_DIV6_RO("r_int", R8A7795_CLK_RINT, CLK_EXTAL, CPG_RCKCR, 32),
> > +
> > + /* must come after EXTALR because we need its rate */
>
> must come after r_int because we need that clock as a possible parent?
Well, I added the comment because the dependency to EXTALR is not
obvious. Unlike the dependency to RINT which is described in the same
manner as the rest of the clocks.
Maybe I should simply remove the comment if it creates only confusion?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-03-29 15:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-24 13:00 [PATCH 0/5] r8a7795: add clocks for the watchdogs Wolfram Sang
2016-03-24 13:00 ` [PATCH 1/5] clk: shmobile: cpg-mssr: add generic support for read-only DIV6 clocks Wolfram Sang
2016-03-24 14:01 ` Geert Uytterhoeven
2016-03-24 13:00 ` [PATCH 2/5] clk: shmobile: r8a7795: add OSC and RINT clocks Wolfram Sang
2016-03-24 14:11 ` Geert Uytterhoeven
2016-03-29 15:46 ` Wolfram Sang
2016-03-24 13:00 ` [PATCH 3/5] clk: shmobile: r8a7795: add R clk Wolfram Sang
2016-03-24 14:16 ` Geert Uytterhoeven
2016-03-29 15:54 ` Wolfram Sang [this message]
2016-03-29 17:52 ` Geert Uytterhoeven
2016-03-24 13:00 ` [PATCH 4/5] clk: shmobile: r8a7795: add stop for " Wolfram Sang
2016-03-24 13:00 ` [PATCH 5/5] arm64: dts: salvator-x: populate EXTALR Wolfram Sang
2016-03-24 14:06 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160329155439.GG1398@katana \
--to=wsa@the-dreams.de \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox