* [PATCH 1/3] clk: tegra: Disable spread spectrum on pll_d2
@ 2016-06-14 12:00 Thierry Reding
2016-06-14 12:00 ` [PATCH 2/3] clk: tegra: Squash sor1 safe/brick/src into a single mux Thierry Reding
` (3 more replies)
0 siblings, 4 replies; 9+ messages in thread
From: Thierry Reding @ 2016-06-14 12:00 UTC (permalink / raw)
To: Thierry Reding
Cc: Peter De Schrijver, Alexandre Courbot, Rhyland Klein, Jon Hunter,
linux-tegra, linux-clk
From: Thierry Reding <treding@nvidia.com>
Enabling spread spectrum on pll_d2 can lead to issues with display
modes. HDMI monitors, for example, would report "Signal Error" and
some modes driven over DisplayPort would generate fuzzy horizontal
bands.
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
drivers/clk/tegra/clk-tegra210.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/clk/tegra/clk-tegra210.c b/drivers/clk/tegra/clk-tegra210.c
index 6bd1235d09b1..cd141a364c9d 100644
--- a/drivers/clk/tegra/clk-tegra210.c
+++ b/drivers/clk/tegra/clk-tegra210.c
@@ -1914,8 +1914,9 @@ static struct tegra_clk_pll_params pll_d2_params = {
.sdm_din_mask = PLLA_SDM_DIN_MASK,
.sdm_ctrl_reg = PLLD2_MISC1,
.sdm_ctrl_en_mask = PLLD2_SDM_EN_MASK,
- .ssc_ctrl_reg = PLLD2_MISC1,
- .ssc_ctrl_en_mask = PLLD2_SSC_EN_MASK,
+ /* disable spread-spectrum for pll_d2 */
+ .ssc_ctrl_reg = 0,
+ .ssc_ctrl_en_mask = 0,
.round_p_to_pdiv = pll_qlin_p_to_pdiv,
.pdiv_tohw = pll_qlin_pdiv_to_hw,
.div_nmp = &pllss_nmp,
--
2.8.3
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 2/3] clk: tegra: Squash sor1 safe/brick/src into a single mux 2016-06-14 12:00 [PATCH 1/3] clk: tegra: Disable spread spectrum on pll_d2 Thierry Reding @ 2016-06-14 12:00 ` Thierry Reding 2016-06-14 15:01 ` Peter De Schrijver 2016-06-14 15:37 ` Rhyland Klein 2016-06-14 12:00 ` [PATCH 3/3] clk: tegra: Enable sor1 and sor1_src on Tegra210 Thierry Reding ` (2 subsequent siblings) 3 siblings, 2 replies; 9+ messages in thread From: Thierry Reding @ 2016-06-14 12:00 UTC (permalink / raw) To: Thierry Reding Cc: Peter De Schrijver, Alexandre Courbot, Rhyland Klein, Jon Hunter, linux-tegra, linux-clk From: Thierry Reding <treding@nvidia.com> The sor1 clock on Tegra210 is structured in the following way: +-------+ | pllp |---+ +-------+ | +--------------+ +-----------+ +----| | | sor_safe | +-------+ | | +-----------+ | plld |--------| | | +-------+ | | +-----------+ | sor1_src |-------| | +-------+ | | +-----------+ | plld2 |--------| | | +-------+ | | | +----| | | +-------+ | +--------------+ | | clkm |---+ +-----------+ +-------+ +--------------+ | | | sor1_brick |-------| sor1 | +--------------+ | | +-----------+ This is impractical to represent in a clock tree, though, because there is no name for the mux that has sor_safe and sor1_src as parents. It is also much more cumbersome to deal with the additional mux because users of these clocks (the display driver) would have to juggle with an extra mux for no real reason. To simply things, the above is squashed into two muxes instead, so that it looks like this: +-------+ | pllp |---+ +-------+ | +--------------+ +-----------+ +----| | | sor_safe | +-------+ | | +-----------+ | plld |--------| | | +-------+ | | +-----------+ | sor1_src |-------| sor1 | +-------+ | | +-----------+ | plld2 |--------| | | | +-------+ | | | | +----| | | | +-------+ | +--------------+ | | | clkm |---+ | | +-------+ +--------------+ | | | sor1_brick |-----------+---+ +--------------+ This still very accurately represents the hardware. Note that sor1 has sor1_brick as input twice, that's because bit 1 in the mux selects the sor1_brick irrespective of bit 0. Signed-off-by: Thierry Reding <treding@nvidia.com> --- drivers/clk/tegra/clk-id.h | 1 - drivers/clk/tegra/clk-tegra-periph.c | 23 ++++++++++++----------- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/clk/tegra/clk-id.h b/drivers/clk/tegra/clk-id.h index 36c974916d4f..5738635c5274 100644 --- a/drivers/clk/tegra/clk-id.h +++ b/drivers/clk/tegra/clk-id.h @@ -238,7 +238,6 @@ enum clk_id { tegra_clk_sor0, tegra_clk_sor0_lvds, tegra_clk_sor1, - tegra_clk_sor1_brick, tegra_clk_sor1_src, tegra_clk_spdif, tegra_clk_spdif_2x, diff --git a/drivers/clk/tegra/clk-tegra-periph.c b/drivers/clk/tegra/clk-tegra-periph.c index 29d04c663abf..af85c8aeaf5a 100644 --- a/drivers/clk/tegra/clk-tegra-periph.c +++ b/drivers/clk/tegra/clk-tegra-periph.c @@ -594,15 +594,17 @@ static u32 mux_pllp_plld_plld2_clkm_idx[] = { [0] = 0, [1] = 2, [2] = 5, [3] = 6 }; -static const char *mux_plldp_sor1_src[] = { - "pll_dp", "clk_sor1_src" -}; -#define mux_plldp_sor1_src_idx NULL - -static const char *mux_clkm_sor1_brick_sor1_src[] = { - "clk_m", "sor1_brick", "sor1_src", "sor1_brick" -}; -#define mux_clkm_sor1_brick_sor1_src_idx NULL +static const char *mux_sor_safe_sor1_brick_sor1_src[] = { + /* + * Bit 0 of the mux selects sor1_brick, irrespective of bit 1, so the + * sor1_brick parent appears twice in the list below. This is merely + * to support clk_get_parent() if firmware happened to set these bits + * to 0b11. While not an invalid setting, code should always set the + * bits to 0b01 to select sor1_brick. + */ + "sor_safe", "sor1_brick", "sor1_src", "sor1_brick" +}; +#define mux_sor_safe_sor1_brick_sor1_src_idx NULL static const char *mux_pllp_pllre_clkm[] = { "pll_p", "pll_re_out1", "clk_m" @@ -778,8 +780,7 @@ static struct tegra_periph_init_data periph_clks[] = { MUX8("nvjpg", mux_pllc2_c_c3_pllp_plla1_clkm, CLK_SOURCE_NVJPG, 195, 0, tegra_clk_nvjpg), MUX8("ape", mux_plla_pllc4_out0_pllc_pllc4_out1_pllp_pllc4_out2_clkm, CLK_SOURCE_APE, 198, TEGRA_PERIPH_ON_APB, tegra_clk_ape), MUX8_NOGATE_LOCK("sor1_src", mux_pllp_plld_plld2_clkm, CLK_SOURCE_SOR1, tegra_clk_sor1_src, &sor1_lock), - NODIV("sor1_brick", mux_plldp_sor1_src, CLK_SOURCE_SOR1, 14, MASK(1), 183, 0, tegra_clk_sor1_brick, &sor1_lock), - NODIV("sor1", mux_clkm_sor1_brick_sor1_src, CLK_SOURCE_SOR1, 15, MASK(1), 183, 0, tegra_clk_sor1, &sor1_lock), + NODIV("sor1", mux_sor_safe_sor1_brick_sor1_src, CLK_SOURCE_SOR1, 14, MASK(2), 183, 0, tegra_clk_sor1, &sor1_lock), MUX8("sdmmc_legacy", mux_pllp_out3_clkm_pllp_pllc4, CLK_SOURCE_SDMMC_LEGACY, 193, TEGRA_PERIPH_ON_APB | TEGRA_PERIPH_NO_RESET, tegra_clk_sdmmc_legacy), MUX8("qspi", mux_pllp_pllc_pllc_out1_pllc4_out2_pllc4_out1_clkm_pllc4_out0, CLK_SOURCE_QSPI, 211, TEGRA_PERIPH_ON_APB, tegra_clk_qspi), I2C("vii2c", mux_pllp_pllc_clkm, CLK_SOURCE_VI_I2C, 208, tegra_clk_vi_i2c), -- 2.8.3 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 2/3] clk: tegra: Squash sor1 safe/brick/src into a single mux 2016-06-14 12:00 ` [PATCH 2/3] clk: tegra: Squash sor1 safe/brick/src into a single mux Thierry Reding @ 2016-06-14 15:01 ` Peter De Schrijver 2016-06-14 15:37 ` Rhyland Klein 1 sibling, 0 replies; 9+ messages in thread From: Peter De Schrijver @ 2016-06-14 15:01 UTC (permalink / raw) To: Thierry Reding Cc: Alexandre Courbot, Rhyland Klein, Jon Hunter, linux-tegra, linux-clk On Tue, Jun 14, 2016 at 02:00:43PM +0200, Thierry Reding wrote: > From: Thierry Reding <treding@nvidia.com> > > The sor1 clock on Tegra210 is structured in the following way: > > +-------+ > | pllp |---+ > +-------+ | +--------------+ +-----------+ > +----| | | sor_safe | > +-------+ | | +-----------+ > | plld |--------| | | > +-------+ | | +-----------+ > | sor1_src |-------| | > +-------+ | | +-----------+ > | plld2 |--------| | | > +-------+ | | | > +----| | | > +-------+ | +--------------+ | > | clkm |---+ +-----------+ > +-------+ +--------------+ | | > | sor1_brick |-------| sor1 | > +--------------+ | | > +-----------+ > > This is impractical to represent in a clock tree, though, because there > is no name for the mux that has sor_safe and sor1_src as parents. It is > also much more cumbersome to deal with the additional mux because users > of these clocks (the display driver) would have to juggle with an extra > mux for no real reason. > > To simply things, the above is squashed into two muxes instead, so that > it looks like this: > > +-------+ > | pllp |---+ > +-------+ | +--------------+ +-----------+ > +----| | | sor_safe | > +-------+ | | +-----------+ > | plld |--------| | | > +-------+ | | +-----------+ > | sor1_src |-------| sor1 | > +-------+ | | +-----------+ > | plld2 |--------| | | | > +-------+ | | | | > +----| | | | > +-------+ | +--------------+ | | > | clkm |---+ | | > +-------+ +--------------+ | | > | sor1_brick |-----------+---+ > +--------------+ > > This still very accurately represents the hardware. Note that sor1 has > sor1_brick as input twice, that's because bit 1 in the mux selects the > sor1_brick irrespective of bit 0. > Assming sor1_brick will be defined in the SOR driver, Acked-by: Peter De Schrijver <pdeschrijver@nvidia.com> Peter. > Signed-off-by: Thierry Reding <treding@nvidia.com> > --- > drivers/clk/tegra/clk-id.h | 1 - > drivers/clk/tegra/clk-tegra-periph.c | 23 ++++++++++++----------- > 2 files changed, 12 insertions(+), 12 deletions(-) > > diff --git a/drivers/clk/tegra/clk-id.h b/drivers/clk/tegra/clk-id.h > index 36c974916d4f..5738635c5274 100644 > --- a/drivers/clk/tegra/clk-id.h > +++ b/drivers/clk/tegra/clk-id.h > @@ -238,7 +238,6 @@ enum clk_id { > tegra_clk_sor0, > tegra_clk_sor0_lvds, > tegra_clk_sor1, > - tegra_clk_sor1_brick, > tegra_clk_sor1_src, > tegra_clk_spdif, > tegra_clk_spdif_2x, > diff --git a/drivers/clk/tegra/clk-tegra-periph.c b/drivers/clk/tegra/clk-tegra-periph.c > index 29d04c663abf..af85c8aeaf5a 100644 > --- a/drivers/clk/tegra/clk-tegra-periph.c > +++ b/drivers/clk/tegra/clk-tegra-periph.c > @@ -594,15 +594,17 @@ static u32 mux_pllp_plld_plld2_clkm_idx[] = { > [0] = 0, [1] = 2, [2] = 5, [3] = 6 > }; > > -static const char *mux_plldp_sor1_src[] = { > - "pll_dp", "clk_sor1_src" > -}; > -#define mux_plldp_sor1_src_idx NULL > - > -static const char *mux_clkm_sor1_brick_sor1_src[] = { > - "clk_m", "sor1_brick", "sor1_src", "sor1_brick" > -}; > -#define mux_clkm_sor1_brick_sor1_src_idx NULL > +static const char *mux_sor_safe_sor1_brick_sor1_src[] = { > + /* > + * Bit 0 of the mux selects sor1_brick, irrespective of bit 1, so the > + * sor1_brick parent appears twice in the list below. This is merely > + * to support clk_get_parent() if firmware happened to set these bits > + * to 0b11. While not an invalid setting, code should always set the > + * bits to 0b01 to select sor1_brick. > + */ > + "sor_safe", "sor1_brick", "sor1_src", "sor1_brick" > +}; > +#define mux_sor_safe_sor1_brick_sor1_src_idx NULL > > static const char *mux_pllp_pllre_clkm[] = { > "pll_p", "pll_re_out1", "clk_m" > @@ -778,8 +780,7 @@ static struct tegra_periph_init_data periph_clks[] = { > MUX8("nvjpg", mux_pllc2_c_c3_pllp_plla1_clkm, CLK_SOURCE_NVJPG, 195, 0, tegra_clk_nvjpg), > MUX8("ape", mux_plla_pllc4_out0_pllc_pllc4_out1_pllp_pllc4_out2_clkm, CLK_SOURCE_APE, 198, TEGRA_PERIPH_ON_APB, tegra_clk_ape), > MUX8_NOGATE_LOCK("sor1_src", mux_pllp_plld_plld2_clkm, CLK_SOURCE_SOR1, tegra_clk_sor1_src, &sor1_lock), > - NODIV("sor1_brick", mux_plldp_sor1_src, CLK_SOURCE_SOR1, 14, MASK(1), 183, 0, tegra_clk_sor1_brick, &sor1_lock), > - NODIV("sor1", mux_clkm_sor1_brick_sor1_src, CLK_SOURCE_SOR1, 15, MASK(1), 183, 0, tegra_clk_sor1, &sor1_lock), > + NODIV("sor1", mux_sor_safe_sor1_brick_sor1_src, CLK_SOURCE_SOR1, 14, MASK(2), 183, 0, tegra_clk_sor1, &sor1_lock), > MUX8("sdmmc_legacy", mux_pllp_out3_clkm_pllp_pllc4, CLK_SOURCE_SDMMC_LEGACY, 193, TEGRA_PERIPH_ON_APB | TEGRA_PERIPH_NO_RESET, tegra_clk_sdmmc_legacy), > MUX8("qspi", mux_pllp_pllc_pllc_out1_pllc4_out2_pllc4_out1_clkm_pllc4_out0, CLK_SOURCE_QSPI, 211, TEGRA_PERIPH_ON_APB, tegra_clk_qspi), > I2C("vii2c", mux_pllp_pllc_clkm, CLK_SOURCE_VI_I2C, 208, tegra_clk_vi_i2c), > -- > 2.8.3 > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/3] clk: tegra: Squash sor1 safe/brick/src into a single mux 2016-06-14 12:00 ` [PATCH 2/3] clk: tegra: Squash sor1 safe/brick/src into a single mux Thierry Reding 2016-06-14 15:01 ` Peter De Schrijver @ 2016-06-14 15:37 ` Rhyland Klein 1 sibling, 0 replies; 9+ messages in thread From: Rhyland Klein @ 2016-06-14 15:37 UTC (permalink / raw) To: Thierry Reding Cc: Peter De Schrijver, Alexandre Courbot, Jon Hunter, linux-tegra, linux-clk On 6/14/2016 8:00 AM, Thierry Reding wrote: > From: Thierry Reding <treding@nvidia.com> > > The sor1 clock on Tegra210 is structured in the following way: > > +-------+ > | pllp |---+ > +-------+ | +--------------+ +-----------+ > +----| | | sor_safe | > +-------+ | | +-----------+ > | plld |--------| | | > +-------+ | | +-----------+ > | sor1_src |-------| | > +-------+ | | +-----------+ > | plld2 |--------| | | > +-------+ | | | > +----| | | > +-------+ | +--------------+ | > | clkm |---+ +-----------+ > +-------+ +--------------+ | | > | sor1_brick |-------| sor1 | > +--------------+ | | > +-----------+ > > This is impractical to represent in a clock tree, though, because there > is no name for the mux that has sor_safe and sor1_src as parents. It is > also much more cumbersome to deal with the additional mux because users > of these clocks (the display driver) would have to juggle with an extra > mux for no real reason. > > To simply things, the above is squashed into two muxes instead, so that > it looks like this: > > +-------+ > | pllp |---+ > +-------+ | +--------------+ +-----------+ > +----| | | sor_safe | > +-------+ | | +-----------+ > | plld |--------| | | > +-------+ | | +-----------+ > | sor1_src |-------| sor1 | > +-------+ | | +-----------+ > | plld2 |--------| | | | > +-------+ | | | | > +----| | | | > +-------+ | +--------------+ | | > | clkm |---+ | | > +-------+ +--------------+ | | > | sor1_brick |-----------+---+ > +--------------+ > > This still very accurately represents the hardware. Note that sor1 has > sor1_brick as input twice, that's because bit 1 in the mux selects the > sor1_brick irrespective of bit 0. > > Signed-off-by: Thierry Reding <treding@nvidia.com> > --- > drivers/clk/tegra/clk-id.h | 1 - > drivers/clk/tegra/clk-tegra-periph.c | 23 ++++++++++++----------- > 2 files changed, 12 insertions(+), 12 deletions(-) > > diff --git a/drivers/clk/tegra/clk-id.h b/drivers/clk/tegra/clk-id.h > index 36c974916d4f..5738635c5274 100644 > --- a/drivers/clk/tegra/clk-id.h > +++ b/drivers/clk/tegra/clk-id.h > @@ -238,7 +238,6 @@ enum clk_id { > tegra_clk_sor0, > tegra_clk_sor0_lvds, > tegra_clk_sor1, > - tegra_clk_sor1_brick, > tegra_clk_sor1_src, > tegra_clk_spdif, > tegra_clk_spdif_2x, > diff --git a/drivers/clk/tegra/clk-tegra-periph.c b/drivers/clk/tegra/clk-tegra-periph.c > index 29d04c663abf..af85c8aeaf5a 100644 > --- a/drivers/clk/tegra/clk-tegra-periph.c > +++ b/drivers/clk/tegra/clk-tegra-periph.c > @@ -594,15 +594,17 @@ static u32 mux_pllp_plld_plld2_clkm_idx[] = { > [0] = 0, [1] = 2, [2] = 5, [3] = 6 > }; > > -static const char *mux_plldp_sor1_src[] = { > - "pll_dp", "clk_sor1_src" > -}; > -#define mux_plldp_sor1_src_idx NULL > - > -static const char *mux_clkm_sor1_brick_sor1_src[] = { > - "clk_m", "sor1_brick", "sor1_src", "sor1_brick" > -}; > -#define mux_clkm_sor1_brick_sor1_src_idx NULL > +static const char *mux_sor_safe_sor1_brick_sor1_src[] = { > + /* > + * Bit 0 of the mux selects sor1_brick, irrespective of bit 1, so the > + * sor1_brick parent appears twice in the list below. This is merely > + * to support clk_get_parent() if firmware happened to set these bits > + * to 0b11. While not an invalid setting, code should always set the > + * bits to 0b01 to select sor1_brick. > + */ > + "sor_safe", "sor1_brick", "sor1_src", "sor1_brick" > +}; > +#define mux_sor_safe_sor1_brick_sor1_src_idx NULL > > static const char *mux_pllp_pllre_clkm[] = { > "pll_p", "pll_re_out1", "clk_m" > @@ -778,8 +780,7 @@ static struct tegra_periph_init_data periph_clks[] = { > MUX8("nvjpg", mux_pllc2_c_c3_pllp_plla1_clkm, CLK_SOURCE_NVJPG, 195, 0, tegra_clk_nvjpg), > MUX8("ape", mux_plla_pllc4_out0_pllc_pllc4_out1_pllp_pllc4_out2_clkm, CLK_SOURCE_APE, 198, TEGRA_PERIPH_ON_APB, tegra_clk_ape), > MUX8_NOGATE_LOCK("sor1_src", mux_pllp_plld_plld2_clkm, CLK_SOURCE_SOR1, tegra_clk_sor1_src, &sor1_lock), > - NODIV("sor1_brick", mux_plldp_sor1_src, CLK_SOURCE_SOR1, 14, MASK(1), 183, 0, tegra_clk_sor1_brick, &sor1_lock), > - NODIV("sor1", mux_clkm_sor1_brick_sor1_src, CLK_SOURCE_SOR1, 15, MASK(1), 183, 0, tegra_clk_sor1, &sor1_lock), > + NODIV("sor1", mux_sor_safe_sor1_brick_sor1_src, CLK_SOURCE_SOR1, 14, MASK(2), 183, 0, tegra_clk_sor1, &sor1_lock), > MUX8("sdmmc_legacy", mux_pllp_out3_clkm_pllp_pllc4, CLK_SOURCE_SDMMC_LEGACY, 193, TEGRA_PERIPH_ON_APB | TEGRA_PERIPH_NO_RESET, tegra_clk_sdmmc_legacy), > MUX8("qspi", mux_pllp_pllc_pllc_out1_pllc4_out2_pllc4_out1_clkm_pllc4_out0, CLK_SOURCE_QSPI, 211, TEGRA_PERIPH_ON_APB, tegra_clk_qspi), > I2C("vii2c", mux_pllp_pllc_clkm, CLK_SOURCE_VI_I2C, 208, tegra_clk_vi_i2c), > Acked-by: Rhyland Klein <rklein@nvidia.com> -- nvpublic ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 3/3] clk: tegra: Enable sor1 and sor1_src on Tegra210 2016-06-14 12:00 [PATCH 1/3] clk: tegra: Disable spread spectrum on pll_d2 Thierry Reding 2016-06-14 12:00 ` [PATCH 2/3] clk: tegra: Squash sor1 safe/brick/src into a single mux Thierry Reding @ 2016-06-14 12:00 ` Thierry Reding 2016-06-14 15:02 ` Peter De Schrijver 2016-06-14 15:37 ` Rhyland Klein 2016-06-14 14:57 ` [PATCH 1/3] clk: tegra: Disable spread spectrum on pll_d2 Peter De Schrijver 2016-06-14 15:35 ` Rhyland Klein 3 siblings, 2 replies; 9+ messages in thread From: Thierry Reding @ 2016-06-14 12:00 UTC (permalink / raw) To: Thierry Reding Cc: Peter De Schrijver, Alexandre Courbot, Rhyland Klein, Jon Hunter, linux-tegra, linux-clk From: Thierry Reding <treding@nvidia.com> Make the sor1 and sor1_src clocks available on Tegra210. They will be used by the display driver to support HDMI and DP. Signed-off-by: Thierry Reding <treding@nvidia.com> --- drivers/clk/tegra/clk-tegra210.c | 2 ++ include/dt-bindings/clock/tegra210-car.h | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/clk/tegra/clk-tegra210.c b/drivers/clk/tegra/clk-tegra210.c index cd141a364c9d..8e37eda37449 100644 --- a/drivers/clk/tegra/clk-tegra210.c +++ b/drivers/clk/tegra/clk-tegra210.c @@ -2093,6 +2093,8 @@ static struct tegra_clk tegra210_clks[tegra_clk_max] __initdata = { [tegra_clk_dpaux1] = { .dt_id = TEGRA210_CLK_DPAUX1, .present = true }, [tegra_clk_sor0] = { .dt_id = TEGRA210_CLK_SOR0, .present = true }, [tegra_clk_sor0_lvds] = { .dt_id = TEGRA210_CLK_SOR0_LVDS, .present = true }, + [tegra_clk_sor1] = { .dt_id = TEGRA210_CLK_SOR1, .present = true }, + [tegra_clk_sor1_src] = { .dt_id = TEGRA210_CLK_SOR1_SRC, .present = true }, [tegra_clk_gpu] = { .dt_id = TEGRA210_CLK_GPU, .present = true }, [tegra_clk_pll_g_ref] = { .dt_id = TEGRA210_CLK_PLL_G_REF, .present = true, }, [tegra_clk_uartb_8] = { .dt_id = TEGRA210_CLK_UARTB, .present = true }, diff --git a/include/dt-bindings/clock/tegra210-car.h b/include/dt-bindings/clock/tegra210-car.h index bd3530e56d46..35288b20f2c9 100644 --- a/include/dt-bindings/clock/tegra210-car.h +++ b/include/dt-bindings/clock/tegra210-car.h @@ -308,7 +308,7 @@ #define TEGRA210_CLK_CLK_OUT_3 279 #define TEGRA210_CLK_BLINK 280 /* 281 */ -/* 282 */ +#define TEGRA210_CLK_SOR1_SRC 282 /* 283 */ #define TEGRA210_CLK_XUSB_HOST_SRC 284 #define TEGRA210_CLK_XUSB_FALCON_SRC 285 -- 2.8.3 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 3/3] clk: tegra: Enable sor1 and sor1_src on Tegra210 2016-06-14 12:00 ` [PATCH 3/3] clk: tegra: Enable sor1 and sor1_src on Tegra210 Thierry Reding @ 2016-06-14 15:02 ` Peter De Schrijver 2016-06-14 15:37 ` Rhyland Klein 1 sibling, 0 replies; 9+ messages in thread From: Peter De Schrijver @ 2016-06-14 15:02 UTC (permalink / raw) To: Thierry Reding Cc: Alexandre Courbot, Rhyland Klein, Jon Hunter, linux-tegra, linux-clk On Tue, Jun 14, 2016 at 02:00:44PM +0200, Thierry Reding wrote: > From: Thierry Reding <treding@nvidia.com> > > Make the sor1 and sor1_src clocks available on Tegra210. They will be > used by the display driver to support HDMI and DP. > Acked-by: Peter De Schrijver <pdeschrijver@nvidia.com> > Signed-off-by: Thierry Reding <treding@nvidia.com> > --- > drivers/clk/tegra/clk-tegra210.c | 2 ++ > include/dt-bindings/clock/tegra210-car.h | 2 +- > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/clk/tegra/clk-tegra210.c b/drivers/clk/tegra/clk-tegra210.c > index cd141a364c9d..8e37eda37449 100644 > --- a/drivers/clk/tegra/clk-tegra210.c > +++ b/drivers/clk/tegra/clk-tegra210.c > @@ -2093,6 +2093,8 @@ static struct tegra_clk tegra210_clks[tegra_clk_max] __initdata = { > [tegra_clk_dpaux1] = { .dt_id = TEGRA210_CLK_DPAUX1, .present = true }, > [tegra_clk_sor0] = { .dt_id = TEGRA210_CLK_SOR0, .present = true }, > [tegra_clk_sor0_lvds] = { .dt_id = TEGRA210_CLK_SOR0_LVDS, .present = true }, > + [tegra_clk_sor1] = { .dt_id = TEGRA210_CLK_SOR1, .present = true }, > + [tegra_clk_sor1_src] = { .dt_id = TEGRA210_CLK_SOR1_SRC, .present = true }, > [tegra_clk_gpu] = { .dt_id = TEGRA210_CLK_GPU, .present = true }, > [tegra_clk_pll_g_ref] = { .dt_id = TEGRA210_CLK_PLL_G_REF, .present = true, }, > [tegra_clk_uartb_8] = { .dt_id = TEGRA210_CLK_UARTB, .present = true }, > diff --git a/include/dt-bindings/clock/tegra210-car.h b/include/dt-bindings/clock/tegra210-car.h > index bd3530e56d46..35288b20f2c9 100644 > --- a/include/dt-bindings/clock/tegra210-car.h > +++ b/include/dt-bindings/clock/tegra210-car.h > @@ -308,7 +308,7 @@ > #define TEGRA210_CLK_CLK_OUT_3 279 > #define TEGRA210_CLK_BLINK 280 > /* 281 */ > -/* 282 */ > +#define TEGRA210_CLK_SOR1_SRC 282 > /* 283 */ > #define TEGRA210_CLK_XUSB_HOST_SRC 284 > #define TEGRA210_CLK_XUSB_FALCON_SRC 285 > -- > 2.8.3 > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 3/3] clk: tegra: Enable sor1 and sor1_src on Tegra210 2016-06-14 12:00 ` [PATCH 3/3] clk: tegra: Enable sor1 and sor1_src on Tegra210 Thierry Reding 2016-06-14 15:02 ` Peter De Schrijver @ 2016-06-14 15:37 ` Rhyland Klein 1 sibling, 0 replies; 9+ messages in thread From: Rhyland Klein @ 2016-06-14 15:37 UTC (permalink / raw) To: Thierry Reding Cc: Peter De Schrijver, Alexandre Courbot, Jon Hunter, linux-tegra, linux-clk On 6/14/2016 8:00 AM, Thierry Reding wrote: > From: Thierry Reding <treding@nvidia.com> > > Make the sor1 and sor1_src clocks available on Tegra210. They will be > used by the display driver to support HDMI and DP. > > Signed-off-by: Thierry Reding <treding@nvidia.com> > --- > drivers/clk/tegra/clk-tegra210.c | 2 ++ > include/dt-bindings/clock/tegra210-car.h | 2 +- > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/clk/tegra/clk-tegra210.c b/drivers/clk/tegra/clk-tegra210.c > index cd141a364c9d..8e37eda37449 100644 > --- a/drivers/clk/tegra/clk-tegra210.c > +++ b/drivers/clk/tegra/clk-tegra210.c > @@ -2093,6 +2093,8 @@ static struct tegra_clk tegra210_clks[tegra_clk_max] __initdata = { > [tegra_clk_dpaux1] = { .dt_id = TEGRA210_CLK_DPAUX1, .present = true }, > [tegra_clk_sor0] = { .dt_id = TEGRA210_CLK_SOR0, .present = true }, > [tegra_clk_sor0_lvds] = { .dt_id = TEGRA210_CLK_SOR0_LVDS, .present = true }, > + [tegra_clk_sor1] = { .dt_id = TEGRA210_CLK_SOR1, .present = true }, > + [tegra_clk_sor1_src] = { .dt_id = TEGRA210_CLK_SOR1_SRC, .present = true }, > [tegra_clk_gpu] = { .dt_id = TEGRA210_CLK_GPU, .present = true }, > [tegra_clk_pll_g_ref] = { .dt_id = TEGRA210_CLK_PLL_G_REF, .present = true, }, > [tegra_clk_uartb_8] = { .dt_id = TEGRA210_CLK_UARTB, .present = true }, > diff --git a/include/dt-bindings/clock/tegra210-car.h b/include/dt-bindings/clock/tegra210-car.h > index bd3530e56d46..35288b20f2c9 100644 > --- a/include/dt-bindings/clock/tegra210-car.h > +++ b/include/dt-bindings/clock/tegra210-car.h > @@ -308,7 +308,7 @@ > #define TEGRA210_CLK_CLK_OUT_3 279 > #define TEGRA210_CLK_BLINK 280 > /* 281 */ > -/* 282 */ > +#define TEGRA210_CLK_SOR1_SRC 282 > /* 283 */ > #define TEGRA210_CLK_XUSB_HOST_SRC 284 > #define TEGRA210_CLK_XUSB_FALCON_SRC 285 > Acked-by: Rhyland Klein <rklein@nvidia.com> -- nvpublic ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/3] clk: tegra: Disable spread spectrum on pll_d2 2016-06-14 12:00 [PATCH 1/3] clk: tegra: Disable spread spectrum on pll_d2 Thierry Reding 2016-06-14 12:00 ` [PATCH 2/3] clk: tegra: Squash sor1 safe/brick/src into a single mux Thierry Reding 2016-06-14 12:00 ` [PATCH 3/3] clk: tegra: Enable sor1 and sor1_src on Tegra210 Thierry Reding @ 2016-06-14 14:57 ` Peter De Schrijver 2016-06-14 15:35 ` Rhyland Klein 3 siblings, 0 replies; 9+ messages in thread From: Peter De Schrijver @ 2016-06-14 14:57 UTC (permalink / raw) To: Thierry Reding Cc: Alexandre Courbot, Rhyland Klein, Jon Hunter, linux-tegra, linux-clk On Tue, Jun 14, 2016 at 02:00:42PM +0200, Thierry Reding wrote: > From: Thierry Reding <treding@nvidia.com> > > Enabling spread spectrum on pll_d2 can lead to issues with display > modes. HDMI monitors, for example, would report "Signal Error" and > some modes driven over DisplayPort would generate fuzzy horizontal > bands. > Acked-by: Peter De Schrijver <pdeschrijver@nvidia.com> The only display clock we should enable spread spectrum for, is pll_dp. AFAIK the DP spec specifies the amount of spread which can be tolerated. Peter. > Signed-off-by: Thierry Reding <treding@nvidia.com> > --- > drivers/clk/tegra/clk-tegra210.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/clk/tegra/clk-tegra210.c b/drivers/clk/tegra/clk-tegra210.c > index 6bd1235d09b1..cd141a364c9d 100644 > --- a/drivers/clk/tegra/clk-tegra210.c > +++ b/drivers/clk/tegra/clk-tegra210.c > @@ -1914,8 +1914,9 @@ static struct tegra_clk_pll_params pll_d2_params = { > .sdm_din_mask = PLLA_SDM_DIN_MASK, > .sdm_ctrl_reg = PLLD2_MISC1, > .sdm_ctrl_en_mask = PLLD2_SDM_EN_MASK, > - .ssc_ctrl_reg = PLLD2_MISC1, > - .ssc_ctrl_en_mask = PLLD2_SSC_EN_MASK, > + /* disable spread-spectrum for pll_d2 */ > + .ssc_ctrl_reg = 0, > + .ssc_ctrl_en_mask = 0, > .round_p_to_pdiv = pll_qlin_p_to_pdiv, > .pdiv_tohw = pll_qlin_pdiv_to_hw, > .div_nmp = &pllss_nmp, > -- > 2.8.3 > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/3] clk: tegra: Disable spread spectrum on pll_d2 2016-06-14 12:00 [PATCH 1/3] clk: tegra: Disable spread spectrum on pll_d2 Thierry Reding ` (2 preceding siblings ...) 2016-06-14 14:57 ` [PATCH 1/3] clk: tegra: Disable spread spectrum on pll_d2 Peter De Schrijver @ 2016-06-14 15:35 ` Rhyland Klein 3 siblings, 0 replies; 9+ messages in thread From: Rhyland Klein @ 2016-06-14 15:35 UTC (permalink / raw) To: Thierry Reding Cc: Peter De Schrijver, Alexandre Courbot, Jon Hunter, linux-tegra, linux-clk On 6/14/2016 8:00 AM, Thierry Reding wrote: > From: Thierry Reding <treding@nvidia.com> > > Enabling spread spectrum on pll_d2 can lead to issues with display > modes. HDMI monitors, for example, would report "Signal Error" and > some modes driven over DisplayPort would generate fuzzy horizontal > bands. > > Signed-off-by: Thierry Reding <treding@nvidia.com> > --- > drivers/clk/tegra/clk-tegra210.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/clk/tegra/clk-tegra210.c b/drivers/clk/tegra/clk-tegra210.c > index 6bd1235d09b1..cd141a364c9d 100644 > --- a/drivers/clk/tegra/clk-tegra210.c > +++ b/drivers/clk/tegra/clk-tegra210.c > @@ -1914,8 +1914,9 @@ static struct tegra_clk_pll_params pll_d2_params = { > .sdm_din_mask = PLLA_SDM_DIN_MASK, > .sdm_ctrl_reg = PLLD2_MISC1, > .sdm_ctrl_en_mask = PLLD2_SDM_EN_MASK, > - .ssc_ctrl_reg = PLLD2_MISC1, > - .ssc_ctrl_en_mask = PLLD2_SSC_EN_MASK, > + /* disable spread-spectrum for pll_d2 */ > + .ssc_ctrl_reg = 0, > + .ssc_ctrl_en_mask = 0, > .round_p_to_pdiv = pll_qlin_p_to_pdiv, > .pdiv_tohw = pll_qlin_pdiv_to_hw, > .div_nmp = &pllss_nmp, > Acked-by: Rhyland Klein <rklein@nvidia.com> -- nvpublic ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2016-06-14 15:37 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-06-14 12:00 [PATCH 1/3] clk: tegra: Disable spread spectrum on pll_d2 Thierry Reding 2016-06-14 12:00 ` [PATCH 2/3] clk: tegra: Squash sor1 safe/brick/src into a single mux Thierry Reding 2016-06-14 15:01 ` Peter De Schrijver 2016-06-14 15:37 ` Rhyland Klein 2016-06-14 12:00 ` [PATCH 3/3] clk: tegra: Enable sor1 and sor1_src on Tegra210 Thierry Reding 2016-06-14 15:02 ` Peter De Schrijver 2016-06-14 15:37 ` Rhyland Klein 2016-06-14 14:57 ` [PATCH 1/3] clk: tegra: Disable spread spectrum on pll_d2 Peter De Schrijver 2016-06-14 15:35 ` Rhyland Klein
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox