From: Darren Hart <dvhart@infradead.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Irina Tirdea <irina.tirdea@intel.com>,
linux-clk@vger.kernel.org, x86@kernel.org,
Stephen Boyd <sboyd@codeaurora.org>,
Ingo Molnar <mingo@redhat.com>,
Michael Turquette <mturquette@baylibre.com>,
"H. Peter Anvin" <hpa@zytor.com>,
alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>,
Takashi Iwai <tiwai@suse.com>,
Pierre-Louis Bossart <pierre-louis.bossart@intel.com>,
LKML <linux-kernel@vger.kernel.org>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Subject: Re: [RESEND PATCH v4] clk: x86: Add Atom PMC platform clocks
Date: Thu, 20 Oct 2016 21:59:32 -0700 [thread overview]
Message-ID: <20161021045932.GA90338@f23x64.localdomain> (raw)
In-Reply-To: <alpine.DEB.2.20.1610202349200.4938@nanos>
On Thu, Oct 20, 2016 at 11:52:38PM +0200, Thomas Gleixner wrote:
> On Mon, 17 Oct 2016, Irina Tirdea wrote:
> > The patch has already been reviewed by Stephen Boyd [1].
> > The only remaining question is the one pointed out by Stephen:
> > "Will there be problems if this merges through clk tree? If so we
> > could take the clk driver part and the platform data include part
> > could be duplicated into both trees. Or clk tree could be pulled
> > into x86?" [1]
>
> The proper thing to do is:
>
> Move all that cruft including arch/x86/platform/atom/pmc_atom.c into
> drivers/platform/x86. There is nothing architecture specific in these
> files. It's pure peripheral driver enablement. So drivers/platform/x86 is
> the proper location for this. Please discuss this with Darren Hart (cc'ed).
We've been adding more of the pmc and punit drivers to drivers/platform/x86.
This makes more sense than being under "arch". Thomas and I have discussed
moving more of the non architectural stuff in arch/x86/platform to my tree under
platform/drivers/x86.
Irina, please point me at the relevant context if it's more than just this
particular patch.
--
Darren Hart
Intel Open Source Technology Center
next prev parent reply other threads:[~2016-10-21 4:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-17 20:15 [RESEND PATCH v4] clk: x86: Add Atom PMC platform clocks Irina Tirdea
2016-10-20 21:52 ` Thomas Gleixner
2016-10-21 4:59 ` Darren Hart [this message]
2016-10-24 13:38 ` Tirdea, Irina
2016-10-26 21:33 ` Darren Hart
2016-10-26 21:43 ` Thomas Gleixner
2016-10-26 22:02 ` Darren Hart
2016-10-27 13:50 ` Tirdea, Irina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161021045932.GA90338@f23x64.localdomain \
--to=dvhart@infradead.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=hpa@zytor.com \
--cc=irina.tirdea@intel.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mturquette@baylibre.com \
--cc=pierre-louis.bossart@intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=sboyd@codeaurora.org \
--cc=tglx@linutronix.de \
--cc=tiwai@suse.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox