From: Thomas Gleixner <tglx@linutronix.de>
To: Darren Hart <dvhart@infradead.org>
Cc: "Tirdea, Irina" <irina.tirdea@intel.com>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>,
Stephen Boyd <sboyd@codeaurora.org>,
Ingo Molnar <mingo@redhat.com>,
Michael Turquette <mturquette@baylibre.com>,
"H. Peter Anvin" <hpa@zytor.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.com>,
"Bossart, Pierre-louis" <pierre-louis.bossart@intel.com>,
LKML <linux-kernel@vger.kernel.org>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Subject: Re: [RESEND PATCH v4] clk: x86: Add Atom PMC platform clocks
Date: Wed, 26 Oct 2016 23:43:24 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1610262341020.5013@nanos> (raw)
In-Reply-To: <20161026213323.GB23374@f23x64.localdomain>
On Wed, 26 Oct 2016, Darren Hart wrote:
> On Mon, Oct 24, 2016 at 01:38:54PM +0000, Tirdea, Irina wrote:
> > intel_pmc_* drivers or is it enough to move it as a standalone driver for now?
>
> If the functionality is substantially different, then I don't see a
> compelling, and certainly not an immediate, need to merge them. Assume
> for now they are to remain as separate drivers. I suggest keeping the
> existing name for now as well. Let's just complete the move with as
> little user-visible changes as possible.
>
> The placement of the header file is a bit tricky as it is being used in
> drivers/clk/x86 in addition to the pmc_atom driver in
> drivers/platform/x86.
>
> The best existing location would appear to be include/platform_data/
>
> Thomas, is that acceptable to you?
Yes
> arch/x86/platform/atom/pmc_atom.c -> drivers/platform/x86
> arch/x86/include/asm/pmc_atom.h -> include/platform_data/
>
> If there are enough of these, it might make sense to create:
>
> include/platform/x86/
>
> but I suggest we start with minimal change.
No. Make that x86 directory right away. include/platform_data is already a
maze of 224 files. Start structuring it now.
Thanks,
tglx
next prev parent reply other threads:[~2016-10-26 21:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-17 20:15 [RESEND PATCH v4] clk: x86: Add Atom PMC platform clocks Irina Tirdea
2016-10-20 21:52 ` Thomas Gleixner
2016-10-21 4:59 ` Darren Hart
2016-10-24 13:38 ` Tirdea, Irina
2016-10-26 21:33 ` Darren Hart
2016-10-26 21:43 ` Thomas Gleixner [this message]
2016-10-26 22:02 ` Darren Hart
2016-10-27 13:50 ` Tirdea, Irina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1610262341020.5013@nanos \
--to=tglx@linutronix.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=dvhart@infradead.org \
--cc=hpa@zytor.com \
--cc=irina.tirdea@intel.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mturquette@baylibre.com \
--cc=pierre-louis.bossart@intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=sboyd@codeaurora.org \
--cc=tiwai@suse.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox