* [PATCH] clk: sunxi: ccu-sun5i needs nkmp
@ 2017-02-14 21:29 Arnd Bergmann
2017-02-16 17:53 ` Maxime Ripard
0 siblings, 1 reply; 4+ messages in thread
From: Arnd Bergmann @ 2017-02-14 21:29 UTC (permalink / raw)
To: Michael Turquette
Cc: Arnd Bergmann, Stephen Boyd, Maxime Ripard, Chen-Yu Tsai,
Rob Herring, linux-clk, linux-arm-kernel, linux-kernel
A randconfig build ran into this rare link error:
drivers/clk/sunxi-ng/ccu-sun5i.o:(.data.__compound_literal.1+0x4): undefined reference to `ccu_nkmp_ops'
drivers/clk/sunxi-ng/ccu-sun5i.o:(.data.__compound_literal.7+0x4): undefined reference to `ccu_nkmp_ops'
This adds the missing 'select'.
Fixes: 5e73761786d6 ("clk: sunxi-ng: Add sun5i CCU driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/clk/sunxi-ng/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/sunxi-ng/Kconfig b/drivers/clk/sunxi-ng/Kconfig
index 695bbf9ef428..b6e2aa5d0246 100644
--- a/drivers/clk/sunxi-ng/Kconfig
+++ b/drivers/clk/sunxi-ng/Kconfig
@@ -70,6 +70,7 @@ config SUN5I_CCU
select SUNXI_CCU_MULT
select SUNXI_CCU_NK
select SUNXI_CCU_NKM
+ select SUNXI_CCU_NKMP
select SUNXI_CCU_NM
select SUNXI_CCU_MP
select SUNXI_CCU_PHASE
--
2.9.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] clk: sunxi: ccu-sun5i needs nkmp
2017-02-14 21:29 [PATCH] clk: sunxi: ccu-sun5i needs nkmp Arnd Bergmann
@ 2017-02-16 17:53 ` Maxime Ripard
2017-03-13 16:24 ` Arnd Bergmann
0 siblings, 1 reply; 4+ messages in thread
From: Maxime Ripard @ 2017-02-16 17:53 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Michael Turquette, Stephen Boyd, Chen-Yu Tsai, Rob Herring,
linux-clk, linux-arm-kernel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 640 bytes --]
On Tue, Feb 14, 2017 at 10:29:45PM +0100, Arnd Bergmann wrote:
> A randconfig build ran into this rare link error:
>
> drivers/clk/sunxi-ng/ccu-sun5i.o:(.data.__compound_literal.1+0x4): undefined reference to `ccu_nkmp_ops'
> drivers/clk/sunxi-ng/ccu-sun5i.o:(.data.__compound_literal.7+0x4): undefined reference to `ccu_nkmp_ops'
>
> This adds the missing 'select'.
>
> Fixes: 5e73761786d6 ("clk: sunxi-ng: Add sun5i CCU driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Queued as a fix for 4.11, thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] clk: sunxi: ccu-sun5i needs nkmp
2017-02-16 17:53 ` Maxime Ripard
@ 2017-03-13 16:24 ` Arnd Bergmann
2017-03-20 9:51 ` Maxime Ripard
0 siblings, 1 reply; 4+ messages in thread
From: Arnd Bergmann @ 2017-03-13 16:24 UTC (permalink / raw)
To: Maxime Ripard
Cc: Michael Turquette, Stephen Boyd, Chen-Yu Tsai, Rob Herring,
linux-clk, Linux ARM, Linux Kernel Mailing List
On Thu, Feb 16, 2017 at 6:53 PM, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:
> On Tue, Feb 14, 2017 at 10:29:45PM +0100, Arnd Bergmann wrote:
>> A randconfig build ran into this rare link error:
>>
>> drivers/clk/sunxi-ng/ccu-sun5i.o:(.data.__compound_literal.1+0x4): undefined reference to `ccu_nkmp_ops'
>> drivers/clk/sunxi-ng/ccu-sun5i.o:(.data.__compound_literal.7+0x4): undefined reference to `ccu_nkmp_ops'
>>
>> This adds the missing 'select'.
>>
>> Fixes: 5e73761786d6 ("clk: sunxi-ng: Add sun5i CCU driver")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Queued as a fix for 4.11, thanks!
I just checked my old patches and this seems to still be required as of
4.11-rc2. I see it in linux-next through sunxi/sunxi/for-next, but not as
part of a clk-fixes merge.
Arnd
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] clk: sunxi: ccu-sun5i needs nkmp
2017-03-13 16:24 ` Arnd Bergmann
@ 2017-03-20 9:51 ` Maxime Ripard
0 siblings, 0 replies; 4+ messages in thread
From: Maxime Ripard @ 2017-03-20 9:51 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Michael Turquette, Stephen Boyd, Chen-Yu Tsai, Rob Herring,
linux-clk, Linux ARM, Linux Kernel Mailing List
[-- Attachment #1: Type: text/plain, Size: 1155 bytes --]
Hi Arnd,
On Mon, Mar 13, 2017 at 05:24:10PM +0100, Arnd Bergmann wrote:
> On Thu, Feb 16, 2017 at 6:53 PM, Maxime Ripard
> <maxime.ripard@free-electrons.com> wrote:
> > On Tue, Feb 14, 2017 at 10:29:45PM +0100, Arnd Bergmann wrote:
> >> A randconfig build ran into this rare link error:
> >>
> >> drivers/clk/sunxi-ng/ccu-sun5i.o:(.data.__compound_literal.1+0x4): undefined reference to `ccu_nkmp_ops'
> >> drivers/clk/sunxi-ng/ccu-sun5i.o:(.data.__compound_literal.7+0x4): undefined reference to `ccu_nkmp_ops'
> >>
> >> This adds the missing 'select'.
> >>
> >> Fixes: 5e73761786d6 ("clk: sunxi-ng: Add sun5i CCU driver")
> >> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> >
> > Queued as a fix for 4.11, thanks!
>
> I just checked my old patches and this seems to still be required as of
> 4.11-rc2. I see it in linux-next through sunxi/sunxi/for-next, but not as
> part of a clk-fixes merge.
Sorry, I went to holidays without sending the PR. I just did,
hopefully, it should be on Linus' way for the next rc.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-03-20 9:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-14 21:29 [PATCH] clk: sunxi: ccu-sun5i needs nkmp Arnd Bergmann
2017-02-16 17:53 ` Maxime Ripard
2017-03-13 16:24 ` Arnd Bergmann
2017-03-20 9:51 ` Maxime Ripard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox