From: Peter De Schrijver <pdeschrijver@nvidia.com>
To: Jon Hunter <jonathanh@nvidia.com>
Cc: Prashant Gaikwad <pgaikwad@nvidia.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
"Stephen Warren" <swarren@wwwdotorg.org>,
Thierry Reding <thierry.reding@gmail.com>,
Alexandre Courbot <gnurou@gmail.com>, <linux-clk@vger.kernel.org>,
<linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] clk: tegra: mark TEGRA210_CLK_DBGAPB as always on
Date: Mon, 6 Mar 2017 10:38:35 +0200 [thread overview]
Message-ID: <20170306083835.GF26640@tbergstrom-lnx.Nvidia.com> (raw)
In-Reply-To: <4cf40c25-2ce9-737c-9ccb-06bc2cdb61d7@nvidia.com>
On Thu, Mar 02, 2017 at 05:56:49PM +0000, Jon Hunter wrote:
>
> On 28/02/17 15:19, Peter De Schrijver wrote:
> > This is needed to make the JTAG debugging interface work.
> >
> > Signed-off-by: Peter De Schrijver <pdeschrijver@nvidia.com>
> > ---
> > drivers/clk/tegra/clk-tegra210.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/clk/tegra/clk-tegra210.c b/drivers/clk/tegra/clk-tegra210.c
> > index 9a2512a..708f5f1 100644
> > --- a/drivers/clk/tegra/clk-tegra210.c
> > +++ b/drivers/clk/tegra/clk-tegra210.c
> > @@ -2680,6 +2680,7 @@ static void tegra210_cpu_clock_resume(void)
> > { TEGRA210_CLK_EMC, TEGRA210_CLK_CLK_MAX, 0, 1 },
> > { TEGRA210_CLK_MSELECT, TEGRA210_CLK_CLK_MAX, 0, 1 },
> > { TEGRA210_CLK_CSITE, TEGRA210_CLK_CLK_MAX, 0, 1 },
> > + { TEGRA210_CLK_DBGAPB, TEGRA210_CLK_CLK_MAX, 0, 1 },
> > { TEGRA210_CLK_TSENSOR, TEGRA210_CLK_CLK_M, 400000, 0 },
> > { TEGRA210_CLK_I2C1, TEGRA210_CLK_PLL_P, 0, 0 },
> > { TEGRA210_CLK_I2C2, TEGRA210_CLK_PLL_P, 0, 0 },
>
> Should there be some dependency on say CONFIG_DEBUG_KERNEL? I am not
> sure we always want this on for all cases.
Why would you not want it to be always on?
Cheers,
Peter.
next prev parent reply other threads:[~2017-03-06 8:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-28 15:19 [PATCH] clk: tegra: mark TEGRA210_CLK_DBGAPB as always on Peter De Schrijver
2017-03-02 17:56 ` Jon Hunter
2017-03-06 8:38 ` Peter De Schrijver [this message]
2017-03-06 9:58 ` Jon Hunter
2017-03-06 14:28 ` Peter De Schrijver
2017-03-06 15:46 ` Jon Hunter
2017-03-06 15:53 ` Geert Uytterhoeven
2017-03-07 20:27 ` Jon Hunter
2017-03-08 8:23 ` Geert Uytterhoeven
2017-03-08 10:13 ` Jon Hunter
2017-03-08 11:38 ` Geert Uytterhoeven
2017-03-08 11:48 ` Jon Hunter
2017-03-13 10:45 ` Peter De Schrijver
2017-03-13 11:03 ` Jon Hunter
2017-03-13 14:18 ` Peter De Schrijver
2017-03-13 10:47 ` Peter De Schrijver
2017-03-20 14:18 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170306083835.GF26640@tbergstrom-lnx.Nvidia.com \
--to=pdeschrijver@nvidia.com \
--cc=gnurou@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=pgaikwad@nvidia.com \
--cc=sboyd@codeaurora.org \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox