* [PATCH v2 03/15] clk: imx7d: fix mipi dphy div parent [not found] <20180423134750.30403-1-rui.silva@linaro.org> @ 2018-04-23 13:47 ` Rui Miguel Silva 2018-05-01 22:11 ` Stephen Boyd 2018-05-03 1:08 ` Shawn Guo 2018-04-23 13:47 ` [PATCH v2 04/15] clk: imx7d: reset parent for mipi csi root Rui Miguel Silva 1 sibling, 2 replies; 6+ messages in thread From: Rui Miguel Silva @ 2018-04-23 13:47 UTC (permalink / raw) To: mchehab, sakari.ailus, Steve Longerbeam, Philipp Zabel, Rob Herring Cc: linux-media, devel, Shawn Guo, Fabio Estevam, devicetree, Greg Kroah-Hartman, Ryan Harkin, Rui Miguel Silva, linux-clk Fix the mipi dphy root divider to mipi_dphy_pre_div, this would remove a orphan clock and set the correct parent. before: cat clk_orphan_summary enable prepare protect clock count count count rate accuracy phase ---------------------------------------------------------------------------------------- mipi_dphy_post_div 1 1 0 0 0 0 mipi_dphy_root_clk 1 1 0 0 0 0 cat clk_dump | grep mipi_dphy mipi_dphy_post_div 1 1 0 0 0 0 mipi_dphy_root_clk 1 1 0 0 0 0 after: cat clk_dump | grep mipi_dphy mipi_dphy_src 1 1 0 24000000 0 0 mipi_dphy_cg 1 1 0 24000000 0 0 mipi_dphy_pre_div 1 1 0 24000000 0 0 mipi_dphy_post_div 1 1 0 24000000 0 0 mipi_dphy_root_clk 1 1 0 24000000 0 0 Cc: linux-clk@vger.kernel.org Signed-off-by: Rui Miguel Silva <rui.silva@linaro.org> Signed-off-by: Rui Miguel Silva <rui.silva@linaro.org> --- drivers/clk/imx/clk-imx7d.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/imx/clk-imx7d.c b/drivers/clk/imx/clk-imx7d.c index 975a20d3cc94..f7f4db2e6fa6 100644 --- a/drivers/clk/imx/clk-imx7d.c +++ b/drivers/clk/imx/clk-imx7d.c @@ -729,7 +729,7 @@ static void __init imx7d_clocks_init(struct device_node *ccm_node) clks[IMX7D_LCDIF_PIXEL_ROOT_DIV] = imx_clk_divider2("lcdif_pixel_post_div", "lcdif_pixel_pre_div", base + 0xa300, 0, 6); clks[IMX7D_MIPI_DSI_ROOT_DIV] = imx_clk_divider2("mipi_dsi_post_div", "mipi_dsi_pre_div", base + 0xa380, 0, 6); clks[IMX7D_MIPI_CSI_ROOT_DIV] = imx_clk_divider2("mipi_csi_post_div", "mipi_csi_pre_div", base + 0xa400, 0, 6); - clks[IMX7D_MIPI_DPHY_ROOT_DIV] = imx_clk_divider2("mipi_dphy_post_div", "mipi_csi_dphy_div", base + 0xa480, 0, 6); + clks[IMX7D_MIPI_DPHY_ROOT_DIV] = imx_clk_divider2("mipi_dphy_post_div", "mipi_dphy_pre_div", base + 0xa480, 0, 6); clks[IMX7D_SAI1_ROOT_DIV] = imx_clk_divider2("sai1_post_div", "sai1_pre_div", base + 0xa500, 0, 6); clks[IMX7D_SAI2_ROOT_DIV] = imx_clk_divider2("sai2_post_div", "sai2_pre_div", base + 0xa580, 0, 6); clks[IMX7D_SAI3_ROOT_DIV] = imx_clk_divider2("sai3_post_div", "sai3_pre_div", base + 0xa600, 0, 6); -- 2.17.0 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2 03/15] clk: imx7d: fix mipi dphy div parent 2018-04-23 13:47 ` [PATCH v2 03/15] clk: imx7d: fix mipi dphy div parent Rui Miguel Silva @ 2018-05-01 22:11 ` Stephen Boyd 2018-05-03 1:08 ` Shawn Guo 1 sibling, 0 replies; 6+ messages in thread From: Stephen Boyd @ 2018-05-01 22:11 UTC (permalink / raw) To: Philipp Zabel, Rob Herring, Rui Miguel Silva, Steve Longerbeam, mchehab, sakari.ailus Cc: linux-media, devel, Shawn Guo, Fabio Estevam, devicetree, Greg Kroah-Hartman, Ryan Harkin, Rui Miguel Silva, linux-clk Quoting Rui Miguel Silva (2018-04-23 06:47:38) > Fix the mipi dphy root divider to mipi_dphy_pre_div, this would remove a orphan > clock and set the correct parent. > > before: > cat clk_orphan_summary > enable prepare protect > clock count count count rate accuracy phase > ---------------------------------------------------------------------------------------- > mipi_dphy_post_div 1 1 0 0 0 0 > mipi_dphy_root_clk 1 1 0 0 0 0 > > cat clk_dump | grep mipi_dphy > mipi_dphy_post_div 1 1 0 0 0 0 > mipi_dphy_root_clk 1 1 0 0 0 0 > > after: > cat clk_dump | grep mipi_dphy > mipi_dphy_src 1 1 0 24000000 0 0 > mipi_dphy_cg 1 1 0 24000000 0 0 > mipi_dphy_pre_div 1 1 0 24000000 0 0 > mipi_dphy_post_div 1 1 0 24000000 0 0 > mipi_dphy_root_clk 1 1 0 24000000 0 0 > > Cc: linux-clk@vger.kernel.org > Signed-off-by: Rui Miguel Silva <rui.silva@linaro.org> > > Signed-off-by: Rui Miguel Silva <rui.silva@linaro.org> You have double signed-off-by here. Please resend. Also, add a "Fixes:" tag so we know where to backport this to. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 03/15] clk: imx7d: fix mipi dphy div parent 2018-04-23 13:47 ` [PATCH v2 03/15] clk: imx7d: fix mipi dphy div parent Rui Miguel Silva 2018-05-01 22:11 ` Stephen Boyd @ 2018-05-03 1:08 ` Shawn Guo 2018-05-03 1:50 ` A.s. Dong 1 sibling, 1 reply; 6+ messages in thread From: Shawn Guo @ 2018-05-03 1:08 UTC (permalink / raw) To: Rui Miguel Silva, Anson Huang Cc: mchehab, sakari.ailus, Steve Longerbeam, Philipp Zabel, Rob Herring, linux-media, devel, Fabio Estevam, devicetree, Greg Kroah-Hartman, Ryan Harkin, linux-clk, linux-imx Anson, Please have a look at this change. Shawn On Mon, Apr 23, 2018 at 02:47:38PM +0100, Rui Miguel Silva wrote: > Fix the mipi dphy root divider to mipi_dphy_pre_div, this would remove a orphan > clock and set the correct parent. > > before: > cat clk_orphan_summary > enable prepare protect > clock count count count rate accuracy phase > ---------------------------------------------------------------------------------------- > mipi_dphy_post_div 1 1 0 0 0 0 > mipi_dphy_root_clk 1 1 0 0 0 0 > > cat clk_dump | grep mipi_dphy > mipi_dphy_post_div 1 1 0 0 0 0 > mipi_dphy_root_clk 1 1 0 0 0 0 > > after: > cat clk_dump | grep mipi_dphy > mipi_dphy_src 1 1 0 24000000 0 0 > mipi_dphy_cg 1 1 0 24000000 0 0 > mipi_dphy_pre_div 1 1 0 24000000 0 0 > mipi_dphy_post_div 1 1 0 24000000 0 0 > mipi_dphy_root_clk 1 1 0 24000000 0 0 > > Cc: linux-clk@vger.kernel.org > Signed-off-by: Rui Miguel Silva <rui.silva@linaro.org> > > Signed-off-by: Rui Miguel Silva <rui.silva@linaro.org> > --- > drivers/clk/imx/clk-imx7d.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/imx/clk-imx7d.c b/drivers/clk/imx/clk-imx7d.c > index 975a20d3cc94..f7f4db2e6fa6 100644 > --- a/drivers/clk/imx/clk-imx7d.c > +++ b/drivers/clk/imx/clk-imx7d.c > @@ -729,7 +729,7 @@ static void __init imx7d_clocks_init(struct device_node *ccm_node) > clks[IMX7D_LCDIF_PIXEL_ROOT_DIV] = imx_clk_divider2("lcdif_pixel_post_div", "lcdif_pixel_pre_div", base + 0xa300, 0, 6); > clks[IMX7D_MIPI_DSI_ROOT_DIV] = imx_clk_divider2("mipi_dsi_post_div", "mipi_dsi_pre_div", base + 0xa380, 0, 6); > clks[IMX7D_MIPI_CSI_ROOT_DIV] = imx_clk_divider2("mipi_csi_post_div", "mipi_csi_pre_div", base + 0xa400, 0, 6); > - clks[IMX7D_MIPI_DPHY_ROOT_DIV] = imx_clk_divider2("mipi_dphy_post_div", "mipi_csi_dphy_div", base + 0xa480, 0, 6); > + clks[IMX7D_MIPI_DPHY_ROOT_DIV] = imx_clk_divider2("mipi_dphy_post_div", "mipi_dphy_pre_div", base + 0xa480, 0, 6); > clks[IMX7D_SAI1_ROOT_DIV] = imx_clk_divider2("sai1_post_div", "sai1_pre_div", base + 0xa500, 0, 6); > clks[IMX7D_SAI2_ROOT_DIV] = imx_clk_divider2("sai2_post_div", "sai2_pre_div", base + 0xa580, 0, 6); > clks[IMX7D_SAI3_ROOT_DIV] = imx_clk_divider2("sai3_post_div", "sai3_pre_div", base + 0xa600, 0, 6); > -- > 2.17.0 > ^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH v2 03/15] clk: imx7d: fix mipi dphy div parent 2018-05-03 1:08 ` Shawn Guo @ 2018-05-03 1:50 ` A.s. Dong 0 siblings, 0 replies; 6+ messages in thread From: A.s. Dong @ 2018-05-03 1:50 UTC (permalink / raw) To: Shawn Guo, Rui Miguel Silva, Anson Huang Cc: mchehab@kernel.org, sakari.ailus@linux.intel.com, Steve Longerbeam, Philipp Zabel, Rob Herring, linux-media@vger.kernel.org, devel@driverdev.osuosl.org, Fabio Estevam, devicetree@vger.kernel.org, Greg Kroah-Hartman, Ryan Harkin, linux-clk@vger.kernel.org, dl-linux-imx > -----Original Message----- > From: Shawn Guo [mailto:shawnguo@kernel.org] > Sent: Thursday, May 3, 2018 9:08 AM > To: Rui Miguel Silva <rui.silva@linaro.org>; Anson Huang > <anson.huang@nxp.com> > Cc: mchehab@kernel.org; sakari.ailus@linux.intel.com; Steve Longerbeam > <slongerbeam@gmail.com>; Philipp Zabel <p.zabel@pengutronix.de>; Rob > Herring <robh+dt@kernel.org>; linux-media@vger.kernel.org; > devel@driverdev.osuosl.org; Fabio Estevam <fabio.estevam@nxp.com>; > devicetree@vger.kernel.org; Greg Kroah-Hartman > <gregkh@linuxfoundation.org>; Ryan Harkin <ryan.harkin@linaro.org>; > linux-clk@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com> > Subject: Re: [PATCH v2 03/15] clk: imx7d: fix mipi dphy div parent >=20 > Anson, >=20 > Please have a look at this change. >=20 > Shawn >=20 > On Mon, Apr 23, 2018 at 02:47:38PM +0100, Rui Miguel Silva wrote: > > Fix the mipi dphy root divider to mipi_dphy_pre_div, this would remove > > a orphan clock and set the correct parent. > > > > before: > > cat clk_orphan_summary > > enable prepare protect > > clock count count count rate = accuracy phase > > -----------------------------------------------------------------------= ----------------- > > mipi_dphy_post_div 1 1 0 0 = 0 0 > > mipi_dphy_root_clk 1 1 0 0 = 0 0 > > > > cat clk_dump | grep mipi_dphy > > mipi_dphy_post_div 1 1 0 0 = 0 0 > > mipi_dphy_root_clk 1 1 0 0 = 0 0 > > > > after: > > cat clk_dump | grep mipi_dphy > > mipi_dphy_src 1 1 0 24000000 = 0 0 > > mipi_dphy_cg 1 1 0 24000000 = 0 0 > > mipi_dphy_pre_div 1 1 0 24000000 = 0 0 > > mipi_dphy_post_div 1 1 0 24000000 = 0 0 > > mipi_dphy_root_clk 1 1 0 24000000 = 0 0 > > > > Cc: linux-clk@vger.kernel.org > > Signed-off-by: Rui Miguel Silva <rui.silva@linaro.org> > > > > Signed-off-by: Rui Miguel Silva <rui.silva@linaro.org> Two sign-off? Otherwise, the patch looks ok to me. Acked-by: Dong Aisheng <Aisheng.dong@nxp.com> Regards Dong Aisheng > > --- > > drivers/clk/imx/clk-imx7d.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/clk/imx/clk-imx7d.c b/drivers/clk/imx/clk-imx7d.c > > index 975a20d3cc94..f7f4db2e6fa6 100644 > > --- a/drivers/clk/imx/clk-imx7d.c > > +++ b/drivers/clk/imx/clk-imx7d.c > > @@ -729,7 +729,7 @@ static void __init imx7d_clocks_init(struct > device_node *ccm_node) > > clks[IMX7D_LCDIF_PIXEL_ROOT_DIV] =3D > imx_clk_divider2("lcdif_pixel_post_div", "lcdif_pixel_pre_div", base + > 0xa300, 0, 6); > > clks[IMX7D_MIPI_DSI_ROOT_DIV] =3D > imx_clk_divider2("mipi_dsi_post_div", "mipi_dsi_pre_div", base + 0xa380, = 0, > 6); > > clks[IMX7D_MIPI_CSI_ROOT_DIV] =3D > imx_clk_divider2("mipi_csi_post_div", "mipi_csi_pre_div", base + 0xa400, = 0, > 6); > > - clks[IMX7D_MIPI_DPHY_ROOT_DIV] =3D > imx_clk_divider2("mipi_dphy_post_div", "mipi_csi_dphy_div", base + > 0xa480, 0, 6); > > + clks[IMX7D_MIPI_DPHY_ROOT_DIV] =3D > > +imx_clk_divider2("mipi_dphy_post_div", "mipi_dphy_pre_div", base + > > +0xa480, 0, 6); > > clks[IMX7D_SAI1_ROOT_DIV] =3D imx_clk_divider2("sai1_post_div", > "sai1_pre_div", base + 0xa500, 0, 6); > > clks[IMX7D_SAI2_ROOT_DIV] =3D imx_clk_divider2("sai2_post_div", > "sai2_pre_div", base + 0xa580, 0, 6); > > clks[IMX7D_SAI3_ROOT_DIV] =3D imx_clk_divider2("sai3_post_div", > > "sai3_pre_div", base + 0xa600, 0, 6); > > -- > > 2.17.0 > > ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2 04/15] clk: imx7d: reset parent for mipi csi root [not found] <20180423134750.30403-1-rui.silva@linaro.org> 2018-04-23 13:47 ` [PATCH v2 03/15] clk: imx7d: fix mipi dphy div parent Rui Miguel Silva @ 2018-04-23 13:47 ` Rui Miguel Silva 2018-05-03 2:27 ` Shawn Guo 1 sibling, 1 reply; 6+ messages in thread From: Rui Miguel Silva @ 2018-04-23 13:47 UTC (permalink / raw) To: mchehab, sakari.ailus, Steve Longerbeam, Philipp Zabel, Rob Herring Cc: linux-media, devel, Shawn Guo, Fabio Estevam, devicetree, Greg Kroah-Hartman, Ryan Harkin, Rui Miguel Silva, linux-clk To guarantee that we do not get Overflow in image FIFO the outer bandwidth has to be faster than inputer bandwidth. For that it must be possible to set a faster frequency clock. So set new parent to sys_pfd3 clock for the mipi csi block. Cc: linux-clk@vger.kernel.org Signed-off-by: Rui Miguel Silva <rui.silva@linaro.org> --- drivers/clk/imx/clk-imx7d.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/clk/imx/clk-imx7d.c b/drivers/clk/imx/clk-imx7d.c index f7f4db2e6fa6..9a1a18ceb132 100644 --- a/drivers/clk/imx/clk-imx7d.c +++ b/drivers/clk/imx/clk-imx7d.c @@ -891,6 +891,9 @@ static void __init imx7d_clocks_init(struct device_node *ccm_node) clk_set_parent(clks[IMX7D_PLL_AUDIO_MAIN_BYPASS], clks[IMX7D_PLL_AUDIO_MAIN]); clk_set_parent(clks[IMX7D_PLL_VIDEO_MAIN_BYPASS], clks[IMX7D_PLL_VIDEO_MAIN]); + clk_set_parent(clks[IMX7D_MIPI_CSI_ROOT_SRC], + clks[IMX7D_PLL_SYS_PFD3_CLK]); + /* use old gpt clk setting, gpt1 root clk must be twice as gpt counter freq */ clk_set_parent(clks[IMX7D_GPT1_ROOT_SRC], clks[IMX7D_OSC_24M_CLK]); -- 2.17.0 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2 04/15] clk: imx7d: reset parent for mipi csi root 2018-04-23 13:47 ` [PATCH v2 04/15] clk: imx7d: reset parent for mipi csi root Rui Miguel Silva @ 2018-05-03 2:27 ` Shawn Guo 0 siblings, 0 replies; 6+ messages in thread From: Shawn Guo @ 2018-05-03 2:27 UTC (permalink / raw) To: Rui Miguel Silva Cc: mchehab, sakari.ailus, Steve Longerbeam, Philipp Zabel, Rob Herring, linux-media, devel, Fabio Estevam, devicetree, Greg Kroah-Hartman, Ryan Harkin, linux-clk On Mon, Apr 23, 2018 at 02:47:39PM +0100, Rui Miguel Silva wrote: > To guarantee that we do not get Overflow in image FIFO the outer bandwidth has > to be faster than inputer bandwidth. For that it must be possible to set a > faster frequency clock. So set new parent to sys_pfd3 clock for the mipi csi > block. > > Cc: linux-clk@vger.kernel.org > Signed-off-by: Rui Miguel Silva <rui.silva@linaro.org> > --- > drivers/clk/imx/clk-imx7d.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/clk/imx/clk-imx7d.c b/drivers/clk/imx/clk-imx7d.c > index f7f4db2e6fa6..9a1a18ceb132 100644 > --- a/drivers/clk/imx/clk-imx7d.c > +++ b/drivers/clk/imx/clk-imx7d.c > @@ -891,6 +891,9 @@ static void __init imx7d_clocks_init(struct device_node *ccm_node) > clk_set_parent(clks[IMX7D_PLL_AUDIO_MAIN_BYPASS], clks[IMX7D_PLL_AUDIO_MAIN]); > clk_set_parent(clks[IMX7D_PLL_VIDEO_MAIN_BYPASS], clks[IMX7D_PLL_VIDEO_MAIN]); > > + clk_set_parent(clks[IMX7D_MIPI_CSI_ROOT_SRC], > + clks[IMX7D_PLL_SYS_PFD3_CLK]); > + For i.MX clock driver, we intentionally ignore line over 80 columns warning to make the file easier for read. So I would suggest you keep it on a single line to stay consistent with other clk_set_parent() calls. Other than that, Acked-by: Shawn Guo <shawnguo@kernel.org> > /* use old gpt clk setting, gpt1 root clk must be twice as gpt counter freq */ > clk_set_parent(clks[IMX7D_GPT1_ROOT_SRC], clks[IMX7D_OSC_24M_CLK]); > > -- > 2.17.0 > ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-05-03 2:27 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20180423134750.30403-1-rui.silva@linaro.org>
2018-04-23 13:47 ` [PATCH v2 03/15] clk: imx7d: fix mipi dphy div parent Rui Miguel Silva
2018-05-01 22:11 ` Stephen Boyd
2018-05-03 1:08 ` Shawn Guo
2018-05-03 1:50 ` A.s. Dong
2018-04-23 13:47 ` [PATCH v2 04/15] clk: imx7d: reset parent for mipi csi root Rui Miguel Silva
2018-05-03 2:27 ` Shawn Guo
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox