[PATCH] clk: zynqmp: enable COMMON_CLK_ZYNQMP for ARCH_ZYNQMP automatically

[PATCH] clk: zynqmp: enable COMMON_CLK_ZYNQMP for ARCH_ZYNQMP automatically

[quanyang.wang]

From: Quanyang Wang <quanyang.wang@windriver.com>

The Zynqmp Ultrascale clock controller generates clocks for peripherals,
so we need to enable it when ARCH_ZYNQMP is selected.

Signed-off-by: Quanyang Wang <quanyang.wang@windriver.com>
---
 drivers/clk/zynqmp/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/zynqmp/Kconfig b/drivers/clk/zynqmp/Kconfig
index 17086059be8b..a8aa58bbb790 100644
--- a/drivers/clk/zynqmp/Kconfig
+++ b/drivers/clk/zynqmp/Kconfig
@@ -4,6 +4,7 @@ config COMMON_CLK_ZYNQMP
 	bool "Support for Xilinx ZynqMP Ultrascale+ clock controllers"
 	depends on ARCH_ZYNQMP || COMPILE_TEST
 	depends on ZYNQMP_FIRMWARE
+	default ARCH_ZYNQMP
 	help
 	  Support for the Zynqmp Ultrascale clock controller.
 	  It has a dependency on the PMU firmware.
-- 
2.25.1

Re: [PATCH] clk: zynqmp: enable COMMON_CLK_ZYNQMP for ARCH_ZYNQMP automatically

[Michal Simek]

Hi,

On 08. 12. 20 13:35, quanyang.wang@windriver.com wrote:
> From: Quanyang Wang <quanyang.wang@windriver.com>
> 
> The Zynqmp Ultrascale clock controller generates clocks for peripherals,
> so we need to enable it when ARCH_ZYNQMP is selected.
> 
> Signed-off-by: Quanyang Wang <quanyang.wang@windriver.com>
> ---
>  drivers/clk/zynqmp/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clk/zynqmp/Kconfig b/drivers/clk/zynqmp/Kconfig
> index 17086059be8b..a8aa58bbb790 100644
> --- a/drivers/clk/zynqmp/Kconfig
> +++ b/drivers/clk/zynqmp/Kconfig
> @@ -4,6 +4,7 @@ config COMMON_CLK_ZYNQMP
>  	bool "Support for Xilinx ZynqMP Ultrascale+ clock controllers"
>  	depends on ARCH_ZYNQMP || COMPILE_TEST
>  	depends on ZYNQMP_FIRMWARE
> +	default ARCH_ZYNQMP

This is not right. If you look 2 lines above.

>  	help
>  	  Support for the Zynqmp Ultrascale clock controller.
>  	  It has a dependency on the PMU firmware.
> 

And we were talking about enabling this driver in defconfig. Not via
Kconfig. This fragment was designed in a way that this clock controller
doesn't need to be used. It is our default but if you want to use for
example fixed clock you also can.
This enables space for being able to use for example different firmware.

Thanks,
Michal

Re: [PATCH] clk: zynqmp: enable COMMON_CLK_ZYNQMP for ARCH_ZYNQMP automatically

[quanyang.wang]

Hi Michal,

On 12/8/20 8:42 PM, Michal Simek wrote:
> Hi,
>
> On 08. 12. 20 13:35, quanyang.wang@windriver.com wrote:
>> From: Quanyang Wang <quanyang.wang@windriver.com>
>>
>> The Zynqmp Ultrascale clock controller generates clocks for peripherals,
>> so we need to enable it when ARCH_ZYNQMP is selected.
>>
>> Signed-off-by: Quanyang Wang <quanyang.wang@windriver.com>
>> ---
>>   drivers/clk/zynqmp/Kconfig | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/clk/zynqmp/Kconfig b/drivers/clk/zynqmp/Kconfig
>> index 17086059be8b..a8aa58bbb790 100644
>> --- a/drivers/clk/zynqmp/Kconfig
>> +++ b/drivers/clk/zynqmp/Kconfig
>> @@ -4,6 +4,7 @@ config COMMON_CLK_ZYNQMP
>>   	bool "Support for Xilinx ZynqMP Ultrascale+ clock controllers"
>>   	depends on ARCH_ZYNQMP || COMPILE_TEST
>>   	depends on ZYNQMP_FIRMWARE
>> +	default ARCH_ZYNQMP
> This is not right. If you look 2 lines above.
>
>>   	help
>>   	  Support for the Zynqmp Ultrascale clock controller.
>>   	  It has a dependency on the PMU firmware.
>>
> And we were talking about enabling this driver in defconfig. Not via
> Kconfig. This fragment was designed in a way that this clock controller
> doesn't need to be used. It is our default but if you want to use for
> example fixed clock you also can.
> This enables space for being able to use for example different firmware.

Thanks for your reply. I will enable this driver in defconfig.

Best Regards

Quanyang

>
> Thanks,
> Michal