From: Maxime Ripard <maxime@cerno.tech>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
Maxime Ripard <maxime@cerno.tech>,
Mike Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
linux-clk@vger.kernel.org, dri-devel@lists.freedesktop.org
Cc: Phil Elwell <phil@raspberrypi.com>,
Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
Tim Gover <tim.gover@raspberrypi.com>,
bcm-kernel-feedback-list@broadcom.com,
linux-rpi-kernel@lists.infradead.org,
Dave Stevenson <dave.stevenson@raspberrypi.com>,
Daniel Vetter <daniel.vetter@intel.com>,
David Airlie <airlied@linux.ie>
Subject: [PATCH 2/8] drm/vc4: hvs: Make the HVS bind first
Date: Thu, 25 Feb 2021 16:59:03 +0100 [thread overview]
Message-ID: <20210225155909.1853812-3-maxime@cerno.tech> (raw)
In-Reply-To: <20210225155909.1853812-1-maxime@cerno.tech>
We'll need to have the HVS binding before the HDMI controllers so that
we can check whether the firmware allows to run in 4kp60. Reorder a bit
the component list, and document the current constraints we're aware of.
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
---
drivers/gpu/drm/vc4/vc4_drv.c | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c
index 556ad0f02a0d..0310590ee66e 100644
--- a/drivers/gpu/drm/vc4/vc4_drv.c
+++ b/drivers/gpu/drm/vc4/vc4_drv.c
@@ -303,12 +303,21 @@ static const struct component_master_ops vc4_drm_ops = {
.unbind = vc4_drm_unbind,
};
+/*
+ * This list determines the binding order of our components, and we have
+ * a few constraints:
+ * - The TXP driver needs to be bound before the PixelValves (CRTC)
+ * but after the HVS to set the possible_crtc field properly
+ * - The HDMI driver needs to be bound after the HVS so that we can
+ * lookup the HVS maximum core clock rate and figure out if we
+ * support 4kp60 or not.
+ */
static struct platform_driver *const component_drivers[] = {
+ &vc4_hvs_driver,
&vc4_hdmi_driver,
&vc4_vec_driver,
&vc4_dpi_driver,
&vc4_dsi_driver,
- &vc4_hvs_driver,
&vc4_txp_driver,
&vc4_crtc_driver,
&vc4_v3d_driver,
--
2.29.2
next prev parent reply other threads:[~2021-02-25 16:00 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-25 15:59 [PATCH 0/8] drm/vc4: hdmi: Support the 4k @ 60Hz modes Maxime Ripard
2021-02-25 15:59 ` [PATCH 1/8] clk: Add range accessors Maxime Ripard
2021-03-02 23:18 ` Stephen Boyd
2021-03-03 8:45 ` Maxime Ripard
2021-03-17 1:06 ` Stephen Boyd
2021-03-17 13:04 ` Maxime Ripard
2021-02-25 15:59 ` Maxime Ripard [this message]
2021-02-25 16:51 ` [PATCH 2/8] drm/vc4: hvs: Make the HVS bind first Dave Stevenson
2021-02-25 15:59 ` [PATCH 3/8] drm/vc4: hdmi: Properly compute the BVB clock rate Maxime Ripard
2021-02-25 16:44 ` Dave Stevenson
2021-02-25 17:15 ` Dave Stevenson
2021-02-25 15:59 ` [PATCH 4/8] drm/vc4: hdmi: Check and warn if we can't reach 4kp60 frequencies Maxime Ripard
2021-02-25 16:38 ` Dave Stevenson
2021-03-02 13:01 ` Maxime Ripard
2021-03-02 15:10 ` Dave Stevenson
2021-02-25 15:59 ` [PATCH 5/8] drm/vc4: hdmi: Enable the scrambler Maxime Ripard
2021-02-25 16:33 ` Dave Stevenson
2021-02-25 15:59 ` [PATCH 6/8] drm/vc4: hdmi: Raise the maximum clock rate Maxime Ripard
2021-02-25 16:45 ` Dave Stevenson
2021-02-25 15:59 ` [PATCH 7/8] drm/vc4: plane: Fix typo in scaler width and height Maxime Ripard
2021-02-25 16:50 ` Dave Stevenson
2021-02-25 15:59 ` [PATCH 8/8] drm/vc4: plane: Remove redundant assignment Maxime Ripard
2021-02-25 16:46 ` Dave Stevenson
2021-03-02 13:57 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210225155909.1853812-3-maxime@cerno.tech \
--to=maxime@cerno.tech \
--cc=airlied@linux.ie \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=daniel.vetter@intel.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mturquette@baylibre.com \
--cc=nsaenzjulienne@suse.de \
--cc=phil@raspberrypi.com \
--cc=sboyd@kernel.org \
--cc=tim.gover@raspberrypi.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox