[PATCH 1/2] clk: lmk04832: Depend on SPI

[PATCH 1/2] clk: lmk04832: Depend on SPI

[Stephen Boyd]

This driver depends on SPI. Otherwise compilation fails

  clk-lmk04832.c:(.text+0x1668): undefined reference to `spi_get_device_id'

Reported-by: kernel test robot <lkp@intel.com>
Cc: Liam Beguin <lvb@xiphos.com>
Fixes: 3bc61cfd6f4a ("clk: add support for the lmk04832")
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
---
 drivers/clk/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
index ccf77849bdbd..d49cf3ae52aa 100644
--- a/drivers/clk/Kconfig
+++ b/drivers/clk/Kconfig
@@ -57,6 +57,7 @@ config CLK_HSDK
 
 config LMK04832
 	tristate "Ti LMK04832 JESD204B Compliant Clock Jitter Cleaner"
+	depends on SPI
 	select REGMAP_SPI
 	help
 	  Say yes here to build support for Texas Instruments' LMK04832 Ultra
-- 
https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/
https://git.kernel.org/pub/scm/linux/kernel/git/sboyd/spmi.git

[PATCH 2/2] clk: lmk04832: Use of match table

[Stephen Boyd]

Presumably we want to use this match table so add a module device table
and set the driver match pointer appropriately.

Reported-by: kernel test robot <lkp@intel.com>
Cc: Liam Beguin <lvb@xiphos.com>
Fixes: 3bc61cfd6f4a ("clk: add support for the lmk04832")
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
---
 drivers/clk/clk-lmk04832.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/clk-lmk04832.c b/drivers/clk/clk-lmk04832.c
index 0cd76e626c3d..c1095e733220 100644
--- a/drivers/clk/clk-lmk04832.c
+++ b/drivers/clk/clk-lmk04832.c
@@ -1573,18 +1573,20 @@ static int lmk04832_remove(struct spi_device *spi)
 }
 static const struct spi_device_id lmk04832_id[] = {
 	{ "lmk04832", LMK04832 },
-	{},
+	{}
 };
 MODULE_DEVICE_TABLE(spi, lmk04832_id);
 
 static const struct of_device_id lmk04832_of_id[] = {
 	{ .compatible = "ti,lmk04832" },
-	{},
+	{}
 };
+MODULE_DEVICE_TABLE(of, lmk04832_of_id);
 
 static struct spi_driver lmk04832_driver = {
 	.driver = {
 		.name	= "lmk04832",
+		.of_match_table = lmk04832_of_id,
 	},
 	.probe		= lmk04832_probe,
 	.remove		= lmk04832_remove,
-- 
https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/
https://git.kernel.org/pub/scm/linux/kernel/git/sboyd/spmi.git

RE: [PATCH 2/2] clk: lmk04832: Use of match table

[Liam Beguin]

> -----Original Message-----
> From: Stephen Boyd <sboyd@kernel.org>
> Sent: June 29, 2021 2:08 AM
> To: Michael Turquette <mturquette@baylibre.com>; Stephen Boyd
> <sboyd@kernel.org>
> Cc: linux-kernel@vger.kernel.org; linux-clk@vger.kernel.org; kernel test
> robot <lkp@intel.com>; Liam Beguin <lvb@xiphos.com>
> Subject: [PATCH 2/2] clk: lmk04832: Use of match table
> 
> Presumably we want to use this match table so add a module device table
> and set the driver match pointer appropriately.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Cc: Liam Beguin <lvb@xiphos.com>
> Fixes: 3bc61cfd6f4a ("clk: add support for the lmk04832")
> Signed-off-by: Stephen Boyd <sboyd@kernel.org>

Reviewed-by: Liam Beguin <lvb@xiphos.com>

> ---
>  drivers/clk/clk-lmk04832.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/clk/clk-lmk04832.c b/drivers/clk/clk-lmk04832.c
> index 0cd76e626c3d..c1095e733220 100644
> --- a/drivers/clk/clk-lmk04832.c
> +++ b/drivers/clk/clk-lmk04832.c
> @@ -1573,18 +1573,20 @@ static int lmk04832_remove(struct spi_device
> *spi)
>  }
>  static const struct spi_device_id lmk04832_id[] = {
>  	{ "lmk04832", LMK04832 },
> -	{},
> +	{}
>  };
>  MODULE_DEVICE_TABLE(spi, lmk04832_id);
> 
>  static const struct of_device_id lmk04832_of_id[] = {
>  	{ .compatible = "ti,lmk04832" },
> -	{},
> +	{}
>  };
> +MODULE_DEVICE_TABLE(of, lmk04832_of_id);
> 
>  static struct spi_driver lmk04832_driver = {
>  	.driver = {
>  		.name	= "lmk04832",
> +		.of_match_table = lmk04832_of_id,
>  	},
>  	.probe		= lmk04832_probe,
>  	.remove		= lmk04832_remove,
> --
> https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/
> https://git.kernel.org/pub/scm/linux/kernel/git/sboyd/spmi.git

RE: [PATCH 1/2] clk: lmk04832: Depend on SPI

[Liam Beguin]

> -----Original Message-----
> From: Stephen Boyd <sboyd@kernel.org>
> Sent: June 29, 2021 2:08 AM
> To: Michael Turquette <mturquette@baylibre.com>; Stephen Boyd
> <sboyd@kernel.org>
> Cc: linux-kernel@vger.kernel.org; linux-clk@vger.kernel.org; kernel test
> robot <lkp@intel.com>; Liam Beguin <lvb@xiphos.com>
> Subject: [PATCH 1/2] clk: lmk04832: Depend on SPI
> 
> This driver depends on SPI. Otherwise compilation fails
> 
>   clk-lmk04832.c:(.text+0x1668): undefined reference to `spi_get_device_id'
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Cc: Liam Beguin <lvb@xiphos.com>
> Fixes: 3bc61cfd6f4a ("clk: add support for the lmk04832")
> Signed-off-by: Stephen Boyd <sboyd@kernel.org>

Reviewed-by: Liam Beguin <lvb@xiphos.com>

> ---
>  drivers/clk/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
> index ccf77849bdbd..d49cf3ae52aa 100644
> --- a/drivers/clk/Kconfig
> +++ b/drivers/clk/Kconfig
> @@ -57,6 +57,7 @@ config CLK_HSDK
> 
>  config LMK04832
>  	tristate "Ti LMK04832 JESD204B Compliant Clock Jitter Cleaner"
> +	depends on SPI
>  	select REGMAP_SPI
>  	help
>  	  Say yes here to build support for Texas Instruments' LMK04832
> Ultra
> --
> https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/
> https://git.kernel.org/pub/scm/linux/kernel/git/sboyd/spmi.git