* [PATCH v1 2/2] clk: qcom: sc7280: Update clk_init_data to const for clock controllers [not found] <20220202182053.22925-1-tdas@codeaurora.org> @ 2022-02-02 18:20 ` Taniya Das 2022-02-02 22:34 ` Dmitry Baryshkov 0 siblings, 1 reply; 3+ messages in thread From: Taniya Das @ 2022-02-02 18:20 UTC (permalink / raw) To: Stephen Boyd, Michael Turquette Cc: Rajendra Nayak, linux-arm-msm, linux-soc, linux-clk, linux-kernel, Taniya Das Update clk_init_data to const and also use index instead of fw_name for graphics, lpasscc and video clock controller. Fixes: 3e0f01d6c7e74 ("clk: qcom: Add graphics clock controller driver for SC7280") Fixes: 4ab43d171181d ("clk: qcom: Add lpass clock controller driver for SC7280") Fixes: fae7617bb1428 ("clk: qcom: Add video clock controller driver for SC7280") Signed-off-by: Taniya Das <tdas@codeaurora.org> --- drivers/clk/qcom/gpucc-sc7280.c | 56 +++++++++++++++---------------- drivers/clk/qcom/lpasscc-sc7280.c | 14 ++++---- drivers/clk/qcom/videocc-sc7280.c | 26 +++++++------- 3 files changed, 48 insertions(+), 48 deletions(-) diff --git a/drivers/clk/qcom/gpucc-sc7280.c b/drivers/clk/qcom/gpucc-sc7280.c index 9a832f2bcf49..e8f6abc5261f 100644 --- a/drivers/clk/qcom/gpucc-sc7280.c +++ b/drivers/clk/qcom/gpucc-sc7280.c @@ -1,6 +1,6 @@ // SPDX-License-Identifier: GPL-2.0-only /* - * Copyright (c) 2021, The Linux Foundation. All rights reserved. + * Copyright (c) 2021-2022, The Linux Foundation. All rights reserved. */ #include <linux/clk-provider.h> @@ -36,10 +36,10 @@ static struct clk_alpha_pll gpu_cc_pll0 = { .num_vco = ARRAY_SIZE(lucid_vco), .regs = clk_alpha_pll_regs[CLK_ALPHA_PLL_TYPE_LUCID], .clkr = { - .hw.init = &(struct clk_init_data){ + .hw.init = &(const struct clk_init_data){ .name = "gpu_cc_pll0", .parent_data = &(const struct clk_parent_data){ - .fw_name = "bi_tcxo", + .index = 0, }, .num_parents = 1, .ops = &clk_alpha_pll_lucid_ops, @@ -65,10 +65,10 @@ static struct clk_alpha_pll gpu_cc_pll1 = { .num_vco = ARRAY_SIZE(lucid_vco), .regs = clk_alpha_pll_regs[CLK_ALPHA_PLL_TYPE_LUCID], .clkr = { - .hw.init = &(struct clk_init_data){ + .hw.init = &(const struct clk_init_data){ .name = "gpu_cc_pll1", .parent_data = &(const struct clk_parent_data){ - .fw_name = "bi_tcxo", + .index = 0, }, .num_parents = 1, .ops = &clk_alpha_pll_lucid_ops, @@ -85,11 +85,11 @@ static const struct parent_map gpu_cc_parent_map_0[] = { }; static const struct clk_parent_data gpu_cc_parent_data_0[] = { - { .fw_name = "bi_tcxo" }, + { .index = 0 }, { .hw = &gpu_cc_pll0.clkr.hw }, { .hw = &gpu_cc_pll1.clkr.hw }, - { .fw_name = "gcc_gpu_gpll0_clk_src" }, - { .fw_name = "gcc_gpu_gpll0_div_clk_src" }, + { .index = 1 }, /* gcc_gpu_gpll0_clk_src */ + { .index = 2 }, /* gcc_gpu_gpll0_div_clk_src */ }; static const struct parent_map gpu_cc_parent_map_1[] = { @@ -100,10 +100,10 @@ static const struct parent_map gpu_cc_parent_map_1[] = { }; static const struct clk_parent_data gpu_cc_parent_data_1[] = { - { .fw_name = "bi_tcxo", }, + { .index = 0, }, { .hw = &gpu_cc_pll1.clkr.hw }, - { .fw_name = "gcc_gpu_gpll0_clk_src", }, - { .fw_name = "gcc_gpu_gpll0_div_clk_src", }, + { .index = 1 }, /* gcc_gpu_gpll0_clk_src */ + { .index = 2 }, /* gcc_gpu_gpll0_div_clk_src */ }; static const struct freq_tbl ftbl_gpu_cc_gmu_clk_src[] = { @@ -119,7 +119,7 @@ static struct clk_rcg2 gpu_cc_gmu_clk_src = { .hid_width = 5, .parent_map = gpu_cc_parent_map_0, .freq_tbl = ftbl_gpu_cc_gmu_clk_src, - .clkr.hw.init = &(struct clk_init_data){ + .clkr.hw.init = &(const struct clk_init_data){ .name = "gpu_cc_gmu_clk_src", .parent_data = gpu_cc_parent_data_0, .num_parents = ARRAY_SIZE(gpu_cc_parent_data_0), @@ -140,7 +140,7 @@ static struct clk_rcg2 gpu_cc_hub_clk_src = { .hid_width = 5, .parent_map = gpu_cc_parent_map_1, .freq_tbl = ftbl_gpu_cc_hub_clk_src, - .clkr.hw.init = &(struct clk_init_data){ + .clkr.hw.init = &(const struct clk_init_data){ .name = "gpu_cc_hub_clk_src", .parent_data = gpu_cc_parent_data_1, .num_parents = ARRAY_SIZE(gpu_cc_parent_data_1), @@ -152,7 +152,7 @@ static struct clk_regmap_div gpu_cc_hub_ahb_div_clk_src = { .reg = 0x11c0, .shift = 0, .width = 4, - .clkr.hw.init = &(struct clk_init_data) { + .clkr.hw.init = &(const struct clk_init_data) { .name = "gpu_cc_hub_ahb_div_clk_src", .parent_hws = (const struct clk_hw*[]){ &gpu_cc_hub_clk_src.clkr.hw, @@ -167,7 +167,7 @@ static struct clk_regmap_div gpu_cc_hub_cx_int_div_clk_src = { .reg = 0x11bc, .shift = 0, .width = 4, - .clkr.hw.init = &(struct clk_init_data) { + .clkr.hw.init = &(const struct clk_init_data) { .name = "gpu_cc_hub_cx_int_div_clk_src", .parent_hws = (const struct clk_hw*[]){ &gpu_cc_hub_clk_src.clkr.hw, @@ -184,7 +184,7 @@ static struct clk_branch gpu_cc_ahb_clk = { .clkr = { .enable_reg = 0x1078, .enable_mask = BIT(0), - .hw.init = &(struct clk_init_data){ + .hw.init = &(const struct clk_init_data){ .name = "gpu_cc_ahb_clk", .parent_hws = (const struct clk_hw*[]){ &gpu_cc_hub_ahb_div_clk_src.clkr.hw, @@ -202,7 +202,7 @@ static struct clk_branch gpu_cc_crc_ahb_clk = { .clkr = { .enable_reg = 0x107c, .enable_mask = BIT(0), - .hw.init = &(struct clk_init_data){ + .hw.init = &(const struct clk_init_data){ .name = "gpu_cc_crc_ahb_clk", .parent_hws = (const struct clk_hw*[]){ &gpu_cc_hub_ahb_div_clk_src.clkr.hw, @@ -220,7 +220,7 @@ static struct clk_branch gpu_cc_cx_gmu_clk = { .clkr = { .enable_reg = 0x1098, .enable_mask = BIT(0), - .hw.init = &(struct clk_init_data){ + .hw.init = &(const struct clk_init_data){ .name = "gpu_cc_cx_gmu_clk", .parent_hws = (const struct clk_hw*[]){ &gpu_cc_gmu_clk_src.clkr.hw, @@ -238,7 +238,7 @@ static struct clk_branch gpu_cc_cx_snoc_dvm_clk = { .clkr = { .enable_reg = 0x108c, .enable_mask = BIT(0), - .hw.init = &(struct clk_init_data){ + .hw.init = &(const struct clk_init_data){ .name = "gpu_cc_cx_snoc_dvm_clk", .ops = &clk_branch2_ops, }, @@ -251,7 +251,7 @@ static struct clk_branch gpu_cc_cxo_aon_clk = { .clkr = { .enable_reg = 0x1004, .enable_mask = BIT(0), - .hw.init = &(struct clk_init_data){ + .hw.init = &(const struct clk_init_data){ .name = "gpu_cc_cxo_aon_clk", .ops = &clk_branch2_ops, }, @@ -264,7 +264,7 @@ static struct clk_branch gpu_cc_cxo_clk = { .clkr = { .enable_reg = 0x109c, .enable_mask = BIT(0), - .hw.init = &(struct clk_init_data){ + .hw.init = &(const struct clk_init_data){ .name = "gpu_cc_cxo_clk", .ops = &clk_branch2_aon_ops, }, @@ -277,7 +277,7 @@ static struct clk_branch gpu_cc_gx_gmu_clk = { .clkr = { .enable_reg = 0x1064, .enable_mask = BIT(0), - .hw.init = &(struct clk_init_data){ + .hw.init = &(const struct clk_init_data){ .name = "gpu_cc_gx_gmu_clk", .parent_hws = (const struct clk_hw*[]){ &gpu_cc_gmu_clk_src.clkr.hw, @@ -295,7 +295,7 @@ static struct clk_branch gpu_cc_hlos1_vote_gpu_smmu_clk = { .clkr = { .enable_reg = 0x5000, .enable_mask = BIT(0), - .hw.init = &(struct clk_init_data){ + .hw.init = &(const struct clk_init_data){ .name = "gpu_cc_hlos1_vote_gpu_smmu_clk", .ops = &clk_branch2_ops, }, @@ -308,7 +308,7 @@ static struct clk_branch gpu_cc_hub_aon_clk = { .clkr = { .enable_reg = 0x1178, .enable_mask = BIT(0), - .hw.init = &(struct clk_init_data){ + .hw.init = &(const struct clk_init_data){ .name = "gpu_cc_hub_aon_clk", .parent_hws = (const struct clk_hw*[]){ &gpu_cc_hub_clk_src.clkr.hw, @@ -326,7 +326,7 @@ static struct clk_branch gpu_cc_hub_cx_int_clk = { .clkr = { .enable_reg = 0x1204, .enable_mask = BIT(0), - .hw.init = &(struct clk_init_data){ + .hw.init = &(const struct clk_init_data){ .name = "gpu_cc_hub_cx_int_clk", .parent_hws = (const struct clk_hw*[]){ &gpu_cc_hub_cx_int_div_clk_src.clkr.hw, @@ -344,7 +344,7 @@ static struct clk_branch gpu_cc_mnd1x_0_gfx3d_clk = { .clkr = { .enable_reg = 0x802c, .enable_mask = BIT(0), - .hw.init = &(struct clk_init_data){ + .hw.init = &(const struct clk_init_data){ .name = "gpu_cc_mnd1x_0_gfx3d_clk", .ops = &clk_branch2_ops, }, @@ -357,7 +357,7 @@ static struct clk_branch gpu_cc_mnd1x_1_gfx3d_clk = { .clkr = { .enable_reg = 0x8030, .enable_mask = BIT(0), - .hw.init = &(struct clk_init_data){ + .hw.init = &(const struct clk_init_data){ .name = "gpu_cc_mnd1x_1_gfx3d_clk", .ops = &clk_branch2_ops, }, @@ -370,7 +370,7 @@ static struct clk_branch gpu_cc_sleep_clk = { .clkr = { .enable_reg = 0x1090, .enable_mask = BIT(0), - .hw.init = &(struct clk_init_data){ + .hw.init = &(const struct clk_init_data){ .name = "gpu_cc_sleep_clk", .ops = &clk_branch2_ops, }, diff --git a/drivers/clk/qcom/lpasscc-sc7280.c b/drivers/clk/qcom/lpasscc-sc7280.c index b39ee1c9647b..ef055706b442 100644 --- a/drivers/clk/qcom/lpasscc-sc7280.c +++ b/drivers/clk/qcom/lpasscc-sc7280.c @@ -1,6 +1,6 @@ // SPDX-License-Identifier: GPL-2.0 /* - * Copyright (c) 2021, The Linux Foundation. All rights reserved. + * Copyright (c) 2021-2022, The Linux Foundation. All rights reserved. */ #include <linux/clk-provider.h> @@ -23,7 +23,7 @@ static struct clk_branch lpass_q6ss_ahbm_clk = { .clkr = { .enable_reg = 0x1c, .enable_mask = BIT(0), - .hw.init = &(struct clk_init_data){ + .hw.init = &(const struct clk_init_data){ .name = "lpass_q6ss_ahbm_clk", .ops = &clk_branch2_ops, }, @@ -36,7 +36,7 @@ static struct clk_branch lpass_q6ss_ahbs_clk = { .clkr = { .enable_reg = 0x20, .enable_mask = BIT(0), - .hw.init = &(struct clk_init_data){ + .hw.init = &(const struct clk_init_data){ .name = "lpass_q6ss_ahbs_clk", .ops = &clk_branch2_ops, }, @@ -49,7 +49,7 @@ static struct clk_branch lpass_top_cc_lpi_q6_axim_hs_clk = { .clkr = { .enable_reg = 0x0, .enable_mask = BIT(0), - .hw.init = &(struct clk_init_data){ + .hw.init = &(const struct clk_init_data){ .name = "lpass_top_cc_lpi_q6_axim_hs_clk", .ops = &clk_branch2_ops, }, @@ -63,7 +63,7 @@ static struct clk_branch lpass_qdsp6ss_core_clk = { .clkr = { .enable_reg = 0x20, .enable_mask = BIT(0), - .hw.init = &(struct clk_init_data){ + .hw.init = &(const struct clk_init_data){ .name = "lpass_qdsp6ss_core_clk", .ops = &clk_branch2_ops, }, @@ -77,7 +77,7 @@ static struct clk_branch lpass_qdsp6ss_xo_clk = { .clkr = { .enable_reg = 0x38, .enable_mask = BIT(0), - .hw.init = &(struct clk_init_data){ + .hw.init = &(const struct clk_init_data){ .name = "lpass_qdsp6ss_xo_clk", .ops = &clk_branch2_ops, }, @@ -91,7 +91,7 @@ static struct clk_branch lpass_qdsp6ss_sleep_clk = { .clkr = { .enable_reg = 0x3c, .enable_mask = BIT(0), - .hw.init = &(struct clk_init_data){ + .hw.init = &(const struct clk_init_data){ .name = "lpass_qdsp6ss_sleep_clk", .ops = &clk_branch2_ops, }, diff --git a/drivers/clk/qcom/videocc-sc7280.c b/drivers/clk/qcom/videocc-sc7280.c index 615695d82319..ba192ce6163e 100644 --- a/drivers/clk/qcom/videocc-sc7280.c +++ b/drivers/clk/qcom/videocc-sc7280.c @@ -1,6 +1,6 @@ // SPDX-License-Identifier: GPL-2.0-only /* - * Copyright (c) 2021, The Linux Foundation. All rights reserved. + * Copyright (c) 2021-2022, The Linux Foundation. All rights reserved. */ #include <linux/clk-provider.h> @@ -45,10 +45,10 @@ static struct clk_alpha_pll video_pll0 = { .num_vco = ARRAY_SIZE(lucid_vco), .regs = clk_alpha_pll_regs[CLK_ALPHA_PLL_TYPE_LUCID], .clkr = { - .hw.init = &(struct clk_init_data){ + .hw.init = &(const struct clk_init_data){ .name = "video_pll0", .parent_data = &(const struct clk_parent_data){ - .fw_name = "bi_tcxo", + .index = 0, }, .num_parents = 1, .ops = &clk_alpha_pll_lucid_ops, @@ -62,7 +62,7 @@ static const struct parent_map video_cc_parent_map_0[] = { }; static const struct clk_parent_data video_cc_parent_data_0[] = { - { .fw_name = "bi_tcxo" }, + { .index = 0 }, { .hw = &video_pll0.clkr.hw }, }; @@ -89,7 +89,7 @@ static struct clk_rcg2 video_cc_iris_clk_src = { .hid_width = 5, .parent_map = video_cc_parent_map_0, .freq_tbl = ftbl_video_cc_iris_clk_src, - .clkr.hw.init = &(struct clk_init_data){ + .clkr.hw.init = &(const struct clk_init_data){ .name = "video_cc_iris_clk_src", .parent_data = video_cc_parent_data_0, .num_parents = ARRAY_SIZE(video_cc_parent_data_0), @@ -109,7 +109,7 @@ static struct clk_rcg2 video_cc_sleep_clk_src = { .hid_width = 5, .parent_map = video_cc_parent_map_1, .freq_tbl = ftbl_video_cc_sleep_clk_src, - .clkr.hw.init = &(struct clk_init_data){ + .clkr.hw.init = &(const struct clk_init_data){ .name = "video_cc_sleep_clk_src", .parent_data = video_cc_parent_data_1, .num_parents = ARRAY_SIZE(video_cc_parent_data_1), @@ -123,7 +123,7 @@ static struct clk_branch video_cc_iris_ahb_clk = { .clkr = { .enable_reg = 0x5004, .enable_mask = BIT(0), - .hw.init = &(struct clk_init_data){ + .hw.init = &(const struct clk_init_data){ .name = "video_cc_iris_ahb_clk", .parent_hws = (const struct clk_hw*[]){ &video_cc_iris_clk_src.clkr.hw, @@ -141,7 +141,7 @@ static struct clk_branch video_cc_mvs0_axi_clk = { .clkr = { .enable_reg = 0x800c, .enable_mask = BIT(0), - .hw.init = &(struct clk_init_data){ + .hw.init = &(const struct clk_init_data){ .name = "video_cc_mvs0_axi_clk", .ops = &clk_branch2_ops, }, @@ -156,7 +156,7 @@ static struct clk_branch video_cc_mvs0_core_clk = { .clkr = { .enable_reg = 0x3010, .enable_mask = BIT(0), - .hw.init = &(struct clk_init_data){ + .hw.init = &(const struct clk_init_data){ .name = "video_cc_mvs0_core_clk", .parent_hws = (const struct clk_hw*[]){ &video_cc_iris_clk_src.clkr.hw, @@ -174,7 +174,7 @@ static struct clk_branch video_cc_mvsc_core_clk = { .clkr = { .enable_reg = 0x2014, .enable_mask = BIT(0), - .hw.init = &(struct clk_init_data){ + .hw.init = &(const struct clk_init_data){ .name = "video_cc_mvsc_core_clk", .parent_hws = (const struct clk_hw*[]){ &video_cc_iris_clk_src.clkr.hw, @@ -192,7 +192,7 @@ static struct clk_branch video_cc_mvsc_ctl_axi_clk = { .clkr = { .enable_reg = 0x8004, .enable_mask = BIT(0), - .hw.init = &(struct clk_init_data){ + .hw.init = &(const struct clk_init_data){ .name = "video_cc_mvsc_ctl_axi_clk", .ops = &clk_branch2_ops, }, @@ -205,7 +205,7 @@ static struct clk_branch video_cc_sleep_clk = { .clkr = { .enable_reg = 0x7034, .enable_mask = BIT(0), - .hw.init = &(struct clk_init_data){ + .hw.init = &(const struct clk_init_data){ .name = "video_cc_sleep_clk", .parent_hws = (const struct clk_hw*[]){ &video_cc_sleep_clk_src.clkr.hw, @@ -223,7 +223,7 @@ static struct clk_branch video_cc_venus_ahb_clk = { .clkr = { .enable_reg = 0x801c, .enable_mask = BIT(0), - .hw.init = &(struct clk_init_data){ + .hw.init = &(const struct clk_init_data){ .name = "video_cc_venus_ahb_clk", .ops = &clk_branch2_ops, }, -- Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a member of the Code Aurora Forum, hosted by the Linux Foundation. ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1 2/2] clk: qcom: sc7280: Update clk_init_data to const for clock controllers 2022-02-02 18:20 ` [PATCH v1 2/2] clk: qcom: sc7280: Update clk_init_data to const for clock controllers Taniya Das @ 2022-02-02 22:34 ` Dmitry Baryshkov 2022-02-05 2:48 ` Stephen Boyd 0 siblings, 1 reply; 3+ messages in thread From: Dmitry Baryshkov @ 2022-02-02 22:34 UTC (permalink / raw) To: Taniya Das Cc: Stephen Boyd, Michael Turquette, Rajendra Nayak, linux-arm-msm, linux-soc, linux-clk, linux-kernel On Wed, 2 Feb 2022 at 21:23, Taniya Das <tdas@codeaurora.org> wrote: > > Update clk_init_data to const and also use index instead of fw_name for > graphics, lpasscc and video clock controller. What is the benefit from using indices here? In my opinion the code becomes more fragile with such a change. > > Fixes: 3e0f01d6c7e74 ("clk: qcom: Add graphics clock controller driver for SC7280") > Fixes: 4ab43d171181d ("clk: qcom: Add lpass clock controller driver for SC7280") > Fixes: fae7617bb1428 ("clk: qcom: Add video clock controller driver for SC7280") > Signed-off-by: Taniya Das <tdas@codeaurora.org> > --- > drivers/clk/qcom/gpucc-sc7280.c | 56 +++++++++++++++---------------- > drivers/clk/qcom/lpasscc-sc7280.c | 14 ++++---- > drivers/clk/qcom/videocc-sc7280.c | 26 +++++++------- > 3 files changed, 48 insertions(+), 48 deletions(-) > > diff --git a/drivers/clk/qcom/gpucc-sc7280.c b/drivers/clk/qcom/gpucc-sc7280.c > index 9a832f2bcf49..e8f6abc5261f 100644 > --- a/drivers/clk/qcom/gpucc-sc7280.c > +++ b/drivers/clk/qcom/gpucc-sc7280.c > @@ -1,6 +1,6 @@ > // SPDX-License-Identifier: GPL-2.0-only > /* > - * Copyright (c) 2021, The Linux Foundation. All rights reserved. > + * Copyright (c) 2021-2022, The Linux Foundation. All rights reserved. > */ > > #include <linux/clk-provider.h> > @@ -36,10 +36,10 @@ static struct clk_alpha_pll gpu_cc_pll0 = { > .num_vco = ARRAY_SIZE(lucid_vco), > .regs = clk_alpha_pll_regs[CLK_ALPHA_PLL_TYPE_LUCID], > .clkr = { > - .hw.init = &(struct clk_init_data){ > + .hw.init = &(const struct clk_init_data){ > .name = "gpu_cc_pll0", > .parent_data = &(const struct clk_parent_data){ > - .fw_name = "bi_tcxo", > + .index = 0, > }, > .num_parents = 1, > .ops = &clk_alpha_pll_lucid_ops, > @@ -65,10 +65,10 @@ static struct clk_alpha_pll gpu_cc_pll1 = { > .num_vco = ARRAY_SIZE(lucid_vco), > .regs = clk_alpha_pll_regs[CLK_ALPHA_PLL_TYPE_LUCID], > .clkr = { > - .hw.init = &(struct clk_init_data){ > + .hw.init = &(const struct clk_init_data){ > .name = "gpu_cc_pll1", > .parent_data = &(const struct clk_parent_data){ > - .fw_name = "bi_tcxo", > + .index = 0, > }, > .num_parents = 1, > .ops = &clk_alpha_pll_lucid_ops, > @@ -85,11 +85,11 @@ static const struct parent_map gpu_cc_parent_map_0[] = { > }; > > static const struct clk_parent_data gpu_cc_parent_data_0[] = { > - { .fw_name = "bi_tcxo" }, > + { .index = 0 }, > { .hw = &gpu_cc_pll0.clkr.hw }, > { .hw = &gpu_cc_pll1.clkr.hw }, > - { .fw_name = "gcc_gpu_gpll0_clk_src" }, > - { .fw_name = "gcc_gpu_gpll0_div_clk_src" }, > + { .index = 1 }, /* gcc_gpu_gpll0_clk_src */ > + { .index = 2 }, /* gcc_gpu_gpll0_div_clk_src */ > }; > > static const struct parent_map gpu_cc_parent_map_1[] = { > @@ -100,10 +100,10 @@ static const struct parent_map gpu_cc_parent_map_1[] = { > }; > > static const struct clk_parent_data gpu_cc_parent_data_1[] = { > - { .fw_name = "bi_tcxo", }, > + { .index = 0, }, > { .hw = &gpu_cc_pll1.clkr.hw }, > - { .fw_name = "gcc_gpu_gpll0_clk_src", }, > - { .fw_name = "gcc_gpu_gpll0_div_clk_src", }, > + { .index = 1 }, /* gcc_gpu_gpll0_clk_src */ > + { .index = 2 }, /* gcc_gpu_gpll0_div_clk_src */ > }; > > static const struct freq_tbl ftbl_gpu_cc_gmu_clk_src[] = { > @@ -119,7 +119,7 @@ static struct clk_rcg2 gpu_cc_gmu_clk_src = { > .hid_width = 5, > .parent_map = gpu_cc_parent_map_0, > .freq_tbl = ftbl_gpu_cc_gmu_clk_src, > - .clkr.hw.init = &(struct clk_init_data){ > + .clkr.hw.init = &(const struct clk_init_data){ > .name = "gpu_cc_gmu_clk_src", > .parent_data = gpu_cc_parent_data_0, > .num_parents = ARRAY_SIZE(gpu_cc_parent_data_0), > @@ -140,7 +140,7 @@ static struct clk_rcg2 gpu_cc_hub_clk_src = { > .hid_width = 5, > .parent_map = gpu_cc_parent_map_1, > .freq_tbl = ftbl_gpu_cc_hub_clk_src, > - .clkr.hw.init = &(struct clk_init_data){ > + .clkr.hw.init = &(const struct clk_init_data){ > .name = "gpu_cc_hub_clk_src", > .parent_data = gpu_cc_parent_data_1, > .num_parents = ARRAY_SIZE(gpu_cc_parent_data_1), > @@ -152,7 +152,7 @@ static struct clk_regmap_div gpu_cc_hub_ahb_div_clk_src = { > .reg = 0x11c0, > .shift = 0, > .width = 4, > - .clkr.hw.init = &(struct clk_init_data) { > + .clkr.hw.init = &(const struct clk_init_data) { > .name = "gpu_cc_hub_ahb_div_clk_src", > .parent_hws = (const struct clk_hw*[]){ > &gpu_cc_hub_clk_src.clkr.hw, > @@ -167,7 +167,7 @@ static struct clk_regmap_div gpu_cc_hub_cx_int_div_clk_src = { > .reg = 0x11bc, > .shift = 0, > .width = 4, > - .clkr.hw.init = &(struct clk_init_data) { > + .clkr.hw.init = &(const struct clk_init_data) { > .name = "gpu_cc_hub_cx_int_div_clk_src", > .parent_hws = (const struct clk_hw*[]){ > &gpu_cc_hub_clk_src.clkr.hw, > @@ -184,7 +184,7 @@ static struct clk_branch gpu_cc_ahb_clk = { > .clkr = { > .enable_reg = 0x1078, > .enable_mask = BIT(0), > - .hw.init = &(struct clk_init_data){ > + .hw.init = &(const struct clk_init_data){ > .name = "gpu_cc_ahb_clk", > .parent_hws = (const struct clk_hw*[]){ > &gpu_cc_hub_ahb_div_clk_src.clkr.hw, > @@ -202,7 +202,7 @@ static struct clk_branch gpu_cc_crc_ahb_clk = { > .clkr = { > .enable_reg = 0x107c, > .enable_mask = BIT(0), > - .hw.init = &(struct clk_init_data){ > + .hw.init = &(const struct clk_init_data){ > .name = "gpu_cc_crc_ahb_clk", > .parent_hws = (const struct clk_hw*[]){ > &gpu_cc_hub_ahb_div_clk_src.clkr.hw, > @@ -220,7 +220,7 @@ static struct clk_branch gpu_cc_cx_gmu_clk = { > .clkr = { > .enable_reg = 0x1098, > .enable_mask = BIT(0), > - .hw.init = &(struct clk_init_data){ > + .hw.init = &(const struct clk_init_data){ > .name = "gpu_cc_cx_gmu_clk", > .parent_hws = (const struct clk_hw*[]){ > &gpu_cc_gmu_clk_src.clkr.hw, > @@ -238,7 +238,7 @@ static struct clk_branch gpu_cc_cx_snoc_dvm_clk = { > .clkr = { > .enable_reg = 0x108c, > .enable_mask = BIT(0), > - .hw.init = &(struct clk_init_data){ > + .hw.init = &(const struct clk_init_data){ > .name = "gpu_cc_cx_snoc_dvm_clk", > .ops = &clk_branch2_ops, > }, > @@ -251,7 +251,7 @@ static struct clk_branch gpu_cc_cxo_aon_clk = { > .clkr = { > .enable_reg = 0x1004, > .enable_mask = BIT(0), > - .hw.init = &(struct clk_init_data){ > + .hw.init = &(const struct clk_init_data){ > .name = "gpu_cc_cxo_aon_clk", > .ops = &clk_branch2_ops, > }, > @@ -264,7 +264,7 @@ static struct clk_branch gpu_cc_cxo_clk = { > .clkr = { > .enable_reg = 0x109c, > .enable_mask = BIT(0), > - .hw.init = &(struct clk_init_data){ > + .hw.init = &(const struct clk_init_data){ > .name = "gpu_cc_cxo_clk", > .ops = &clk_branch2_aon_ops, > }, > @@ -277,7 +277,7 @@ static struct clk_branch gpu_cc_gx_gmu_clk = { > .clkr = { > .enable_reg = 0x1064, > .enable_mask = BIT(0), > - .hw.init = &(struct clk_init_data){ > + .hw.init = &(const struct clk_init_data){ > .name = "gpu_cc_gx_gmu_clk", > .parent_hws = (const struct clk_hw*[]){ > &gpu_cc_gmu_clk_src.clkr.hw, > @@ -295,7 +295,7 @@ static struct clk_branch gpu_cc_hlos1_vote_gpu_smmu_clk = { > .clkr = { > .enable_reg = 0x5000, > .enable_mask = BIT(0), > - .hw.init = &(struct clk_init_data){ > + .hw.init = &(const struct clk_init_data){ > .name = "gpu_cc_hlos1_vote_gpu_smmu_clk", > .ops = &clk_branch2_ops, > }, > @@ -308,7 +308,7 @@ static struct clk_branch gpu_cc_hub_aon_clk = { > .clkr = { > .enable_reg = 0x1178, > .enable_mask = BIT(0), > - .hw.init = &(struct clk_init_data){ > + .hw.init = &(const struct clk_init_data){ > .name = "gpu_cc_hub_aon_clk", > .parent_hws = (const struct clk_hw*[]){ > &gpu_cc_hub_clk_src.clkr.hw, > @@ -326,7 +326,7 @@ static struct clk_branch gpu_cc_hub_cx_int_clk = { > .clkr = { > .enable_reg = 0x1204, > .enable_mask = BIT(0), > - .hw.init = &(struct clk_init_data){ > + .hw.init = &(const struct clk_init_data){ > .name = "gpu_cc_hub_cx_int_clk", > .parent_hws = (const struct clk_hw*[]){ > &gpu_cc_hub_cx_int_div_clk_src.clkr.hw, > @@ -344,7 +344,7 @@ static struct clk_branch gpu_cc_mnd1x_0_gfx3d_clk = { > .clkr = { > .enable_reg = 0x802c, > .enable_mask = BIT(0), > - .hw.init = &(struct clk_init_data){ > + .hw.init = &(const struct clk_init_data){ > .name = "gpu_cc_mnd1x_0_gfx3d_clk", > .ops = &clk_branch2_ops, > }, > @@ -357,7 +357,7 @@ static struct clk_branch gpu_cc_mnd1x_1_gfx3d_clk = { > .clkr = { > .enable_reg = 0x8030, > .enable_mask = BIT(0), > - .hw.init = &(struct clk_init_data){ > + .hw.init = &(const struct clk_init_data){ > .name = "gpu_cc_mnd1x_1_gfx3d_clk", > .ops = &clk_branch2_ops, > }, > @@ -370,7 +370,7 @@ static struct clk_branch gpu_cc_sleep_clk = { > .clkr = { > .enable_reg = 0x1090, > .enable_mask = BIT(0), > - .hw.init = &(struct clk_init_data){ > + .hw.init = &(const struct clk_init_data){ > .name = "gpu_cc_sleep_clk", > .ops = &clk_branch2_ops, > }, > diff --git a/drivers/clk/qcom/lpasscc-sc7280.c b/drivers/clk/qcom/lpasscc-sc7280.c > index b39ee1c9647b..ef055706b442 100644 > --- a/drivers/clk/qcom/lpasscc-sc7280.c > +++ b/drivers/clk/qcom/lpasscc-sc7280.c > @@ -1,6 +1,6 @@ > // SPDX-License-Identifier: GPL-2.0 > /* > - * Copyright (c) 2021, The Linux Foundation. All rights reserved. > + * Copyright (c) 2021-2022, The Linux Foundation. All rights reserved. > */ > > #include <linux/clk-provider.h> > @@ -23,7 +23,7 @@ static struct clk_branch lpass_q6ss_ahbm_clk = { > .clkr = { > .enable_reg = 0x1c, > .enable_mask = BIT(0), > - .hw.init = &(struct clk_init_data){ > + .hw.init = &(const struct clk_init_data){ > .name = "lpass_q6ss_ahbm_clk", > .ops = &clk_branch2_ops, > }, > @@ -36,7 +36,7 @@ static struct clk_branch lpass_q6ss_ahbs_clk = { > .clkr = { > .enable_reg = 0x20, > .enable_mask = BIT(0), > - .hw.init = &(struct clk_init_data){ > + .hw.init = &(const struct clk_init_data){ > .name = "lpass_q6ss_ahbs_clk", > .ops = &clk_branch2_ops, > }, > @@ -49,7 +49,7 @@ static struct clk_branch lpass_top_cc_lpi_q6_axim_hs_clk = { > .clkr = { > .enable_reg = 0x0, > .enable_mask = BIT(0), > - .hw.init = &(struct clk_init_data){ > + .hw.init = &(const struct clk_init_data){ > .name = "lpass_top_cc_lpi_q6_axim_hs_clk", > .ops = &clk_branch2_ops, > }, > @@ -63,7 +63,7 @@ static struct clk_branch lpass_qdsp6ss_core_clk = { > .clkr = { > .enable_reg = 0x20, > .enable_mask = BIT(0), > - .hw.init = &(struct clk_init_data){ > + .hw.init = &(const struct clk_init_data){ > .name = "lpass_qdsp6ss_core_clk", > .ops = &clk_branch2_ops, > }, > @@ -77,7 +77,7 @@ static struct clk_branch lpass_qdsp6ss_xo_clk = { > .clkr = { > .enable_reg = 0x38, > .enable_mask = BIT(0), > - .hw.init = &(struct clk_init_data){ > + .hw.init = &(const struct clk_init_data){ > .name = "lpass_qdsp6ss_xo_clk", > .ops = &clk_branch2_ops, > }, > @@ -91,7 +91,7 @@ static struct clk_branch lpass_qdsp6ss_sleep_clk = { > .clkr = { > .enable_reg = 0x3c, > .enable_mask = BIT(0), > - .hw.init = &(struct clk_init_data){ > + .hw.init = &(const struct clk_init_data){ > .name = "lpass_qdsp6ss_sleep_clk", > .ops = &clk_branch2_ops, > }, > diff --git a/drivers/clk/qcom/videocc-sc7280.c b/drivers/clk/qcom/videocc-sc7280.c > index 615695d82319..ba192ce6163e 100644 > --- a/drivers/clk/qcom/videocc-sc7280.c > +++ b/drivers/clk/qcom/videocc-sc7280.c > @@ -1,6 +1,6 @@ > // SPDX-License-Identifier: GPL-2.0-only > /* > - * Copyright (c) 2021, The Linux Foundation. All rights reserved. > + * Copyright (c) 2021-2022, The Linux Foundation. All rights reserved. > */ > > #include <linux/clk-provider.h> > @@ -45,10 +45,10 @@ static struct clk_alpha_pll video_pll0 = { > .num_vco = ARRAY_SIZE(lucid_vco), > .regs = clk_alpha_pll_regs[CLK_ALPHA_PLL_TYPE_LUCID], > .clkr = { > - .hw.init = &(struct clk_init_data){ > + .hw.init = &(const struct clk_init_data){ > .name = "video_pll0", > .parent_data = &(const struct clk_parent_data){ > - .fw_name = "bi_tcxo", > + .index = 0, > }, > .num_parents = 1, > .ops = &clk_alpha_pll_lucid_ops, > @@ -62,7 +62,7 @@ static const struct parent_map video_cc_parent_map_0[] = { > }; > > static const struct clk_parent_data video_cc_parent_data_0[] = { > - { .fw_name = "bi_tcxo" }, > + { .index = 0 }, > { .hw = &video_pll0.clkr.hw }, > }; > > @@ -89,7 +89,7 @@ static struct clk_rcg2 video_cc_iris_clk_src = { > .hid_width = 5, > .parent_map = video_cc_parent_map_0, > .freq_tbl = ftbl_video_cc_iris_clk_src, > - .clkr.hw.init = &(struct clk_init_data){ > + .clkr.hw.init = &(const struct clk_init_data){ > .name = "video_cc_iris_clk_src", > .parent_data = video_cc_parent_data_0, > .num_parents = ARRAY_SIZE(video_cc_parent_data_0), > @@ -109,7 +109,7 @@ static struct clk_rcg2 video_cc_sleep_clk_src = { > .hid_width = 5, > .parent_map = video_cc_parent_map_1, > .freq_tbl = ftbl_video_cc_sleep_clk_src, > - .clkr.hw.init = &(struct clk_init_data){ > + .clkr.hw.init = &(const struct clk_init_data){ > .name = "video_cc_sleep_clk_src", > .parent_data = video_cc_parent_data_1, > .num_parents = ARRAY_SIZE(video_cc_parent_data_1), > @@ -123,7 +123,7 @@ static struct clk_branch video_cc_iris_ahb_clk = { > .clkr = { > .enable_reg = 0x5004, > .enable_mask = BIT(0), > - .hw.init = &(struct clk_init_data){ > + .hw.init = &(const struct clk_init_data){ > .name = "video_cc_iris_ahb_clk", > .parent_hws = (const struct clk_hw*[]){ > &video_cc_iris_clk_src.clkr.hw, > @@ -141,7 +141,7 @@ static struct clk_branch video_cc_mvs0_axi_clk = { > .clkr = { > .enable_reg = 0x800c, > .enable_mask = BIT(0), > - .hw.init = &(struct clk_init_data){ > + .hw.init = &(const struct clk_init_data){ > .name = "video_cc_mvs0_axi_clk", > .ops = &clk_branch2_ops, > }, > @@ -156,7 +156,7 @@ static struct clk_branch video_cc_mvs0_core_clk = { > .clkr = { > .enable_reg = 0x3010, > .enable_mask = BIT(0), > - .hw.init = &(struct clk_init_data){ > + .hw.init = &(const struct clk_init_data){ > .name = "video_cc_mvs0_core_clk", > .parent_hws = (const struct clk_hw*[]){ > &video_cc_iris_clk_src.clkr.hw, > @@ -174,7 +174,7 @@ static struct clk_branch video_cc_mvsc_core_clk = { > .clkr = { > .enable_reg = 0x2014, > .enable_mask = BIT(0), > - .hw.init = &(struct clk_init_data){ > + .hw.init = &(const struct clk_init_data){ > .name = "video_cc_mvsc_core_clk", > .parent_hws = (const struct clk_hw*[]){ > &video_cc_iris_clk_src.clkr.hw, > @@ -192,7 +192,7 @@ static struct clk_branch video_cc_mvsc_ctl_axi_clk = { > .clkr = { > .enable_reg = 0x8004, > .enable_mask = BIT(0), > - .hw.init = &(struct clk_init_data){ > + .hw.init = &(const struct clk_init_data){ > .name = "video_cc_mvsc_ctl_axi_clk", > .ops = &clk_branch2_ops, > }, > @@ -205,7 +205,7 @@ static struct clk_branch video_cc_sleep_clk = { > .clkr = { > .enable_reg = 0x7034, > .enable_mask = BIT(0), > - .hw.init = &(struct clk_init_data){ > + .hw.init = &(const struct clk_init_data){ > .name = "video_cc_sleep_clk", > .parent_hws = (const struct clk_hw*[]){ > &video_cc_sleep_clk_src.clkr.hw, > @@ -223,7 +223,7 @@ static struct clk_branch video_cc_venus_ahb_clk = { > .clkr = { > .enable_reg = 0x801c, > .enable_mask = BIT(0), > - .hw.init = &(struct clk_init_data){ > + .hw.init = &(const struct clk_init_data){ > .name = "video_cc_venus_ahb_clk", > .ops = &clk_branch2_ops, > }, > -- > Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a member > of the Code Aurora Forum, hosted by the Linux Foundation. > -- With best wishes Dmitry ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1 2/2] clk: qcom: sc7280: Update clk_init_data to const for clock controllers 2022-02-02 22:34 ` Dmitry Baryshkov @ 2022-02-05 2:48 ` Stephen Boyd 0 siblings, 0 replies; 3+ messages in thread From: Stephen Boyd @ 2022-02-05 2:48 UTC (permalink / raw) To: Dmitry Baryshkov, Taniya Das Cc: Michael Turquette, Rajendra Nayak, linux-arm-msm, linux-soc, linux-clk, linux-kernel Quoting Dmitry Baryshkov (2022-02-02 14:34:11) > On Wed, 2 Feb 2022 at 21:23, Taniya Das <tdas@codeaurora.org> wrote: > > > > Update clk_init_data to const and also use index instead of fw_name for > > graphics, lpasscc and video clock controller. > > What is the benefit from using indices here? In my opinion the code > becomes more fragile with such a change. The benefit is smaller code size. Please run scripts/bloat-o-meter ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-02-05 2:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20220202182053.22925-1-tdas@codeaurora.org>
2022-02-02 18:20 ` [PATCH v1 2/2] clk: qcom: sc7280: Update clk_init_data to const for clock controllers Taniya Das
2022-02-02 22:34 ` Dmitry Baryshkov
2022-02-05 2:48 ` Stephen Boyd
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox