* [PATCH v6 5/5] clk: qcom: Alwaya on pcie gdsc [not found] <1662713084-8106-1-git-send-email-quic_krichai@quicinc.com> @ 2022-09-09 8:44 ` Krishna chaitanya chundru 2022-09-12 17:04 ` Manivannan Sadhasivam 0 siblings, 1 reply; 7+ messages in thread From: Krishna chaitanya chundru @ 2022-09-09 8:44 UTC (permalink / raw) To: helgaas Cc: linux-pci, linux-arm-msm, linux-kernel, mka, quic_vbadigan, quic_hemantk, quic_nitegupt, quic_skananth, quic_ramkri, manivannan.sadhasivam, swboyd, dmitry.baryshkov, Krishna chaitanya chundru, Bjorn Andersson, Andy Gross, Konrad Dybcio, Michael Turquette, Stephen Boyd, open list:COMMON CLK FRAMEWORK Make GDSC always on to ensure controller and its dependent clocks won't go down during system suspend. Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com> --- drivers/clk/qcom/gcc-sc7280.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/qcom/gcc-sc7280.c b/drivers/clk/qcom/gcc-sc7280.c index 7ff64d4..2f781a2 100644 --- a/drivers/clk/qcom/gcc-sc7280.c +++ b/drivers/clk/qcom/gcc-sc7280.c @@ -3109,7 +3109,7 @@ static struct gdsc gcc_pcie_1_gdsc = { .name = "gcc_pcie_1_gdsc", }, .pwrsts = PWRSTS_OFF_ON, - .flags = VOTABLE, + .flags = ALWAYS_ON, }; static struct gdsc gcc_ufs_phy_gdsc = { -- 2.7.4 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v6 5/5] clk: qcom: Alwaya on pcie gdsc 2022-09-09 8:44 ` [PATCH v6 5/5] clk: qcom: Alwaya on pcie gdsc Krishna chaitanya chundru @ 2022-09-12 17:04 ` Manivannan Sadhasivam 2022-09-13 6:42 ` Rajendra Nayak 2022-09-13 16:34 ` Bjorn Helgaas 0 siblings, 2 replies; 7+ messages in thread From: Manivannan Sadhasivam @ 2022-09-12 17:04 UTC (permalink / raw) To: Krishna chaitanya chundru, quic_rjendra Cc: helgaas, linux-pci, linux-arm-msm, linux-kernel, mka, quic_vbadigan, quic_hemantk, quic_nitegupt, quic_skananth, quic_ramkri, swboyd, dmitry.baryshkov, Bjorn Andersson, Andy Gross, Konrad Dybcio, Michael Turquette, Stephen Boyd, open list:COMMON CLK FRAMEWORK + Rajendra On Fri, Sep 09, 2022 at 02:14:44PM +0530, Krishna chaitanya chundru wrote: > Make GDSC always on to ensure controller and its dependent clocks > won't go down during system suspend. > You need to mention the SoC name in subject, otherwise one cannot know for which platform this patch applies to. > Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com> > --- > drivers/clk/qcom/gcc-sc7280.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/qcom/gcc-sc7280.c b/drivers/clk/qcom/gcc-sc7280.c > index 7ff64d4..2f781a2 100644 > --- a/drivers/clk/qcom/gcc-sc7280.c > +++ b/drivers/clk/qcom/gcc-sc7280.c > @@ -3109,7 +3109,7 @@ static struct gdsc gcc_pcie_1_gdsc = { > .name = "gcc_pcie_1_gdsc", > }, > .pwrsts = PWRSTS_OFF_ON, > - .flags = VOTABLE, > + .flags = ALWAYS_ON, Rajendra, should we also put PCIe GDSC into retention state as you have done for USB [1]? Thanks, Mani [1] https://lore.kernel.org/all/20220901101756.28164-2-quic_rjendra@quicinc.com/ > }; > > static struct gdsc gcc_ufs_phy_gdsc = { > -- > 2.7.4 > -- மணிவண்ணன் சதாசிவம் ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v6 5/5] clk: qcom: Alwaya on pcie gdsc 2022-09-12 17:04 ` Manivannan Sadhasivam @ 2022-09-13 6:42 ` Rajendra Nayak 2022-09-13 16:42 ` Manivannan Sadhasivam 2022-09-13 16:34 ` Bjorn Helgaas 1 sibling, 1 reply; 7+ messages in thread From: Rajendra Nayak @ 2022-09-13 6:42 UTC (permalink / raw) To: Manivannan Sadhasivam, Krishna chaitanya chundru Cc: helgaas, linux-pci, linux-arm-msm, linux-kernel, mka, quic_vbadigan, quic_hemantk, quic_nitegupt, quic_skananth, quic_ramkri, swboyd, dmitry.baryshkov, Bjorn Andersson, Andy Gross, Konrad Dybcio, Michael Turquette, Stephen Boyd, open list:COMMON CLK FRAMEWORK On 9/12/2022 10:34 PM, Manivannan Sadhasivam wrote: > + Rajendra > > On Fri, Sep 09, 2022 at 02:14:44PM +0530, Krishna chaitanya chundru wrote: >> Make GDSC always on to ensure controller and its dependent clocks >> won't go down during system suspend. >> > > You need to mention the SoC name in subject, otherwise one cannot know for > which platform this patch applies to. > >> Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com> >> --- >> drivers/clk/qcom/gcc-sc7280.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/clk/qcom/gcc-sc7280.c b/drivers/clk/qcom/gcc-sc7280.c >> index 7ff64d4..2f781a2 100644 >> --- a/drivers/clk/qcom/gcc-sc7280.c >> +++ b/drivers/clk/qcom/gcc-sc7280.c >> @@ -3109,7 +3109,7 @@ static struct gdsc gcc_pcie_1_gdsc = { >> .name = "gcc_pcie_1_gdsc", >> }, >> .pwrsts = PWRSTS_OFF_ON, >> - .flags = VOTABLE, >> + .flags = ALWAYS_ON, > > Rajendra, should we also put PCIe GDSC into retention state as you have done for > USB [1]? Yes, it looks like we should handle this the same way as we did with usb. Why are we removing the VOTABLE flag anyway? > > Thanks, > Mani > > [1] https://lore.kernel.org/all/20220901101756.28164-2-quic_rjendra@quicinc.com/ > >> }; >> >> static struct gdsc gcc_ufs_phy_gdsc = { >> -- >> 2.7.4 >> > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v6 5/5] clk: qcom: Alwaya on pcie gdsc 2022-09-13 6:42 ` Rajendra Nayak @ 2022-09-13 16:42 ` Manivannan Sadhasivam 2022-09-14 1:47 ` Krishna Chaitanya Chundru 0 siblings, 1 reply; 7+ messages in thread From: Manivannan Sadhasivam @ 2022-09-13 16:42 UTC (permalink / raw) To: Rajendra Nayak Cc: Krishna chaitanya chundru, helgaas, linux-pci, linux-arm-msm, linux-kernel, mka, quic_vbadigan, quic_hemantk, quic_nitegupt, quic_skananth, quic_ramkri, swboyd, dmitry.baryshkov, Bjorn Andersson, Andy Gross, Konrad Dybcio, Michael Turquette, Stephen Boyd, open list:COMMON CLK FRAMEWORK On Tue, Sep 13, 2022 at 12:12:32PM +0530, Rajendra Nayak wrote: > > On 9/12/2022 10:34 PM, Manivannan Sadhasivam wrote: > > + Rajendra > > > > On Fri, Sep 09, 2022 at 02:14:44PM +0530, Krishna chaitanya chundru wrote: > > > Make GDSC always on to ensure controller and its dependent clocks > > > won't go down during system suspend. > > > > > > > You need to mention the SoC name in subject, otherwise one cannot know for > > which platform this patch applies to. > > > > > Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com> > > > --- > > > drivers/clk/qcom/gcc-sc7280.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/clk/qcom/gcc-sc7280.c b/drivers/clk/qcom/gcc-sc7280.c > > > index 7ff64d4..2f781a2 100644 > > > --- a/drivers/clk/qcom/gcc-sc7280.c > > > +++ b/drivers/clk/qcom/gcc-sc7280.c > > > @@ -3109,7 +3109,7 @@ static struct gdsc gcc_pcie_1_gdsc = { > > > .name = "gcc_pcie_1_gdsc", > > > }, > > > .pwrsts = PWRSTS_OFF_ON, > > > - .flags = VOTABLE, > > > + .flags = ALWAYS_ON, > > > > Rajendra, should we also put PCIe GDSC into retention state as you have done for > > USB [1]? > > Yes, it looks like we should handle this the same way as we did with usb. Okay, thanks for the confirmation. > Why are we removing the VOTABLE flag anyway? Yeah, I don't see a reason for doing that. Chaitanya, please follow the patch from Rajendra I mentioned above and adapt it for PCIe GDSC. Thanks, Mani > > > > > Thanks, > > Mani > > > > [1] https://lore.kernel.org/all/20220901101756.28164-2-quic_rjendra@quicinc.com/ > > > > > }; > > > static struct gdsc gcc_ufs_phy_gdsc = { > > > -- > > > 2.7.4 > > > > > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v6 5/5] clk: qcom: Alwaya on pcie gdsc 2022-09-13 16:42 ` Manivannan Sadhasivam @ 2022-09-14 1:47 ` Krishna Chaitanya Chundru 0 siblings, 0 replies; 7+ messages in thread From: Krishna Chaitanya Chundru @ 2022-09-14 1:47 UTC (permalink / raw) To: Manivannan Sadhasivam, Rajendra Nayak Cc: helgaas, linux-pci, linux-arm-msm, linux-kernel, mka, quic_vbadigan, quic_hemantk, quic_nitegupt, quic_skananth, quic_ramkri, swboyd, dmitry.baryshkov, Bjorn Andersson, Andy Gross, Konrad Dybcio, Michael Turquette, Stephen Boyd, open list:COMMON CLK FRAMEWORK On 9/13/2022 10:12 PM, Manivannan Sadhasivam wrote: > On Tue, Sep 13, 2022 at 12:12:32PM +0530, Rajendra Nayak wrote: >> On 9/12/2022 10:34 PM, Manivannan Sadhasivam wrote: >>> + Rajendra >>> >>> On Fri, Sep 09, 2022 at 02:14:44PM +0530, Krishna chaitanya chundru wrote: >>>> Make GDSC always on to ensure controller and its dependent clocks >>>> won't go down during system suspend. >>>> >>> You need to mention the SoC name in subject, otherwise one cannot know for >>> which platform this patch applies to. >>> >>>> Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com> >>>> --- >>>> drivers/clk/qcom/gcc-sc7280.c | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/clk/qcom/gcc-sc7280.c b/drivers/clk/qcom/gcc-sc7280.c >>>> index 7ff64d4..2f781a2 100644 >>>> --- a/drivers/clk/qcom/gcc-sc7280.c >>>> +++ b/drivers/clk/qcom/gcc-sc7280.c >>>> @@ -3109,7 +3109,7 @@ static struct gdsc gcc_pcie_1_gdsc = { >>>> .name = "gcc_pcie_1_gdsc", >>>> }, >>>> .pwrsts = PWRSTS_OFF_ON, >>>> - .flags = VOTABLE, >>>> + .flags = ALWAYS_ON, >>> Rajendra, should we also put PCIe GDSC into retention state as you have done for >>> USB [1]? >> Yes, it looks like we should handle this the same way as we did with usb. > Okay, thanks for the confirmation. > >> Why are we removing the VOTABLE flag anyway? > Yeah, I don't see a reason for doing that. > > Chaitanya, please follow the patch from Rajendra I mentioned above and adapt it > for PCIe GDSC. > > Thanks, > Mani ok I will try to adapt that. >>> Thanks, >>> Mani >>> >>> [1] https://lore.kernel.org/all/20220901101756.28164-2-quic_rjendra@quicinc.com/ >>> >>>> }; >>>> static struct gdsc gcc_ufs_phy_gdsc = { >>>> -- >>>> 2.7.4 >>>> ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v6 5/5] clk: qcom: Alwaya on pcie gdsc 2022-09-12 17:04 ` Manivannan Sadhasivam 2022-09-13 6:42 ` Rajendra Nayak @ 2022-09-13 16:34 ` Bjorn Helgaas 2022-09-14 1:48 ` Krishna Chaitanya Chundru 1 sibling, 1 reply; 7+ messages in thread From: Bjorn Helgaas @ 2022-09-13 16:34 UTC (permalink / raw) To: Manivannan Sadhasivam Cc: Krishna chaitanya chundru, quic_rjendra, linux-pci, linux-arm-msm, linux-kernel, mka, quic_vbadigan, quic_hemantk, quic_nitegupt, quic_skananth, quic_ramkri, swboyd, dmitry.baryshkov, Bjorn Andersson, Andy Gross, Konrad Dybcio, Michael Turquette, Stephen Boyd, open list:COMMON CLK FRAMEWORK On Mon, Sep 12, 2022 at 10:34:37PM +0530, Manivannan Sadhasivam wrote: > + Rajendra > > On Fri, Sep 09, 2022 at 02:14:44PM +0530, Krishna chaitanya chundru wrote: > > Make GDSC always on to ensure controller and its dependent clocks > > won't go down during system suspend. > > You need to mention the SoC name in subject, otherwise one cannot know for > which platform this patch applies to. Also: s/Alwaya/Always/ s/pcie/PCIe/ s/gdsc/GDSC/ as you did in commit log I might use "ALWAYS_ON" in the subject to make clear this refers to a specific flag, not a change in the code logic, e.g., clk: qcom: gcc-sc7280: Mark PCIe GDSC clock ALWAYS_ON ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v6 5/5] clk: qcom: Alwaya on pcie gdsc 2022-09-13 16:34 ` Bjorn Helgaas @ 2022-09-14 1:48 ` Krishna Chaitanya Chundru 0 siblings, 0 replies; 7+ messages in thread From: Krishna Chaitanya Chundru @ 2022-09-14 1:48 UTC (permalink / raw) To: Bjorn Helgaas, Manivannan Sadhasivam Cc: quic_rjendra, linux-pci, linux-arm-msm, linux-kernel, mka, quic_vbadigan, quic_hemantk, quic_nitegupt, quic_skananth, quic_ramkri, swboyd, dmitry.baryshkov, Bjorn Andersson, Andy Gross, Konrad Dybcio, Michael Turquette, Stephen Boyd, open list:COMMON CLK FRAMEWORK On 9/13/2022 10:04 PM, Bjorn Helgaas wrote: > On Mon, Sep 12, 2022 at 10:34:37PM +0530, Manivannan Sadhasivam wrote: >> + Rajendra >> >> On Fri, Sep 09, 2022 at 02:14:44PM +0530, Krishna chaitanya chundru wrote: >>> Make GDSC always on to ensure controller and its dependent clocks >>> won't go down during system suspend. >> You need to mention the SoC name in subject, otherwise one cannot know for >> which platform this patch applies to. > Also: > > s/Alwaya/Always/ > s/pcie/PCIe/ > s/gdsc/GDSC/ as you did in commit log > > I might use "ALWAYS_ON" in the subject to make clear this refers to a > specific flag, not a change in the code logic, e.g., > > clk: qcom: gcc-sc7280: Mark PCIe GDSC clock ALWAYS_ON ok I will update the subject in next patch. ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-09-14 1:48 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1662713084-8106-1-git-send-email-quic_krichai@quicinc.com>
2022-09-09 8:44 ` [PATCH v6 5/5] clk: qcom: Alwaya on pcie gdsc Krishna chaitanya chundru
2022-09-12 17:04 ` Manivannan Sadhasivam
2022-09-13 6:42 ` Rajendra Nayak
2022-09-13 16:42 ` Manivannan Sadhasivam
2022-09-14 1:47 ` Krishna Chaitanya Chundru
2022-09-13 16:34 ` Bjorn Helgaas
2022-09-14 1:48 ` Krishna Chaitanya Chundru
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox