* [PATCH] clk: qcom: dispcc-sm6350: Add CLK_OPS_PARENT_ENABLE to pixel&byte src
@ 2022-10-10 15:55 Konrad Dybcio
2022-10-11 1:02 ` Stephen Boyd
2022-11-07 3:12 ` Bjorn Andersson
0 siblings, 2 replies; 4+ messages in thread
From: Konrad Dybcio @ 2022-10-10 15:55 UTC (permalink / raw)
To: ~postmarketos/upstreaming
Cc: AngeloGioacchino Del Regno, Marijn Suijten, Martin Botka,
Jami Kettunen, Pavel Dubrova, Konrad Dybcio, Andy Gross,
Bjorn Andersson, Michael Turquette, Stephen Boyd, linux-arm-msm,
linux-clk, linux-kernel
Add the CLK_OPS_PARENT_ENABLE flag to pixel and byte clk srcs to
ensure set_rate can succeed.
Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org>
---
drivers/clk/qcom/dispcc-sm6350.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/clk/qcom/dispcc-sm6350.c b/drivers/clk/qcom/dispcc-sm6350.c
index 0c3c2e26ede9..ea6f54ed846e 100644
--- a/drivers/clk/qcom/dispcc-sm6350.c
+++ b/drivers/clk/qcom/dispcc-sm6350.c
@@ -306,7 +306,7 @@ static struct clk_rcg2 disp_cc_mdss_pclk0_clk_src = {
.name = "disp_cc_mdss_pclk0_clk_src",
.parent_data = disp_cc_parent_data_5,
.num_parents = ARRAY_SIZE(disp_cc_parent_data_5),
- .flags = CLK_SET_RATE_PARENT | CLK_GET_RATE_NOCACHE,
+ .flags = CLK_SET_RATE_PARENT | CLK_GET_RATE_NOCACHE | CLK_OPS_PARENT_ENABLE,
.ops = &clk_pixel_ops,
},
};
@@ -385,7 +385,7 @@ static struct clk_branch disp_cc_mdss_byte0_clk = {
&disp_cc_mdss_byte0_clk_src.clkr.hw,
},
.num_parents = 1,
- .flags = CLK_SET_RATE_PARENT | CLK_GET_RATE_NOCACHE,
+ .flags = CLK_SET_RATE_PARENT | CLK_GET_RATE_NOCACHE | CLK_OPS_PARENT_ENABLE,
.ops = &clk_branch2_ops,
},
},
--
2.30.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] clk: qcom: dispcc-sm6350: Add CLK_OPS_PARENT_ENABLE to pixel&byte src
2022-10-10 15:55 [PATCH] clk: qcom: dispcc-sm6350: Add CLK_OPS_PARENT_ENABLE to pixel&byte src Konrad Dybcio
@ 2022-10-11 1:02 ` Stephen Boyd
2022-10-11 1:20 ` konrad.dybcio
2022-11-07 3:12 ` Bjorn Andersson
1 sibling, 1 reply; 4+ messages in thread
From: Stephen Boyd @ 2022-10-11 1:02 UTC (permalink / raw)
To: Konrad Dybcio, ~postmarketos/upstreaming
Cc: AngeloGioacchino Del Regno, Marijn Suijten, Martin Botka,
Jami Kettunen, Pavel Dubrova, Konrad Dybcio, Andy Gross,
Bjorn Andersson, Michael Turquette, linux-arm-msm, linux-clk,
linux-kernel
Quoting Konrad Dybcio (2022-10-10 08:55:46)
> Add the CLK_OPS_PARENT_ENABLE flag to pixel and byte clk srcs to
> ensure set_rate can succeed.
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org>
> ---
Any Fixes tag?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] clk: qcom: dispcc-sm6350: Add CLK_OPS_PARENT_ENABLE to pixel&byte src
2022-10-11 1:02 ` Stephen Boyd
@ 2022-10-11 1:20 ` konrad.dybcio
0 siblings, 0 replies; 4+ messages in thread
From: konrad.dybcio @ 2022-10-11 1:20 UTC (permalink / raw)
To: Stephen Boyd
Cc: Konrad Dybcio, ~postmarketos/upstreaming,
AngeloGioacchino Del Regno, Marijn Suijten, Martin Botka,
Jami Kettunen, Pavel Dubrova, Andy Gross, Bjorn Andersson,
Michael Turquette, linux-arm-msm, linux-clk, linux-kernel
On 2022-10-11 03:02, Stephen Boyd wrote:
> Quoting Konrad Dybcio (2022-10-10 08:55:46)
>> Add the CLK_OPS_PARENT_ENABLE flag to pixel and byte clk srcs to
>> ensure set_rate can succeed.
>>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org>
>> ---
>
> Any Fixes tag?
Sorry, I keep forgetting..
Fixes: 837519775f1d ("clk: qcom: Add display clock controller driver for
SM6350")
Konrad
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] clk: qcom: dispcc-sm6350: Add CLK_OPS_PARENT_ENABLE to pixel&byte src
2022-10-10 15:55 [PATCH] clk: qcom: dispcc-sm6350: Add CLK_OPS_PARENT_ENABLE to pixel&byte src Konrad Dybcio
2022-10-11 1:02 ` Stephen Boyd
@ 2022-11-07 3:12 ` Bjorn Andersson
1 sibling, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2022-11-07 3:12 UTC (permalink / raw)
To: ~postmarketos/upstreaming, konrad.dybcio
Cc: pashadubrova, mturquette, linux-clk, marijn.suijten,
linux-arm-msm, angelogioacchino.delregno, linux-kernel, sboyd,
martin.botka, Andy Gross, jami.kettunen
On Mon, 10 Oct 2022 17:55:46 +0200, Konrad Dybcio wrote:
> Add the CLK_OPS_PARENT_ENABLE flag to pixel and byte clk srcs to
> ensure set_rate can succeed.
>
>
Applied, thanks!
[1/1] clk: qcom: dispcc-sm6350: Add CLK_OPS_PARENT_ENABLE to pixel&byte src
commit: 92039e8c080c63748f8e133e7cfad33a75daefb6
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-11-07 3:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-10 15:55 [PATCH] clk: qcom: dispcc-sm6350: Add CLK_OPS_PARENT_ENABLE to pixel&byte src Konrad Dybcio
2022-10-11 1:02 ` Stephen Boyd
2022-10-11 1:20 ` konrad.dybcio
2022-11-07 3:12 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox