* [PATCH v2 04/10] clk: sunxi-ng: f1c100s: Add IR mod clock
[not found] <20221107005433.11079-1-andre.przywara@arm.com>
@ 2022-11-07 0:54 ` Andre Przywara
2022-11-07 18:01 ` Jernej Škrabec
0 siblings, 1 reply; 2+ messages in thread
From: Andre Przywara @ 2022-11-07 0:54 UTC (permalink / raw)
To: Chen-Yu Tsai, Samuel Holland, Jernej Skrabec, Rob Herring,
Krzysztof Kozlowski
Cc: Clément Péron, Icenowy Zheng, devicetree,
linux-arm-kernel, linux-sunxi, Michael Turquette, Stephen Boyd,
linux-clk
For some reason the mod clock for the Allwinner F1C100s CIR (infrared
receiver) peripheral was not modeled in the CCU driver.
Add the clock description to the list, and wire it up in the clock list.
By assigning a new clock ID at the end, it extends the number of clocks.
This allows to use the CIR peripheral on any F1C100s series board.
Signed-off-by: Andre Przywara <andre.przywara@arm.com>
---
drivers/clk/sunxi-ng/ccu-suniv-f1c100s.c | 11 ++++++++++-
drivers/clk/sunxi-ng/ccu-suniv-f1c100s.h | 2 +-
include/dt-bindings/clock/suniv-ccu-f1c100s.h | 2 ++
3 files changed, 13 insertions(+), 2 deletions(-)
diff --git a/drivers/clk/sunxi-ng/ccu-suniv-f1c100s.c b/drivers/clk/sunxi-ng/ccu-suniv-f1c100s.c
index ed097c4f780f..0d5b60b123b7 100644
--- a/drivers/clk/sunxi-ng/ccu-suniv-f1c100s.c
+++ b/drivers/clk/sunxi-ng/ccu-suniv-f1c100s.c
@@ -239,7 +239,14 @@ static SUNXI_CCU_MUX_WITH_GATE(i2s_clk, "i2s", i2s_spdif_parents,
static SUNXI_CCU_MUX_WITH_GATE(spdif_clk, "spdif", i2s_spdif_parents,
0x0b4, 16, 2, BIT(31), 0);
-/* The BSP header file has a CIR_CFG, but no mod clock uses this definition */
+static const char * const ir_parents[] = { "osc32k", "osc24M" };
+static SUNXI_CCU_MP_WITH_MUX_GATE(ir_clk, "ir",
+ ir_parents, 0x0b8,
+ 0, 4, /* M */
+ 16, 2, /* P */
+ 24, 2, /* mux */
+ BIT(31), /* gate */
+ 0);
static SUNXI_CCU_GATE(usb_phy0_clk, "usb-phy0", "osc24M",
0x0cc, BIT(1), 0);
@@ -355,6 +362,7 @@ static struct ccu_common *suniv_ccu_clks[] = {
&mmc1_output_clk.common,
&i2s_clk.common,
&spdif_clk.common,
+ &ir_clk.common,
&usb_phy0_clk.common,
&dram_ve_clk.common,
&dram_csi_clk.common,
@@ -446,6 +454,7 @@ static struct clk_hw_onecell_data suniv_hw_clks = {
[CLK_MMC1_OUTPUT] = &mmc1_output_clk.common.hw,
[CLK_I2S] = &i2s_clk.common.hw,
[CLK_SPDIF] = &spdif_clk.common.hw,
+ [CLK_IR] = &ir_clk.common.hw,
[CLK_USB_PHY0] = &usb_phy0_clk.common.hw,
[CLK_DRAM_VE] = &dram_ve_clk.common.hw,
[CLK_DRAM_CSI] = &dram_csi_clk.common.hw,
diff --git a/drivers/clk/sunxi-ng/ccu-suniv-f1c100s.h b/drivers/clk/sunxi-ng/ccu-suniv-f1c100s.h
index b22484f1bb9a..d56a4316289d 100644
--- a/drivers/clk/sunxi-ng/ccu-suniv-f1c100s.h
+++ b/drivers/clk/sunxi-ng/ccu-suniv-f1c100s.h
@@ -29,6 +29,6 @@
/* All bus gates, DRAM gates and mod clocks are exported */
-#define CLK_NUMBER (CLK_AVS + 1)
+#define CLK_NUMBER (CLK_IR + 1)
#endif /* _CCU_SUNIV_F1C100S_H_ */
diff --git a/include/dt-bindings/clock/suniv-ccu-f1c100s.h b/include/dt-bindings/clock/suniv-ccu-f1c100s.h
index f5ac155c9c70..d7570765f424 100644
--- a/include/dt-bindings/clock/suniv-ccu-f1c100s.h
+++ b/include/dt-bindings/clock/suniv-ccu-f1c100s.h
@@ -67,4 +67,6 @@
#define CLK_CODEC 65
#define CLK_AVS 66
+#define CLK_IR 67
+
#endif
--
2.35.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2 04/10] clk: sunxi-ng: f1c100s: Add IR mod clock
2022-11-07 0:54 ` [PATCH v2 04/10] clk: sunxi-ng: f1c100s: Add IR mod clock Andre Przywara
@ 2022-11-07 18:01 ` Jernej Škrabec
0 siblings, 0 replies; 2+ messages in thread
From: Jernej Škrabec @ 2022-11-07 18:01 UTC (permalink / raw)
To: Chen-Yu Tsai, Samuel Holland, Rob Herring, Krzysztof Kozlowski,
Andre Przywara
Cc: Clément Péron, Icenowy Zheng, devicetree,
linux-arm-kernel, linux-sunxi, Michael Turquette, Stephen Boyd,
linux-clk
Dne ponedeljek, 07. november 2022 ob 01:54:27 CET je Andre Przywara
napisal(a):
> For some reason the mod clock for the Allwinner F1C100s CIR (infrared
> receiver) peripheral was not modeled in the CCU driver.
>
> Add the clock description to the list, and wire it up in the clock list.
> By assigning a new clock ID at the end, it extends the number of clocks.
>
> This allows to use the CIR peripheral on any F1C100s series board.
>
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Best regards,
Jernej
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-07 18:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20221107005433.11079-1-andre.przywara@arm.com>
2022-11-07 0:54 ` [PATCH v2 04/10] clk: sunxi-ng: f1c100s: Add IR mod clock Andre Przywara
2022-11-07 18:01 ` Jernej Škrabec
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox