Linux clock framework development
 help / color / mirror / Atom feed
From: Nishanth Menon <nm@ti.com>
To: <sunran001@208suo.com>
Cc: <kristo@kernel.org>, <ssantosh@kernel.org>,
	<mturquette@baylibre.com>, <sboyd@kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-clk@vger.kernel.org>
Subject: Re: [PATCH] clk: keystone: sci-clk: fix application of sizeof to pointer
Date: Thu, 20 Jul 2023 08:55:01 -0500	[thread overview]
Message-ID: <20230720135501.uxjb4oyn26ztmngv@bonelike> (raw)
In-Reply-To: <3ad9c41575c274137001916c896bf2b6@208suo.com>

On 16:42-20230720, sunran001@208suo.com wrote:
> The coccinelle check report:
> ./drivers/scsi/csiostor/csio_mb.c:1554:46-52: ERROR: application of
> sizeof to pointer

-ECONFUSED -> the report does'nt match the file here. did I miss
something?
> 
> Signed-off-by: Ran Sun <sunran001@208suo.com>
> ---
>  drivers/clk/keystone/sci-clk.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/keystone/sci-clk.c b/drivers/clk/keystone/sci-clk.c
> index 6c1df4f11536..2c68c1e09d1f 100644
> --- a/drivers/clk/keystone/sci-clk.c
> +++ b/drivers/clk/keystone/sci-clk.c
> @@ -389,7 +389,7 @@ static struct clk_hw *sci_clk_get(struct of_phandle_args
> *clkspec, void *data)
>  	key.clk_id = clkspec->args[1];
> 
>  	clk = bsearch(&key, provider->clocks, provider->num_clocks,
> -		      sizeof(clk), _cmp_sci_clk);
> +		      sizeof(**clk), _cmp_sci_clk);
> 
>  	if (!clk)
>  		return ERR_PTR(-ENODEV);

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

  reply	other threads:[~2023-07-20 13:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20230720074906.3373-1-xujianghui@cdjrlc.com>
2023-07-20  8:42 ` [PATCH] clk: keystone: sci-clk: fix application of sizeof to pointer sunran001
2023-07-20 13:55   ` Nishanth Menon [this message]
     [not found] <20230721011303.4303-1-xujianghui@cdjrlc.com>
2023-07-21  1:14 ` sunran001
2023-08-22 23:01   ` Stephen Boyd
2026-05-08 15:23 Nishanth Menon
2026-05-08 16:59 ` Andrew Davis
2026-05-08 17:07   ` Nishanth Menon
2026-05-09 11:34 ` Stepan Ionichev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230720135501.uxjb4oyn26ztmngv@bonelike \
    --to=nm@ti.com \
    --cc=kristo@kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@kernel.org \
    --cc=ssantosh@kernel.org \
    --cc=sunran001@208suo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox