Linux clock framework development
 help / color / mirror / Atom feed
From: Nishanth Menon <nm@ti.com>
To: Andrew Davis <afd@ti.com>
Cc: Brian Masney <bmasney@redhat.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Tero Kristo <kristo@kernel.org>, <linux-clk@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	Jing Yangyang <jing.yangyang@zte.com.cn>,
	Zeal Robot <zealci@zte.com.cn>, kernel test robot <lkp@intel.com>,
	Julia Lawall <julia.lawall@inria.fr>,
	David Yang <davidcomponentone@gmail.com>,
	Jing Yangyang <cgel.zte@gmail.com>,
	Ran Sun <sunran001@208suo.com>
Subject: Re: [PATCH] clk: keystone: sci-clk: fix application of sizeof to pointer
Date: Fri, 8 May 2026 12:07:51 -0500	[thread overview]
Message-ID: <20260508170751.3kfpuuoivad6lsjy@prominent> (raw)
In-Reply-To: <003e3057-971b-4b6b-8645-787d76de2387@ti.com>

On 11:59-20260508, Andrew Davis wrote:

[...]
> >   - Functionality: No impact (on Linux architectures), thus no Fixes/Stable tag.
> 
> Not sure what "on Linux architectures" means here, this should be true for any
> sane system, right? You are going from the sizeof(pointer-to-pointer) to the
> sizeof(pointer), both should be equal. This is just to be more technically

Yep (also why i put it in diffstat notes ;) ) - any sane system
(which is what we support in Linux ;) ) - though C standard does'nt
explicitly call that out from what I could gather, it is practically
what all systems tend to do. i had the extreme paranoia about this
and got claude[1] to check it out using clang.. Results match the
expectation.

> correct and silence a Coccinelle warning. Anyway,

Yep, That is all this is.. patches keep popping up every few years.

> 
> Reviewed-by: Andrew Davis <afd@ti.com>
> 

Thanks.
[1] https://gist.githubusercontent.com/nmenon/afa9ac915e189334f048c177f16fe54f/raw/ccd08843ff7193090f9fbdca3f5c76d0a4366c85/quick%2520check%2520with%2520clang

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
https://ti.com/opensource

  reply	other threads:[~2026-05-08 17:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-08 15:23 [PATCH] clk: keystone: sci-clk: fix application of sizeof to pointer Nishanth Menon
2026-05-08 16:59 ` Andrew Davis
2026-05-08 17:07   ` Nishanth Menon [this message]
2026-05-09 11:34 ` Stepan Ionichev
     [not found] <20230721011303.4303-1-xujianghui@cdjrlc.com>
2023-07-21  1:14 ` sunran001
2023-08-22 23:01   ` Stephen Boyd
     [not found] <20230720074906.3373-1-xujianghui@cdjrlc.com>
2023-07-20  8:42 ` sunran001
2023-07-20 13:55   ` Nishanth Menon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260508170751.3kfpuuoivad6lsjy@prominent \
    --to=nm@ti.com \
    --cc=afd@ti.com \
    --cc=bmasney@redhat.com \
    --cc=cgel.zte@gmail.com \
    --cc=davidcomponentone@gmail.com \
    --cc=jing.yangyang@zte.com.cn \
    --cc=julia.lawall@inria.fr \
    --cc=kristo@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@kernel.org \
    --cc=ssantosh@kernel.org \
    --cc=sunran001@208suo.com \
    --cc=zealci@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox