* [PATCH v3 05/50] dt-bindings: clk: at91: add sam9x7 clock controller
@ 2023-07-28 10:23 Varshini Rajendran
2023-07-28 11:40 ` Krzysztof Kozlowski
0 siblings, 1 reply; 6+ messages in thread
From: Varshini Rajendran @ 2023-07-28 10:23 UTC (permalink / raw)
To: mturquette, sboyd, robh+dt, krzysztof.kozlowski+dt, conor+dt,
nicolas.ferre, alexandre.belloni, claudiu.beznea, linux-clk,
devicetree, linux-arm-kernel, linux-kernel
Cc: varshini.rajendran
Add bindings for SAM9X7's pmc.
Signed-off-by: Varshini Rajendran <varshini.rajendran@microchip.com>
---
.../devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml b/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml
index c1bdcd9058ed..ce0d99503645 100644
--- a/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml
+++ b/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml
@@ -43,6 +43,7 @@ properties:
- atmel,sama5d4-pmc
- microchip,sam9x60-pmc
- microchip,sama7g5-pmc
+ - microchip,sam9x7-pmc
- const: syscon
reg:
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v3 05/50] dt-bindings: clk: at91: add sam9x7 clock controller
2023-07-28 10:23 [PATCH v3 05/50] dt-bindings: clk: at91: add sam9x7 clock controller Varshini Rajendran
@ 2023-07-28 11:40 ` Krzysztof Kozlowski
2023-07-28 11:46 ` Krzysztof Kozlowski
2023-08-10 5:31 ` Varshini.Rajendran
0 siblings, 2 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2023-07-28 11:40 UTC (permalink / raw)
To: Varshini Rajendran, mturquette, sboyd, robh+dt,
krzysztof.kozlowski+dt, conor+dt, nicolas.ferre,
alexandre.belloni, claudiu.beznea, linux-clk, devicetree,
linux-arm-kernel, linux-kernel
On 28/07/2023 12:23, Varshini Rajendran wrote:
> Add bindings for SAM9X7's pmc.
>
> Signed-off-by: Varshini Rajendran <varshini.rajendran@microchip.com>
> ---
> .../devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml b/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml
> index c1bdcd9058ed..ce0d99503645 100644
> --- a/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml
> +++ b/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml
> @@ -43,6 +43,7 @@ properties:
> - atmel,sama5d4-pmc
> - microchip,sam9x60-pmc
> - microchip,sama7g5-pmc
> + - microchip,sam9x7-pmc
> - const: syscon
Where is the change in allOf:if:then:? No need for it? Why? Where is the
driver change?
Please do not send huge series to 50 different people and subsystems.
With your lack of threading it is so difficult to review.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3 05/50] dt-bindings: clk: at91: add sam9x7 clock controller
2023-07-28 11:40 ` Krzysztof Kozlowski
@ 2023-07-28 11:46 ` Krzysztof Kozlowski
2023-08-10 5:31 ` Varshini.Rajendran
1 sibling, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2023-07-28 11:46 UTC (permalink / raw)
To: Varshini Rajendran, mturquette, sboyd, robh+dt,
krzysztof.kozlowski+dt, conor+dt, nicolas.ferre,
alexandre.belloni, claudiu.beznea, linux-clk, devicetree,
linux-arm-kernel, linux-kernel
On 28/07/2023 13:40, Krzysztof Kozlowski wrote:
> On 28/07/2023 12:23, Varshini Rajendran wrote:
>> Add bindings for SAM9X7's pmc.
>>
>> Signed-off-by: Varshini Rajendran <varshini.rajendran@microchip.com>
>> ---
>> .../devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml b/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml
>> index c1bdcd9058ed..ce0d99503645 100644
>> --- a/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml
>> +++ b/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml
>> @@ -43,6 +43,7 @@ properties:
>> - atmel,sama5d4-pmc
>> - microchip,sam9x60-pmc
>> - microchip,sama7g5-pmc
>> + - microchip,sam9x7-pmc
>> - const: syscon
>
> Where is the change in allOf:if:then:? No need for it? Why? Where is the
> driver change?
>
> Please do not send huge series to 50 different people and subsystems.
> With your lack of threading it is so difficult to review.
You already got this comment and not much improved:
https://lore.kernel.org/all/f2f8cabf-ca4d-c6f3-5561-b24334be89d1@linaro.org/
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3 05/50] dt-bindings: clk: at91: add sam9x7 clock controller
2023-07-28 11:40 ` Krzysztof Kozlowski
2023-07-28 11:46 ` Krzysztof Kozlowski
@ 2023-08-10 5:31 ` Varshini.Rajendran
2023-08-10 6:02 ` Krzysztof Kozlowski
1 sibling, 1 reply; 6+ messages in thread
From: Varshini.Rajendran @ 2023-08-10 5:31 UTC (permalink / raw)
To: krzysztof.kozlowski, mturquette, sboyd, robh+dt,
krzysztof.kozlowski+dt, conor+dt, Nicolas.Ferre,
alexandre.belloni, claudiu.beznea, linux-clk, devicetree,
linux-arm-kernel, linux-kernel
On 28/07/23 5:10 pm, Krzysztof Kozlowski wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On 28/07/2023 12:23, Varshini Rajendran wrote:
>> Add bindings for SAM9X7's pmc.
>>
>> Signed-off-by: Varshini Rajendran <varshini.rajendran@microchip.com>
>> ---
>> .../devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml b/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml
>> index c1bdcd9058ed..ce0d99503645 100644
>> --- a/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml
>> +++ b/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml
>> @@ -43,6 +43,7 @@ properties:
>> - atmel,sama5d4-pmc
>> - microchip,sam9x60-pmc
>> - microchip,sama7g5-pmc
>> + - microchip,sam9x7-pmc
>> - const: syscon
>
> Where is the change in allOf:if:then:? No need for it? Why? Where is the
> driver change?
Hi Krzysztof,
This SoC has a new pmc driver and is not dependent on any other
compatible as a fallback. So I think adding it in the enum makes sense.
Correct me if I am wrong. The driver is in the series. Apologies for
breaking the thread. I will send another version following your advice
about splitting up the patch series.
>
> Please do not send huge series to 50 different people and subsystems.
> With your lack of threading it is so difficult to review.
>
> Best regards,
> Krzysztof
>
--
Thanks and Regards,
Varshini Rajendran.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3 05/50] dt-bindings: clk: at91: add sam9x7 clock controller
2023-08-10 5:31 ` Varshini.Rajendran
@ 2023-08-10 6:02 ` Krzysztof Kozlowski
2023-08-10 6:07 ` Varshini.Rajendran
0 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2023-08-10 6:02 UTC (permalink / raw)
To: Varshini.Rajendran, mturquette, sboyd, robh+dt,
krzysztof.kozlowski+dt, conor+dt, Nicolas.Ferre,
alexandre.belloni, claudiu.beznea, linux-clk, devicetree,
linux-arm-kernel, linux-kernel
On 10/08/2023 07:31, Varshini.Rajendran@microchip.com wrote:
on/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml
b/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml
>>> index c1bdcd9058ed..ce0d99503645 100644
>>> --- a/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml
>>> +++ b/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml
>>> @@ -43,6 +43,7 @@ properties:
>>> - atmel,sama5d4-pmc
>>> - microchip,sam9x60-pmc
>>> - microchip,sama7g5-pmc
>>> + - microchip,sam9x7-pmc
>>> - const: syscon
>>
>> Where is the change in allOf:if:then:? No need for it? Why? Where is the
>> driver change?
>
> Hi Krzysztof,
>
> This SoC has a new pmc driver and is not dependent on any other
> compatible as a fallback. So I think adding it in the enum makes sense.
This I did not question.
I was speaking about allOf:if:then: section.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3 05/50] dt-bindings: clk: at91: add sam9x7 clock controller
2023-08-10 6:02 ` Krzysztof Kozlowski
@ 2023-08-10 6:07 ` Varshini.Rajendran
0 siblings, 0 replies; 6+ messages in thread
From: Varshini.Rajendran @ 2023-08-10 6:07 UTC (permalink / raw)
To: krzysztof.kozlowski, mturquette, sboyd, robh+dt,
krzysztof.kozlowski+dt, conor+dt, Nicolas.Ferre,
alexandre.belloni, linux-clk, devicetree, linux-arm-kernel,
linux-kernel
On 10/08/23 11:32 am, Krzysztof Kozlowski wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On 10/08/2023 07:31, Varshini.Rajendran@microchip.com wrote:
> on/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml
> b/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml
>>>> index c1bdcd9058ed..ce0d99503645 100644
>>>> --- a/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml
>>>> +++ b/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml
>>>> @@ -43,6 +43,7 @@ properties:
>>>> - atmel,sama5d4-pmc
>>>> - microchip,sam9x60-pmc
>>>> - microchip,sama7g5-pmc
>>>> + - microchip,sam9x7-pmc
>>>> - const: syscon
>>>
>>> Where is the change in allOf:if:then:? No need for it? Why? Where is the
>>> driver change?
>>
>> Hi Krzysztof,
>>
>> This SoC has a new pmc driver and is not dependent on any other
>> compatible as a fallback. So I think adding it in the enum makes sense.
>
> This I did not question.
>
> I was speaking about allOf:if:then: section.
Okay. Got your point. I will fix that in the next version. Thanks!
>
>
> Best regards,
> Krzysztof
>
--
Thanks and Regards,
Varshini Rajendran.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-08-10 6:07 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-28 10:23 [PATCH v3 05/50] dt-bindings: clk: at91: add sam9x7 clock controller Varshini Rajendran
2023-07-28 11:40 ` Krzysztof Kozlowski
2023-07-28 11:46 ` Krzysztof Kozlowski
2023-08-10 5:31 ` Varshini.Rajendran
2023-08-10 6:02 ` Krzysztof Kozlowski
2023-08-10 6:07 ` Varshini.Rajendran
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox