* [RESEND PATCH v2] clk: qcom: gcc-sm8250: Fix gcc_sdcc2_apps_clk_src
@ 2023-08-02 21:04 Patrick Whewell
2023-08-03 6:21 ` Vinod Koul
2023-08-03 16:38 ` Bjorn Andersson
0 siblings, 2 replies; 3+ messages in thread
From: Patrick Whewell @ 2023-08-02 21:04 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Michael Turquette,
Stephen Boyd, Bryan O'Donoghue, Vinod Koul, Taniya Das,
Venkata Narendra Kumar Gutta, linux-arm-msm, linux-clk,
linux-kernel
Cc: Dmitry Baryshkov, William Gray, Patrick Whewell
GPLL9 is not on by default, which causes a "gcc_sdcc2_apps_clk_src: rcg
didn't update its configuration" error when booting. Set .flags =
CLK_OPS_PARENT_ENABLE to fix the error.
Fixes: 3e5770921a88 ("clk: qcom: gcc: Add global clock controller driver for SM8250")
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Signed-off-by: Patrick Whewell <patrick.whewell@sightlineapplications.com>
---
Changes in v2:
- Updated commit messaage to mention GPLL9 not being on by default
being the cause of error
- Moved Signed-off-by line to the bottom.
drivers/clk/qcom/gcc-sm8250.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/qcom/gcc-sm8250.c b/drivers/clk/qcom/gcc-sm8250.c
index b6cf4bc88d4d..d3c75bb55946 100644
--- a/drivers/clk/qcom/gcc-sm8250.c
+++ b/drivers/clk/qcom/gcc-sm8250.c
@@ -721,6 +721,7 @@ static struct clk_rcg2 gcc_sdcc2_apps_clk_src = {
.name = "gcc_sdcc2_apps_clk_src",
.parent_data = gcc_parent_data_4,
.num_parents = ARRAY_SIZE(gcc_parent_data_4),
+ .flags = CLK_OPS_PARENT_ENABLE,
.ops = &clk_rcg2_floor_ops,
},
};
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [RESEND PATCH v2] clk: qcom: gcc-sm8250: Fix gcc_sdcc2_apps_clk_src
2023-08-02 21:04 [RESEND PATCH v2] clk: qcom: gcc-sm8250: Fix gcc_sdcc2_apps_clk_src Patrick Whewell
@ 2023-08-03 6:21 ` Vinod Koul
2023-08-03 16:38 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2023-08-03 6:21 UTC (permalink / raw)
To: Patrick Whewell
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Michael Turquette,
Stephen Boyd, Bryan O'Donoghue, Taniya Das,
Venkata Narendra Kumar Gutta, linux-arm-msm, linux-clk,
linux-kernel, Dmitry Baryshkov, William Gray
On 02-08-23, 14:04, Patrick Whewell wrote:
> GPLL9 is not on by default, which causes a "gcc_sdcc2_apps_clk_src: rcg
> didn't update its configuration" error when booting. Set .flags =
> CLK_OPS_PARENT_ENABLE to fix the error.
Reviewed-by: Vinod Koul <vkoul@kernel.org>
>
> Fixes: 3e5770921a88 ("clk: qcom: gcc: Add global clock controller driver for SM8250")
> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> Signed-off-by: Patrick Whewell <patrick.whewell@sightlineapplications.com>
> ---
> Changes in v2:
> - Updated commit messaage to mention GPLL9 not being on by default
> being the cause of error
> - Moved Signed-off-by line to the bottom.
>
> drivers/clk/qcom/gcc-sm8250.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/qcom/gcc-sm8250.c b/drivers/clk/qcom/gcc-sm8250.c
> index b6cf4bc88d4d..d3c75bb55946 100644
> --- a/drivers/clk/qcom/gcc-sm8250.c
> +++ b/drivers/clk/qcom/gcc-sm8250.c
> @@ -721,6 +721,7 @@ static struct clk_rcg2 gcc_sdcc2_apps_clk_src = {
> .name = "gcc_sdcc2_apps_clk_src",
> .parent_data = gcc_parent_data_4,
> .num_parents = ARRAY_SIZE(gcc_parent_data_4),
> + .flags = CLK_OPS_PARENT_ENABLE,
> .ops = &clk_rcg2_floor_ops,
> },
> };
> --
> 2.25.1
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [RESEND PATCH v2] clk: qcom: gcc-sm8250: Fix gcc_sdcc2_apps_clk_src
2023-08-02 21:04 [RESEND PATCH v2] clk: qcom: gcc-sm8250: Fix gcc_sdcc2_apps_clk_src Patrick Whewell
2023-08-03 6:21 ` Vinod Koul
@ 2023-08-03 16:38 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2023-08-03 16:38 UTC (permalink / raw)
To: Andy Gross, Konrad Dybcio, Michael Turquette, Stephen Boyd,
Bryan O'Donoghue, Vinod Koul, Taniya Das,
Venkata Narendra Kumar Gutta, linux-arm-msm, linux-clk,
linux-kernel, Patrick Whewell
Cc: Dmitry Baryshkov, William Gray
On Wed, 02 Aug 2023 14:04:00 -0700, Patrick Whewell wrote:
> GPLL9 is not on by default, which causes a "gcc_sdcc2_apps_clk_src: rcg
> didn't update its configuration" error when booting. Set .flags =
> CLK_OPS_PARENT_ENABLE to fix the error.
>
>
Applied, thanks!
[1/1] clk: qcom: gcc-sm8250: Fix gcc_sdcc2_apps_clk_src
commit: 783cb693828ce487cf0bc6ad16cbcf2caae6f8d9
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-08-03 16:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-02 21:04 [RESEND PATCH v2] clk: qcom: gcc-sm8250: Fix gcc_sdcc2_apps_clk_src Patrick Whewell
2023-08-03 6:21 ` Vinod Koul
2023-08-03 16:38 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox