* [PATCH] ti: fix possible memory leak in _ti_omap4_clkctrl_setup
@ 2023-10-25 9:07 Hangyu Hua
2023-10-26 12:18 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: Hangyu Hua @ 2023-10-25 9:07 UTC (permalink / raw)
To: kristo, mturquette, sboyd, tony, claudiu.beznea, robh,
andriy.shevchenko, dario.binacchi
Cc: linux-omap, linux-clk, linux-kernel, Hangyu Hua
kstrndup and kstrdup_and_replace in clkctrl_get_name can perform
dynamic memory allocation. So clkctrl_name needs to be freed when
provider->clkdm_name is NULL.
Fixes: bd46cd0b802d ("clk: ti: clkctrl: check return value of kasprintf()")
Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
---
drivers/clk/ti/clkctrl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/ti/clkctrl.c b/drivers/clk/ti/clkctrl.c
index 607e34d8e289..cb4aa8a45bb2 100644
--- a/drivers/clk/ti/clkctrl.c
+++ b/drivers/clk/ti/clkctrl.c
@@ -591,6 +591,7 @@ static void __init _ti_omap4_clkctrl_setup(struct device_node *node)
provider->clkdm_name = kasprintf(GFP_KERNEL,
"%s_clkdm", clkctrl_name);
if (!provider->clkdm_name) {
+ kfree(clkctrl_name);
kfree(provider);
return;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ti: fix possible memory leak in _ti_omap4_clkctrl_setup
2023-10-25 9:07 [PATCH] ti: fix possible memory leak in _ti_omap4_clkctrl_setup Hangyu Hua
@ 2023-10-26 12:18 ` Andy Shevchenko
2023-10-27 2:13 ` Hangyu Hua
0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2023-10-26 12:18 UTC (permalink / raw)
To: Hangyu Hua
Cc: kristo, mturquette, sboyd, tony, claudiu.beznea, robh,
dario.binacchi, linux-omap, linux-clk, linux-kernel
On Wed, Oct 25, 2023 at 05:07:41PM +0800, Hangyu Hua wrote:
> kstrndup and kstrdup_and_replace in clkctrl_get_name can perform
kstrndup()
kstrdup_and_replace()
clkctrl_get_name()
> dynamic memory allocation. So clkctrl_name needs to be freed when
> provider->clkdm_name is NULL.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ti: fix possible memory leak in _ti_omap4_clkctrl_setup
2023-10-26 12:18 ` Andy Shevchenko
@ 2023-10-27 2:13 ` Hangyu Hua
0 siblings, 0 replies; 3+ messages in thread
From: Hangyu Hua @ 2023-10-27 2:13 UTC (permalink / raw)
To: Andy Shevchenko
Cc: kristo, mturquette, sboyd, tony, claudiu.beznea, robh,
dario.binacchi, linux-omap, linux-clk, linux-kernel
On 26/10/2023 20:18, Andy Shevchenko wrote:
> On Wed, Oct 25, 2023 at 05:07:41PM +0800, Hangyu Hua wrote:
>> kstrndup and kstrdup_and_replace in clkctrl_get_name can perform
>
> kstrndup()
> kstrdup_and_replace()
> clkctrl_get_name()
>
I see. I will send a v2 later.
Thanks,
Hangyu
>> dynamic memory allocation. So clkctrl_name needs to be freed when
>> provider->clkdm_name is NULL.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-27 2:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-25 9:07 [PATCH] ti: fix possible memory leak in _ti_omap4_clkctrl_setup Hangyu Hua
2023-10-26 12:18 ` Andy Shevchenko
2023-10-27 2:13 ` Hangyu Hua
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox