From: Taniya Das <quic_tdas@quicinc.com>
To: "Stephen Boyd" <sboyd@kernel.org>,
"Michael Turquette " <mturquette@baylibre.com>,
"Bjorn Andersson" <andersson@kernel.org>,
"Konrad Dybcio" <konrad.dybcio@linaro.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>
Cc: Taniya Das <quic_tdas@quicinc.com>,
<linux-arm-msm@vger.kernel.org>, <linux-clk@vger.kernel.org>,
<devicetree@vger.kernel.org>
Subject: [PATCH v2 6/8] clk: qcom: camcc-sc7280: Add parent dependency to all camera GDSCs
Date: Mon, 18 Mar 2024 11:05:53 +0530 [thread overview]
Message-ID: <20240318053555.20405-7-quic_tdas@quicinc.com> (raw)
In-Reply-To: <20240318053555.20405-1-quic_tdas@quicinc.com>
Camera titan top GDSC is a parent supply to all other camera GDSCs. Titan
top GDSC is required to be enabled before enabling any other camera GDSCs
and it should be disabled only after all other camera GDSCs are disabled.
Ensure this behavior by marking titan top GDSC as parent of all other
camera GDSCs.
Fixes: 1daec8cfebc2 ("clk: qcom: camcc: Add camera clock controller driver for SC7280")
Signed-off-by: Taniya Das <quic_tdas@quicinc.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
drivers/clk/qcom/camcc-sc7280.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/clk/qcom/camcc-sc7280.c b/drivers/clk/qcom/camcc-sc7280.c
index 27bfb0f959c4..da29d3b953ee 100644
--- a/drivers/clk/qcom/camcc-sc7280.c
+++ b/drivers/clk/qcom/camcc-sc7280.c
@@ -2267,6 +2267,7 @@ static struct gdsc cam_cc_bps_gdsc = {
.name = "cam_cc_bps_gdsc",
},
.pwrsts = PWRSTS_OFF_ON,
+ .parent = &cam_cc_titan_top_gdsc.pd,
.flags = HW_CTRL | RETAIN_FF_ENABLE,
};
@@ -2279,6 +2280,7 @@ static struct gdsc cam_cc_ife_0_gdsc = {
.name = "cam_cc_ife_0_gdsc",
},
.pwrsts = PWRSTS_OFF_ON,
+ .parent = &cam_cc_titan_top_gdsc.pd,
.flags = RETAIN_FF_ENABLE,
};
@@ -2291,6 +2293,7 @@ static struct gdsc cam_cc_ife_1_gdsc = {
.name = "cam_cc_ife_1_gdsc",
},
.pwrsts = PWRSTS_OFF_ON,
+ .parent = &cam_cc_titan_top_gdsc.pd,
.flags = RETAIN_FF_ENABLE,
};
@@ -2303,6 +2306,7 @@ static struct gdsc cam_cc_ife_2_gdsc = {
.name = "cam_cc_ife_2_gdsc",
},
.pwrsts = PWRSTS_OFF_ON,
+ .parent = &cam_cc_titan_top_gdsc.pd,
.flags = RETAIN_FF_ENABLE,
};
@@ -2315,6 +2319,7 @@ static struct gdsc cam_cc_ipe_0_gdsc = {
.name = "cam_cc_ipe_0_gdsc",
},
.pwrsts = PWRSTS_OFF_ON,
+ .parent = &cam_cc_titan_top_gdsc.pd,
.flags = HW_CTRL | RETAIN_FF_ENABLE,
};
--
2.17.1
next prev parent reply other threads:[~2024-03-18 5:37 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-18 5:35 [PATCH v2 0/8] Add updates for clock controllers to support QCM6490 Taniya Das
2024-03-18 5:35 ` [PATCH v2 1/8] dt-bindings: clock: qcom: Add compatible for QCM6490 boards Taniya Das
2024-03-18 7:11 ` Luca Weiss
2024-05-31 9:28 ` Taniya Das
2024-05-31 9:58 ` Luca Weiss
2024-03-18 7:47 ` Krzysztof Kozlowski
2024-05-31 9:28 ` Taniya Das
2024-03-18 7:50 ` Krzysztof Kozlowski
2024-03-18 5:35 ` [PATCH v2 2/8] clk: qcom: lpassaudiocc-sc7280: Add support for LPASS resets for QCM6490 Taniya Das
2024-03-18 7:50 ` Krzysztof Kozlowski
2024-05-31 9:28 ` Taniya Das
2024-03-18 7:51 ` Krzysztof Kozlowski
2024-03-18 5:35 ` [PATCH v2 3/8] clk: qcom: lpassaudiocc-sc7280: Fix the regmap conflict warning Taniya Das
2024-03-18 7:52 ` Krzysztof Kozlowski
2024-03-18 5:35 ` [PATCH v2 4/8] clk: qcom: sc7280: Update the transition delay for GDSC Taniya Das
2024-03-18 7:53 ` Krzysztof Kozlowski
2024-05-31 9:30 ` Taniya Das
2024-05-31 10:20 ` Dmitry Baryshkov
2024-03-18 5:35 ` [PATCH v2 5/8] clk: qcom: gcc-sc7280: Update force mem core bit for UFS ICE clock Taniya Das
2024-04-23 13:14 ` Konrad Dybcio
2024-03-18 5:35 ` Taniya Das [this message]
2024-04-23 13:14 ` [PATCH v2 6/8] clk: qcom: camcc-sc7280: Add parent dependency to all camera GDSCs Konrad Dybcio
2024-03-18 5:35 ` [PATCH v2 7/8] arm64: dts: qcom: qcm6490-idp: Update protected clocks list Taniya Das
2024-03-18 7:54 ` Krzysztof Kozlowski
2024-05-31 9:34 ` Taniya Das
2024-05-31 10:19 ` Dmitry Baryshkov
2024-03-18 5:35 ` [PATCH v2 8/8] arm64: dts: qcom: qcs6490-rb3gen2: Update the LPASS audio node Taniya Das
2024-03-18 7:55 ` Krzysztof Kozlowski
2024-04-23 13:16 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240318053555.20405-7-quic_tdas@quicinc.com \
--to=quic_tdas@quicinc.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox