Re: [PATCH v2 3/8] clk: qcom: lpassaudiocc-sc7280: Fix the regmap conflict warning

[Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>]

On 18/03/2024 06:35, Taniya Das wrote:
> Update the lpassaudio_cc_reset regmap name and max register details
> to handle the regmap conflict warning between lpassaudio_cc_reset
> and lpassaudio_cc.

What conflict? How does this bug affect users? Explain this in commit msg.

> 
> Fixes: a9dd26639d05 ("clk: qcom: lpass: Add support for LPASS clock controller for SC7280")
> Signed-off-by: Taniya Das <quic_tdas@quicinc.com>
> ---
>  drivers/clk/qcom/lpassaudiocc-sc7280.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/clk/qcom/lpassaudiocc-sc7280.c b/drivers/clk/qcom/lpassaudiocc-sc7280.c
> index d68139762a80..3f1e756a6e71 100644
> --- a/drivers/clk/qcom/lpassaudiocc-sc7280.c
> +++ b/drivers/clk/qcom/lpassaudiocc-sc7280.c
> @@ -755,6 +755,9 @@ static int lpass_audio_cc_sc7280_probe(struct platform_device *pdev)
>  	int ret;
> 
>  	if (of_device_is_compatible(pdev->dev.of_node, "qcom,qcm6490-lpassaudiocc")) {
> +		lpass_audio_cc_sc7280_regmap_config.name = "lpassaudio_cc_reset";
> +		lpass_audio_cc_sc7280_regmap_config.max_register = 0xc8;
> +
>  		ret = qcom_cc_probe_by_index(pdev, 1, &lpass_audio_cc_reset_sc7280_desc);
>  		if (ret)
>  			dev_err(&pdev->dev, "Failed to register LPASS AUDIO CC Resets\n");
> @@ -787,6 +790,9 @@ static int lpass_audio_cc_sc7280_probe(struct platform_device *pdev)
>  		goto exit;
>  	}
> 
> +	lpass_audio_cc_sc7280_regmap_config.name = "lpassaudio_cc_reset";
> +	lpass_audio_cc_sc7280_regmap_config.max_register = 0xc8;

Why do you have it in two places?


Best regards,
Krzysztof